November 29, 2012 Re: [dmd-internals] Is there a reason that inlining happens so early? | ||||
|---|---|---|---|---|
| ||||
 Posted in reply to Don Clugston | On 11/29/2012 12:02 AM, Don Clugston wrote: > On 27 November 2012 22:03, Walter Bright <walter@digitalmars.com> wrote: >> On 11/28/2012 3:11 AM, Don Clugston wrote: >>> Oooh, you're right. EXCEPT: expression.c 5411: FuncExp's get inlined >>> during the semantic3 pass expression.c 5618: DeclarationExps get inlined >>> during the semantic3 pass. So, is there anything stopping us from moving >>> these guys into the inliner pass? >> >> I do not recall the reason for those exceptions, or even if I wrote them. Is >> there an easy way to look back in the git history to see when they appeared? > Well, I wrote this pull to just remove them. And it passes. > > https://github.com/D-Programming-Language/dmd/pull/1333 > Well, that's one way to find out why it was there! _______________________________________________ dmd-internals mailing list dmd-internals@puremagic.com http://lists.puremagic.com/mailman/listinfo/dmd-internals | |||
Permalink
ReplyNovember 29, 2012 Re: [dmd-internals] Is there a reason that inlining happens so early? | ||||
|---|---|---|---|---|
| ||||
 Posted in reply to Walter Bright | On 28 November 2012 14:25, Walter Bright <walter@digitalmars.com> wrote: > On 11/29/2012 12:02 AM, Don Clugston wrote: >> >> On 27 November 2012 22:03, Walter Bright <walter@digitalmars.com> wrote: >>> >>> On 11/28/2012 3:11 AM, Don Clugston wrote: >>>> >>>> Oooh, you're right. EXCEPT: expression.c 5411: FuncExp's get inlined during the semantic3 pass expression.c 5618: DeclarationExps get inlined during the semantic3 pass. So, is there anything stopping us from moving these guys into the inliner pass? >>> >>> >>> I do not recall the reason for those exceptions, or even if I wrote them. >>> Is >>> there an easy way to look back in the git history to see when they >>> appeared? >> >> Well, I wrote this pull to just remove them. And it passes. >> >> https://github.com/D-Programming-Language/dmd/pull/1333 >> > Well, that's one way to find out why it was there! If that gets merged in, then the most disgusting bit of code I've ever written can be ripped out of the compiler: https://github.com/D-Programming-Language/dmd/pull/1334 _______________________________________________ dmd-internals mailing list dmd-internals@puremagic.com http://lists.puremagic.com/mailman/listinfo/dmd-internals | |||
Copyright © 1999-2021 by the D Language Foundation