Dear DMD developers,

Thank you for developing DMD.
I maintain dmd and related packages of MacPorts.

We noticed a few updates to v2.066.0 of dmd, druntime and phobos without changing their tags in the git repository (releases).

<https://github.com/D-Programming-Language/dmd/releases>

We call such updates `stealth updates'.
The checksums are verified to make sure that the correct source code
have been downloaded by MacPorts' port command.
The checksums are written in the package description file, called Portfile.
We need to special treatment for stealth updates.

<https://trac.macports.org/wiki/PortfileRecipes#stealth-updates>

From the viewpoint of package maintainer,
stealth updates are not a good idea.
I understand that the changes are for bug fixes or enhancement.
But if so a new version number (e.g. v2.066.1 or v2.066.0.1)
or a tag should be given to the commit.

I appreciate if you discussed my suggestion among the developers and considered adopting it.

Regards,

Takeshi

-----
Takeshi Enomoto
takeshi@macports.org

-----
Takeshi Enomoto
takeshi@macports.org


_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

Am 06.09.2014, 10:24 Uhr, schrieb Takeshi Enomoto via dmd-beta <dmd-beta@puremagic.com>:

> Dear DMD developers,
>
> Thank you for developing DMD.
> I maintain dmd and related packages of MacPorts.
>
> We noticed a few updates to v2.066.0 of dmd, druntime and phobos
> without changing their tags in the git repository (releases).
>
> <https://github.com/D-Programming-Language/dmd/releases>
>
> We call such updates `stealth updates'.
> The checksums are verified to make sure that the correct source code
> have been downloaded by MacPorts' port command.
> The checksums are written in the package description file, called Portfile.
> We need to special treatment for stealth updates.
>
> <https://trac.macports.org/wiki/PortfileRecipes#stealth-updates>
>
> From the viewpoint of package maintainer,
> stealth updates are not a good idea.
> I understand that the changes are for bug fixes or enhancement.
> But if so a new version number (e.g. v2.066.1 or v2.066.0.1)
> or a tag should be given to the commit.
>
> I appreciate if you discussed my suggestion among the developers and
> considered adopting it.
>
> Regards,
>
> Takeshi

Hello Takeshi,

I am a package maintainer for Gentoo so I know the issue from both closed and open source projects, like Google Earth or OpenXCom, which happened to modify their uploaded releases. Did this also happen to the "official" all-systems .zip in the download section of dlang.org? That's the one I use, because D's inventors have expressed the wish to keep track of the download count to roughly estimate the user base, which they can't with GitHub I think.
Otherwise I think it is understood that bug fix releases should receive an incremented version number as it happened in the past.
And to add to your concerns: Once a user (e.g. we package maintainers) have downloaded a source package and the checksums got calculated, there is no system that periodically checks if the source on the internet didn't change in the mean time. As a result package maintainers learn about that by people who try the new package for the first time and find the package manager complaining about incorrect checksums.
I'm going to check my dmd package now as well, just to be sure. Fortunately both MacPorts and the ebuild system allow revisions independently of the original software's version number, so it is easy to bump that for a changed source bundle. Thanks for the hint!

Best regards,
Marco
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

Am 06.09.2014, 13:41 Uhr, schrieb Marco Leise via dmd-beta <dmd-beta@puremagic.com>:

> I'm going to check my dmd package now as well, just to be sure.

That change to the 2.066 release tag happened one day before I packaged it. Gentoo is not affected.
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

On 6 Sep 2014, at 10:24, Takeshi Enomoto via dmd-beta wrote:
> I understand that the changes are for bug fixes or enhancement.
> But if so a new version number (e.g. v2.066.1 or v2.066.0.1)
> or a tag should be given to the commit.

Does anybody know what exactly happened here? Stealth updates are not supposed to be part of our release process.

I was not following D development closely for the last few weeks and have no idea what is going on.

Best,
David
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

After 2.066.0 released, I pushed some regression fixes into 2.066 branch
for the point release 2.066.1.
But, it is not yet released because Andrew Edwards is now stepping down...

Kenji Hara


2014-09-07 0:11 GMT+09:00 David Nadlinger via dmd-beta < dmd-beta@puremagic.com>:

> On 6 Sep 2014, at 10:24, Takeshi Enomoto via dmd-beta wrote:
>
>> I understand that the changes are for bug fixes or enhancement. But if so a new version number (e.g. v2.066.1 or v2.066.0.1) or a tag should be given to the commit.
>>
>
> Does anybody know what exactly happened here? Stealth updates are not supposed to be part of our release process.
>
> I was not following D development closely for the last few weeks and have no idea what is going on.
>
> Best,
> David
>
> _______________________________________________
> dmd-beta mailing list
> dmd-beta@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-beta
>

I think I know what is going on now. The source of the problem seems to be a bug in your Portfile, and not an issue on our side.

I'm not familiar with how the GitHub handling works exactly, but
---
github.setup        D-Programming-Language dmd 2.066
---
seems to suggest that it fetches the "2.066" branch. This is not a good idea, because further point releases are also prepared there, as Kenji already mentioned. Instead, please use the actual release tag, e.g. "v2.066.0".

Best,
David


On 6 Sep 2014, at 10:24, Takeshi Enomoto via dmd-beta wrote:
> Dear DMD developers,
>
> Thank you for developing DMD.
> I maintain dmd and related packages of MacPorts.
>
> We noticed a few updates to v2.066.0 of dmd, druntime and phobos
> without changing their tags in the git repository (releases).
>
> <https://github.com/D-Programming-Language/dmd/releases>
>
> We call such updates `stealth updates'.
> The checksums are verified to make sure that the correct source code
> have been downloaded by MacPorts' port command.
> The checksums are written in the package description file, called Portfile.
> We need to special treatment for stealth updates.
>
> <https://trac.macports.org/wiki/PortfileRecipes#stealth-updates>
>
> From the viewpoint of package maintainer,
> stealth updates are not a good idea.
> I understand that the changes are for bug fixes or enhancement.
> But if so a new version number (e.g. v2.066.1 or v2.066.0.1)
> or a tag should be given to the commit.
>
> I appreciate if you discussed my suggestion among the developers and
> considered adopting it.
>
> Regards,
>
> Takeshi
>
> -----
> Takeshi Enomoto
> takeshi@macports.org
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

Exactly.

Please use 2.066.x tags for packaging (2.066.0 for original release). "2.066" is a branch were bug-fix commits are aggregates while release is prepared, it has no guarantees of being immutable (and shouldn't).


On Sat, Sep 6, 2014 at 5:37 PM, David Nadlinger via dmd-beta < dmd-beta@puremagic.com> wrote:

> I think I know what is going on now. The source of the problem seems to be a bug in your Portfile, and not an issue on our side.
>
> I'm not familiar with how the GitHub handling works exactly, but
> ---
> github.setup        D-Programming-Language dmd 2.066
> ---
> seems to suggest that it fetches the "2.066" branch. This is not a good idea, because further point releases are also prepared there, as Kenji already mentioned. Instead, please use the actual release tag, e.g. "v2.066.0".
>
> Best,
> David
>
>
> On 6 Sep 2014, at 10:24, Takeshi Enomoto via dmd-beta wrote:
>
>> Dear DMD developers,
>>
>> Thank you for developing DMD.
>> I maintain dmd and related packages of MacPorts.
>>
>> We noticed a few updates to v2.066.0 of dmd, druntime and phobos without changing their tags in the git repository (releases).
>>
>> <https://github.com/D-Programming-Language/dmd/releases>
>>
>> We call such updates `stealth updates'.
>> The checksums are verified to make sure that the correct source code
>> have been downloaded by MacPorts' port command.
>> The checksums are written in the package description file, called
>> Portfile.
>> We need to special treatment for stealth updates.
>>
>> <https://trac.macports.org/wiki/PortfileRecipes#stealth-updates>
>>
>> From the viewpoint of package maintainer,
>> stealth updates are not a good idea.
>> I understand that the changes are for bug fixes or enhancement.
>> But if so a new version number (e.g. v2.066.1 or v2.066.0.1)
>> or a tag should be given to the commit.
>>
>> I appreciate if you discussed my suggestion among the developers and considered adopting it.
>>
>> Regards,
>>
>> Takeshi
>>
>> -----
>> Takeshi Enomoto
>> takeshi@macports.org
>>
> _______________________________________________
> dmd-beta mailing list
> dmd-beta@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-beta
>

Dear all,

Thank you for making me aware of the difference between
the 2.066 branch and the 2.066.0 tag.

I was able to download the 2.066.0 source with the fix that David suggested

github.setup        D-Programming-Language dmd 2.066.0 v

I'll probably switch from the branch to the tag in the next release.

Thank you again for your help.

Takeshi

-----
Takeshi Enomoto
takeshi@macports.org
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

Dear Takeshi,

On 6 Sep 2014, at 23:32, Takeshi Enomoto via dmd-beta wrote:
> I'll probably switch from the branch to the tag in the next release.

I don't know how packaging updates are handled in MacPorts, but it might make sense to perform the change right now, as there might be further changes on the 2.066 branch before 2.066.1 makes it out.

> Thank you again for your help.

Glad to hear that this solves the problems you were having. If you run into any further issues with packaging, please be sure to let us know.

Best,
David

_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

David,

> I don't know how packaging updates are handled in MacPorts, but it might make sense to perform the change right now, as there might be further changes on the 2.066 branch before 2.066.1 makes it out.

The switch reverts from the current 2.066 branch to the 2.066.0 tag. How serious are the fixes?

> If you run into any further issues with packaging, please be sure to let us know.

I'm glad to find the dmd community friendly and helpful.

Regards,

Takeshi
-----
Takeshi Enomoto
takeshi@macports.org


_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta