September 02, 2004
In article <ch7ceo$fn2$1@digitaldaemon.com>, Dave says...
>
>
>By "What is the best way to submit this so it is included in the next build?" I meant the Z_NO_FLUSH change, not the included code as one might expect given the context ;)

Try emailing Walter with the fix.

Sean


September 02, 2004
>>meant the Z_NO_FLUSH change, not the included code as one might expect given the

My 2ยข ....

I would advocate at least some of "the included code" remain for unittest. We have a decent **start** of a rigorous set of test scaffolding for the zlib module. Without implying the slightest criticism of the truly amazing WB, this problem would have been caught during week one (if not day one) of porting zlib from C to D if DBC and unittest was incorporated (unittest may not have been implemented when the port was done?).

From The WB circa 2002-April:
http://www.digitalmars.com/d/archives/4607.html
"Unit testing [along with DBC] has in my mind risen to become a main feature
of D."

Amen. Amen! AMEN!

I would only humbly add that unittest has the potential to significantly subdue that truism which is typically attributed to D. Knuth, "premature optimization is the root of [most | all] software evil."

(may actually be T. Hoare's:
"We should forget about small efficiencies, say about 97% of the time:
premature optimization is the root of all evil." )

Lynn A.


September 04, 2004
"Sean Kelly" <sean@f4.ca> wrote in message news:ch7ikr$ipi$1@digitaldaemon.com...
> In article <ch7ceo$fn2$1@digitaldaemon.com>, Dave says... Try emailing Walter with the fix [for std.zlib.uncompress].

<alert comment="newbie">

Walter,

Did this notification happen? I'm a D newbie and not familiar with the procedure to submit 'candidates' for code fixes to phobos. There was a moderately extensive series of posts related to a possible flaw in std.zlib.uncompress. A probable fix was identified, as well as a number of routines to possibly incorporate as zlib unittests.

"std.zlib.decompress may have flawed logic for allocating buffer"

news:<cgp8gc$2edj$1@digitaldaemon.com news:cgv2k4$2dau$1@digitaldaemon.com

HTH,
Lynn A.

</alert>


September 04, 2004
I'll take care of it..

- Dave

In article <chcq3n$2u7m$1@digitaldaemon.com>, Lynn Allan says...
>
>"Sean Kelly" <sean@f4.ca> wrote in message news:ch7ikr$ipi$1@digitaldaemon.com...
>> In article <ch7ceo$fn2$1@digitaldaemon.com>, Dave says... Try emailing Walter with the fix [for std.zlib.uncompress].
>
><alert comment="newbie">
>
>Walter,
>
>Did this notification happen? I'm a D newbie and not familiar with the procedure to submit 'candidates' for code fixes to phobos. There was a moderately extensive series of posts related to a possible flaw in std.zlib.uncompress. A probable fix was identified, as well as a number of routines to possibly incorporate as zlib unittests.
>
>"std.zlib.decompress may have flawed logic for allocating buffer"
>
>news:<cgp8gc$2edj$1@digitaldaemon.com news:cgv2k4$2dau$1@digitaldaemon.com
>
>HTH,
>Lynn A.
>
></alert>
>
>


1 2
Next ›   Last »