-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The attached patch cleans (pedantic) compiler warnings experienced
during GDC building.

Thomas





-----BEGIN PGP SIGNATURE-----

iD8DBQFBwHWr3w+/yD4P9tIRAs2HAJ9hoerxGQhfHxSdh02ZoOghOS05KACbBDv/
BFMafJkatVvqG9CN8mfXtC0=
=Jl6N
-----END PGP SIGNATURE-----

Thomas Kuehne wrote:

> The attached patch cleans (pedantic) compiler warnings experienced
> during GDC building.

When making the patch files, please make sure
that the paths have the same amount of dirs.
"patch" tends to get confused, otherwise...

http://www.gnu.org/software/diffutils/manual/html_node/Making-Patches.html

For instance, "diff -ur gdc-0.8.orig gdc-0.8"
And patches usually have the ".patch" suffix ?
Just some friendly suggestions, nothing more.

--anders

PS. Patch has problems with the DMD sources
anyway, since they are using DOS line endings.
I used a search and replace on the code first:

find . -type f -name '*.[ch]' | xargs -n 1 -t perl -pe 's/\r\n/\n/s' -i

Then the patch applied just fine, with "patch -p2"

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Anders F Björklund schrieb am Thu, 16 Dec 2004 13:43:59 +0100:
> Thomas Kuehne wrote:
>
>> The attached patch cleans (pedantic) compiler warnings experienced
>> during GDC building.
>
> When making the patch files, please make sure
> that the paths have the same amount of dirs.
> "patch" tends to get confused, otherwise...

Ups, I didn't clean up.

> PS. Patch has problems with the DMD sources
> anyway, since they are using DOS line endings.

May tools will - due to _mixed_ line endings in the GDC sources - freak ou..

Thomas


-----BEGIN PGP SIGNATURE-----

iD8DBQFBwZGH3w+/yD4P9tIRAq5GAKCHv94qbwnn8YI2UFCwjvPT2A936ACePR3Z
RV09MmK68ZFuyNLqWj6JJx0=
=GnWX
-----END PGP SIGNATURE-----

Thomas Kuehne wrote:

>>PS. Patch has problems with the DMD sources
>>anyway, since they are using DOS line endings.
> 
> May tools will - due to _mixed_ line endings in the GDC sources - freak ou..

Indeed. And even in my editor that doesn't freak,
it still looks funny since it treats UNIX line
endings in a DOS text file like extra characters...

DMD can probably remain as DOS/Windows CRLF in the
Digital Mars distribution, but *should* be changed
to UNIX line endings in the GDC distribution. IMHO.

--anders

Anders F Björklund wrote:
> Thomas Kuehne wrote:
> 
>>> PS. Patch has problems with the DMD sources
>>> anyway, since they are using DOS line endings.
>>
>>
>> May tools will - due to _mixed_ line endings in the GDC sources - freak ou..
> 
> 
> Indeed. And even in my editor that doesn't freak,
> it still looks funny since it treats UNIX line
> endings in a DOS text file like extra characters...
> 
> DMD can probably remain as DOS/Windows CRLF in the
> Digital Mars distribution, but *should* be changed
> to UNIX line endings in the GDC distribution. IMHO.
> 
> --anders

It would seem that it's almost better to just change the source to UNIX line endings for both platforms.  You would think that a good Windows editor would know how to read in a UNIX type text file with just a '\n' ending lines.

John Reimer wrote:
> Anders F Björklund wrote:
> 
>> Thomas Kuehne wrote:
>>
>> Indeed. And even in my editor that doesn't freak,
>> it still looks funny since it treats UNIX line
>> endings in a DOS text file like extra characters...
>>
>> DMD can probably remain as DOS/Windows CRLF in the
>> Digital Mars distribution, but *should* be changed
>> to UNIX line endings in the GDC distribution. IMHO.
>>
>> --anders
> 
> 
> It would seem that it's almost better to just change the source to UNIX line endings for both platforms.  You would think that a good Windows editor would know how to read in a UNIX type text file with just a '\n' ending lines.

Ahh.. But I guess I'm forgetting about what the editor will do when it writes the file back.  Grr...

John Reimer wrote:
> John Reimer wrote:
> 
>> Anders F Björklund wrote:
>>
>>> Thomas Kuehne wrote:
>>>
>>> Indeed. And even in my editor that doesn't freak,
>>> it still looks funny since it treats UNIX line
>>> endings in a DOS text file like extra characters...
>>>
>>> DMD can probably remain as DOS/Windows CRLF in the
>>> Digital Mars distribution, but *should* be changed
>>> to UNIX line endings in the GDC distribution. IMHO.
>>>
>>> --anders
>>
>>
>>
>> It would seem that it's almost better to just change the source to UNIX line endings for both platforms.  You would think that a good Windows editor would know how to read in a UNIX type text file with just a '\n' ending lines.
> 
> 
> Ahh.. But I guess I'm forgetting about what the editor will do when it writes the file back.  Grr...

Well, if it does, it isn't a good editor. I only use editors where I can set the write back options (read Vim).

Lars Ivar Igesund

On Thu, 16 Dec 2004 21:58:06 +0100, Lars Ivar Igesund <larsivar@igesund.net> wrote:

> John Reimer wrote:
>> John Reimer wrote:
>>
>>> Anders F Björklund wrote:
>>>
>>>> Thomas Kuehne wrote:
>>>>
>>>> Indeed. And even in my editor that doesn't freak,
>>>> it still looks funny since it treats UNIX line
>>>> endings in a DOS text file like extra characters...
>>>>
>>>> DMD can probably remain as DOS/Windows CRLF in the
>>>> Digital Mars distribution, but *should* be changed
>>>> to UNIX line endings in the GDC distribution. IMHO.
>>>>
>>>> --anders
>>>
>>>
>>>
>>> It would seem that it's almost better to just change the source to UNIX line endings for both platforms.  You would think that a good Windows editor would know how to read in a UNIX type text file with just a '\n' ending lines.
>>   Ahh.. But I guess I'm forgetting about what the editor will do when it writes the file back.  Grr...
>
> Well, if it does, it isn't a good editor. I only use editors where I can set the write back options (read Vim).
>
> Lars Ivar Igesund

If your editor can read \n newlines but not write them, you just found a M$
product.

I currently use Crimson Editor on Windows, it does most of the stuff
I really want in an editor, barring code awareness (a.k.a. Intellisense) and
collapsing (very usefull for incredibly wordy classes) and some random crud like
hex reading data files.

Unfortunately, it's not open, so I can't try to derive
some kind of semi-IDE from it (It's designed to be kind of like KDE's embedded
editor, very lightweight, dumb, but helpfull, so it's unlikely the changes would
be accepted in the main branch, if there were one)

-- 
"Unhappy Microsoft customers have a funny way of becoming Linux,
Salesforce.com and Oracle customers." - www.microsoft-watch.com:
"The Year in Review: Microsoft Opens Up"
--
"I plan on at least one critical patch every month, and I haven't been disappointed."
- Adam Hansen, manager of security at Sonnenschein Nath & Rosenthal LLP
(Quote from http://www.eweek.com/article2/0,1759,1736104,00.asp)
--
"It's been a challenge to "reteach or retrain" Web users to pay for content, said Pizey"
-Wired website: "The Incredible Shrinking Comic"