https://github.com/dlang/DIPs/pull/120

Feedback would be very appreciated.

On Friday, 25 May 2018 at 20:08:23 UTC, 12345swordy wrote:
> https://github.com/dlang/DIPs/pull/120
>
> Feedback would be very appreciated.

I was under the impression that Andrei's ProtoObject was supposed to remedy that:  https://forum.dlang.org/post/pa1lg6$1lud$1@digitalmars.com

Mike

On Friday, 25 May 2018 at 21:01:16 UTC, Mike Franklin wrote:
> On Friday, 25 May 2018 at 20:08:23 UTC, 12345swordy wrote:
>> https://github.com/dlang/DIPs/pull/120
>>
>> Feedback would be very appreciated.
>
> I was under the impression that Andrei's ProtoObject was supposed to remedy that:  https://forum.dlang.org/post/pa1lg6$1lud$1@digitalmars.com
>
> Mike

It's not enough for destructors because they work "both ways".

If we have a universal base class with a @nogc destructor, then no subclass can have a non-@nogc destructor.  In particular, it won't be compatible with today's Object.  But if the universal base class has a destructor that's not @nogc, then classes can't ever be destroyed in @nogc code because destructors need to recurse to base class destructors.

I think we have to either give up on having a sole universal base class, or special-case destructors in the language (or some combination of both).

Just had a thought: attributes are inferred for templates, so maybe the ProtoObject could have a templated empty destructor.  I don't think this would work with the existing destructor implementation, but it least it could be possible.

On Friday, 25 May 2018 at 20:08:23 UTC, 12345swordy wrote:
> https://github.com/dlang/DIPs/pull/120
>
> Feedback would be very appreciated.

From https://github.com/dlang/DIPs/blob/master/PROCEDURE.md#development-stage:

"The DIP Repository is not the place for the initial development of a DIP. The DIP Author(s) should develop the first draft of the DIP in the newly forked repository. A completed first draft is one that, if it were perfect and required no further revision, would be ready to proceed through the entirety of the DIP process.

If community feedback is desired during the Development Stage, the DIP Author(s) should announce in the D Forums that the DIP is in development and ask for feedback, providing a link to the DIP in the forked repository. Any pull request submitted to the DIP Repository before the DIP is in a first draft state will be rejected."

The DIP repository is not the place for draft development, but for draft review. If there are a lot of comments during development, it clutters up the review thread and makes it difficult later to follow the draft review comments.

I'm going to close the PR for now and ask that all feedback either be here or in the forked repository. When the DIP is ready for draft review, then we can open it up again.

And for future reference, anyone intending to submit a DIP, please make sure the draft is ready for review before submitting a PR.

Thanks!

On Saturday, 26 May 2018 at 01:20:44 UTC, Mike Parker wrote:
ments.
>
> I'm going to close the PR for now and ask that all feedback either be here or in the forked repository.

https://github.com/12345swordy/DIPs/blob/master/DIPs/DIP1xxx-attributefriendlydestroy.md

On Saturday, 26 May 2018 at 01:20:44 UTC, Mike Parker wrote:
> On Friday, 25 May 2018 at 20:08:23 UTC, 12345swordy wrote:
>> https://github.com/dlang/DIPs/pull/120
>>
>> Feedback would be very appreciated.
>
> From https://github.com/dlang/DIPs/blob/master/PROCEDURE.md#development-stage:
>
> "The DIP Repository is not the place for the initial development of a DIP. The DIP Author(s) should develop the first draft of the DIP in the newly forked repository. A completed first draft is one that, if it were perfect and required no further revision, would be ready to proceed through the entirety of the DIP process.
>
> If community feedback is desired during the Development Stage, the DIP Author(s) should announce in the D Forums that the DIP is in development and ask for feedback, providing a link to the DIP in the forked repository. Any pull request submitted to the DIP Repository before the DIP is in a first draft state will be rejected."
>
> The DIP repository is not the place for draft development, but for draft review. If there are a lot of comments during development, it clutters up the review thread and makes it difficult later to follow the draft review comments.
>
> I'm going to close the PR for now and ask that all feedback either be here or in the forked repository. When the DIP is ready for draft review, then we can open it up again.
>
> And for future reference, anyone intending to submit a DIP, please make sure the draft is ready for review before submitting a PR.
>
> Thanks!

k

Though I had posted a thread regarding my DIP and no one seems to care.


Alex

On Saturday, 26 May 2018 at 02:25:30 UTC, 12345swordy wrote:
>
> k
>
> Though I had posted a thread regarding my DIP and no one seems to care.
>
>
> Alex


When someone has an idea, that you don't care about, you tell them to go write a DIP.

Apparently, that is the more acceptable 'etiquette', rather than telling them to FO.

On Sunday, 27 May 2018 at 09:04:20 UTC, Go-Write-A-DIP wrote:
> On Saturday, 26 May 2018 at 02:25:30 UTC, 12345swordy wrote:
>>
>> k
>>
>> Though I had posted a thread regarding my DIP and no one seems to care.
>>
>>
>> Alex
>
>
> When someone has an idea, that you don't care about, you tell them to go write a DIP.
>
> Apparently, that is the more acceptable 'etiquette', rather than telling them to FO.

Is this another alt account of yours? If you not going to discuss my DIP then go away.