https://issues.dlang.org/show_bug.cgi?id=19902

Jonathan M Davis <issues.dlang@jmdavisProg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |issues.dlang@jmdavisProg.co
                   |                            |m

--- Comment #1 from Jonathan M Davis <issues.dlang@jmdavisProg.com> ---
Indeed. Without it being updated, any existing code that's testing for whether it's okay to blit a type is broken when dealing with structs that have copy constructors (e.g. I expect that std.algorithm's swap is currently broken in such a fashion). I don't know if there's code that would break because it's really assuming postblit constructors from hasElaborateCopyConstructor rather than the inability to blit, but I expect that more code will be broken without updating the trait than with requiring a new one. Also, there's already been at least one post in D.Learn where someone was confused, because hasElaborateCopyConstructor wasn't true for types with copy constructors.

--

https://issues.dlang.org/show_bug.cgi?id=19902

--- Comment #2 from Manu <turkeyman@gmail.com> ---
This is a very critical issue.

--

https://issues.dlang.org/show_bug.cgi?id=19902

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
@edi33416 created dlang/druntime pull request #2709 "Fix Issue 19902 - hasElaborateCopyConstructor doesn't know about copy…" fixing this issue:

- Fix Issue 19902 - hasElaborateCopyConstructor doesn't know about copy constructors

https://github.com/dlang/druntime/pull/2709

--

https://issues.dlang.org/show_bug.cgi?id=19902

Eduard Staniloiu <edi33416@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |edi33416@gmail.com
          Component|phobos                      |druntime

--

https://issues.dlang.org/show_bug.cgi?id=19902

Eduard Staniloiu <edi33416@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@puremagic.com        |edi33416@gmail.com

--

https://issues.dlang.org/show_bug.cgi?id=19902

Paul Backus <snarwin+bugzilla@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |snarwin+bugzilla@gmail.com

--

https://issues.dlang.org/show_bug.cgi?id=19902

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
@pbackus created dlang/druntime pull request #2911 "Fix issue 19902 - hasElaborateCopyConstructor doesn't know about copy…" fixing this issue:

- Fix issue 19902 - hasElaborateCopyConstructor doesn't know about copy constructors

https://github.com/dlang/druntime/pull/2911

--

https://issues.dlang.org/show_bug.cgi?id=19902

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/druntime pull request #2911 "Fix issue 19902 - hasElaborateCopyConstructor doesn't know about copy…" was merged into stable:

- 0c3fd57891f7ee6fa65b57bc2011f301017399e4 by Paul Backus:
  Fix issue 19902 - hasElaborateCopyConstructor doesn't know about copy
constructors

https://github.com/dlang/druntime/pull/2911

--