https://issues.dlang.org/show_bug.cgi?id=21944

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |importC
                 CC|                            |ibuclaw@gdcproject.org

--

https://issues.dlang.org/show_bug.cgi?id=21944

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rejects-valid

--

https://issues.dlang.org/show_bug.cgi?id=21944

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #1 from Dlang Bot <dlang-bot@dlang.rocks> ---
@ibuclaw created dlang/dmd pull request #12585 "fix Issue 21944 - importC: Add `-P` to C preprocessor invocation example" fixing this issue:

- fix Issue 21944 - importC: Add `-P` to C preprocessor invocation example

  The recommendation for using a preprocessor does not generate compilable
  code due to the `#line` directive not being supported by importC.

https://github.com/dlang/dmd/pull/12585

--

https://issues.dlang.org/show_bug.cgi?id=21944

--- Comment #2 from Iain Buclaw <ibuclaw@gdcproject.org> ---
Patch sent that recommends users to use `-P` to turn off the generation of linemarkers in the output from the preprocessor.  This saves us having to support the extension.

--

https://issues.dlang.org/show_bug.cgi?id=21944

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Iain Buclaw <ibuclaw@gdcproject.org> ---
Fix committed as https://github.com/dlang/dmd/commit/ba38f4bda14b3c92d5ef64d5221366ee7c78d944

--

https://issues.dlang.org/show_bug.cgi?id=21944

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |bugzilla@digitalmars.com
         Resolution|FIXED                       |---

--- Comment #4 from Walter Bright <bugzilla@digitalmars.com> ---
Not implementing this would be a nuisance, and there'd be no way to get the line numbers correct for debugging.

--

https://issues.dlang.org/show_bug.cgi?id=21944

--- Comment #5 from Walter Bright <bugzilla@digitalmars.com> ---
The Digital Mars preprocessor, as well as the Warp preprocessor, emit linemarker directives.

--

https://issues.dlang.org/show_bug.cgi?id=21944

--- Comment #6 from Dlang Bot <dlang-bot@dlang.rocks> ---
@WalterBright created dlang/dmd pull request #12637 "fix Issue 21944 - ImportC: Support parsing # line marker directive ex…" fixing this issue:

- fix Issue 21944 - importC: Support parsing # line marker directive extensions

https://github.com/dlang/dmd/pull/12637

--

https://issues.dlang.org/show_bug.cgi?id=21944

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #12637 "fix Issue 21944 - ImportC: Support parsing # line marker directive ex…" was merged into master:

- 4423156fdd66cdd5bbc4233bd85add1b8ea68d78 by Walter Bright:
  fix Issue 21944 - importC: Support parsing # line marker directive extensions

https://github.com/dlang/dmd/pull/12637

--