[Issue 22532] std.experimental.logger Change default log level to LogLevel.warning, or LogLevel.off

Nov 21, 2021

Robert Schadek

Nov 21, 2021

Robert Schadek

Nov 22, 2021

Nov 22, 2021

Nov 22, 2021

Dec 14, 2021

Jan 07, 2022

https://issues.dlang.org/show_bug.cgi?id=22532 Robert Schadek <robertschadek@posteo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18857 Referenced Issues: https://issues.dlang.org/show_bug.cgi?id=18857 [Issue 18857] [std.experimental.logger] use NullLogger as the default --

https://issues.dlang.org/show_bug.cgi?id=22532 Robert Schadek <robertschadek@posteo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robertschadek@posteo.de --- Comment #1 from Robert Schadek <robertschadek@posteo.de> --- My opinion is the complete opposite. By default no log message should be stopped from being logged. When you log for the first time and your message does not appear, you will think it is broken. When you reach a level where too many log messages is your problem you will know how to change it. --

https://issues.dlang.org/show_bug.cgi?id=22532 --- Comment #2 from Steven Schveighoffer <schveiguy@gmail.com> --- When you don't log anything, and pages of low-level data is spewed to the screen, I think you will more likely think that the library is broken. There is no reasonable link between "I included some dub library" and "you have to set the log level to avoid insane amounts of output". On the other hand, if you are trying to use the logging facilities, you are already looking at the documentation, and already willing to follow instructions. If you try logging something and it doesn't work, you go back to the already-open doc window, and read about why it didn't work. The fact remains, no library will use logger because of the default verbosity, including mysql-native. --

November 22, 2021

[Issue 22532] std.experimental.logger Change default log level to LogLevel.warning, or LogLevel.off

Posted by Robert Schadek

Permalink

Robert Schadek

Permalink

https://issues.dlang.org/show_bug.cgi?id=22532

--- Comment #3 from Robert Schadek <robertschadek@posteo.de> ---
> The fact remains, no library will use logger because of the default verbosity, including mysql-native.

I do not consider that to be a fact, but an opinion, at best a
proof-by-one-example.
mysql-native of course being a developed by you.

> When you don't log anything, and pages of low-level data is spewed to the screen, I think you will more likely think that the library is broken.


I totally disagree, when I include a logging library and it does show me anything, it is totally broken.

> On the other hand, if you are trying to use the logging facilities, you are already looking at the documentation, and already willing to follow instructions. If you try logging something and it doesn't work, you go back to the already-open doc window, and read about why it didn't work.

This argument can be made for the opposite as well.



IMO we two can not resolve this discussion, clearly you think you are right and clearly I think I'm right.

If there is ever a push for stuff out of std.experimental to be moved into std, the default loglevel should be decided by whoever is in charge of phobos at the time.

--

https://issues.dlang.org/show_bug.cgi?id=22532 Dlang Bot <dlang-bot@dlang.rocks> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |pull --- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> --- @atilaneves created dlang/phobos pull request #8336 "Fix issue 22532 - change default log level to LogLevel.warning" fixing this issue: - Fix issue 22532 - change default log level to LogLevel.warning https://github.com/dlang/phobos/pull/8336 --

https://issues.dlang.org/show_bug.cgi?id=22532 Dlang Bot <dlang-bot@dlang.rocks> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Dlang Bot <dlang-bot@dlang.rocks> --- dlang/phobos pull request #8336 "Fix issue 22532 - change default log level to LogLevel.warning" was merged into master: - 38a8bcbc04e9718b1012762e9317be1d4071984f by Atila Neves: Fix issue 22532 - change default log level to LogLevel.warning https://github.com/dlang/phobos/pull/8336 --

Forums