https://issues.dlang.org/show_bug.cgi?id=17289

Zach the Mystic <reachzach@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
           Severity|critical                    |regression

--- Comment #10 from Zach the Mystic <reachzach@gmail.com> ---
I guess I'll reopen this issue to make the point, now that I have an ally. Again, I believe this is in effect a horrible regression, and the fix should be patched to the main website ASAP.

--

https://issues.dlang.org/show_bug.cgi?id=17289

Steven Schveighoffer <schveiguy@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Steven Schveighoffer <schveiguy@yahoo.com> ---
Please, don't reopen bugs based on whether the fix is in a released compiler.

I agree the warnings are jarring and bad, and this should go into 2.074.1. But the fix is already merged, and that's what the bug tracker should track. If you want to make a difference here, create a PR to cherry pick the fix into the stable branch so it's included when 2.074.1 beta process commences.

--

https://issues.dlang.org/show_bug.cgi?id=17289

Vladimir Panteleev <thecybershadow@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thecybershadow@gmail.com

--- Comment #12 from Vladimir Panteleev <thecybershadow@gmail.com> ---
(In reply to Zach the Mystic from comment #8)
> I believe this counts as a regression and should be patched to the main website ASAP.

Since the breaking change was in Xcode, it would be a regression in Xcode as well, no? I'm not sure about the idea of D being required to treat regressions in others' software with urgency.

--

https://issues.dlang.org/show_bug.cgi?id=17289

--- Comment #13 from Zach the Mystic <reachzach@gmail.com> ---
(In reply to Vladimir Panteleev from comment #12)
> Since the breaking change was in Xcode, it would be a regression in Xcode as well, no? I'm not sure about the idea of D being required to treat regressions in others' software with urgency.

If you're running a business, you wouldn't tell your customers, "Our supplier crashed their truck, so we're not required to serve you." A good business focuses on the customer. Maybe someone should bring this up with Apple and Xcode, true. But Walter was able to fix it with a three line change to dmd, and it's D users who are hurting.

--

https://issues.dlang.org/show_bug.cgi?id=17289

--- Comment #14 from Zach the Mystic <reachzach@gmail.com> ---
(In reply to Steven Schveighoffer from comment #11)
> Please, don't reopen bugs based on whether the fix is in a released compiler.
> 
> I agree the warnings are jarring and bad, and this should go into 2.074.1. But the fix is already merged, and that's what the bug tracker should track. If you want to make a difference here, create a PR to cherry pick the fix into the stable branch so it's included when 2.074.1 beta process commences.

Okay, makes sense. Cherry picking pull: https://github.com/dlang/dmd/pull/6789

--

https://issues.dlang.org/show_bug.cgi?id=17289

Vladimir Panteleev <thecybershadow@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|regression                  |major

--- Comment #15 from Vladimir Panteleev <thecybershadow@gmail.com> ---
(In reply to Zach the Mystic from comment #13)
> If you're running a business, you wouldn't tell your customers, "Our supplier crashed their truck, so we're not required to serve you."

Bad analogy. It is your choice to use Apple products, your choice to update Xcode, and your choice to (instead of using a workaround) attempt to escalate the issue, here, on D's bugtracker, even though the breaking change was in Xcode, not D.

> A good business focuses on the customer.

Well... would you like a refund? Luckily for us, D is not a business, it's an open-source project.

> and it's D users who are hurting.

1. Only Apple users.
2. "Hurting"? Isn't it just warnings?

> and the fix should be patched to the main website ASAP.

We are not going to make an exception for our release process for a LINKER WARNING.

All in all, I definitely don't see any reason to treat this issue with the urgency you demand, and I don't think the tone of your communication is of any help to anyone.

There are multiple workarounds available at your disposal:

- Build D from git
- Use a nightly version of D (https://nightlies.dlang.org/dmd-nightly/)
- Filter out the linker warnings locally
- Downgrade Xcode
- Use a different operating system

Considering the fix was already merged, please make use of one of the workarounds above and stop exaggerating the problem.

--

https://issues.dlang.org/show_bug.cgi?id=17289

--- Comment #16 from Zach the Mystic <reachzach@gmail.com> ---
(In reply to Vladimir Panteleev from comment #15)
> (In reply to Zach the Mystic from comment #13)
> > If you're running a business, you wouldn't tell your customers, "Our supplier crashed their truck, so we're not required to serve you."
> 
> Bad analogy. It is your choice to use Apple products, your choice to update Xcode, and your choice to (instead of using a workaround) attempt to escalate the issue, here, on D's bugtracker, even though the breaking change was in Xcode, not D.
> 
> > A good business focuses on the customer.
> 
> Well... would you like a refund? Luckily for us, D is not a business, it's an open-source project.
> 
> > and it's D users who are hurting.
> 
> 1. Only Apple users.
> 2. "Hurting"? Isn't it just warnings?

It's thousands of pages of warnings for one compile, using the out-of-the-box experience of how to download and try D, as described on the main website. If you get dub and type 'dub run dscanner', for example, thousands of pages of warnings. Also, it never finished building for me and I had to press Ctrl-C on the terminal. I'm focusing on the new user who decides to try D one day. Whose only sin, apparently, is that he bought a mac. Or that he chose to use D, for some reason.

> > and the fix should be patched to the main website ASAP.
> 
> We are not going to make an exception for our release process for a LINKER WARNING.

What's wrong with Steven Schveighoffer's suggestion about including it in the next release for the stable branch? That seemed like a good compromise.

I do think your focus is wrong, and that you should consider thinking of D as a product that you can help to deliver to customers, whether they pay for it or not. Something that you can be proud to be associated with. But that's a philosophical issue, and a hard one, and a long conversation.

--

https://issues.dlang.org/show_bug.cgi?id=17289

--- Comment #17 from Vladimir Panteleev <thecybershadow@gmail.com> ---
(In reply to Zach the Mystic from comment #16)
> It's thousands of pages of warnings for one compile, using the out-of-the-box experience of how to download and try D, as described on the main website. If you get dub and type 'dub run dscanner', for example, thousands of pages of warnings. Also, it never finished building for me and I had to press Ctrl-C on the terminal. I'm focusing on the new user who decides to try D one day. Whose only sin, apparently, is that he bought a mac. Or that he chose to use D, for some reason.

Fair enough.

> What's wrong with Steven Schveighoffer's suggestion about including it in the next release for the stable branch? That seemed like a good compromise.

I think that's completely fine. However, we don't know when the next release
(major or minor) will occur, and Martin (our current release manager) hasn't
been seen online the past few days.

--

https://issues.dlang.org/show_bug.cgi?id=17289

--- Comment #18 from Steven Schveighoffer <schveiguy@yahoo.com> ---
(In reply to Vladimir Panteleev from comment #15)
> (In reply to Zach the Mystic from comment #13)
> > If you're running a business, you wouldn't tell your customers, "Our supplier crashed their truck, so we're not required to serve you."
> 
> Bad analogy. It is your choice to use Apple products, your choice to update Xcode, and your choice to (instead of using a workaround) attempt to escalate the issue, here, on D's bugtracker, even though the breaking change was in Xcode, not D.

AFAIK, this is not a regression in Xcode, but a new warning for a bad situation that was previously unreported.

The code still builds, but the pointers that dmd generates in the object files were misaligned.

It is a regression of DMD, because older versions of DMD did not generate misaligned data.

I think we can fix in the stable branch, and move on here.

--

https://issues.dlang.org/show_bug.cgi?id=17289

--- Comment #19 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/9adb8d6356aac83c2614b668e1022ef31f12f972 fix Issue 17289 - With Xcode 8.3 linker, warnings of 'pointer not aligned'

https://github.com/dlang/dmd/commit/b2a782260579c44e581ad0575d0fd5c4674c7e4e Merge pull request #6789 from zachthemystic/cherrypick-PR6721-issue17289-to-stable

move fix Issue 17289 - With Xcode 8.3 linker... to stable

--