Thread overview | |||||||
---|---|---|---|---|---|---|---|
|
July 30, 2013 Re: Proposal for pull request review process | ||||
---|---|---|---|---|
| ||||
On 07/28/2013 10:41 PM, Joseph Rushton Wakeling wrote:
> I originally posted this idea in the course of a thread in D.announce but thought I'd put it here so that more people can pitch in.
OK, maybe it was just uninteresting or incomprehensible. :-P
Short version: I think it would help speed up the review queue to have an auto-merge facility that would automatically merge in approved pull requests once they pass the test suite.
|
July 30, 2013 Re: Proposal for pull request review process | ||||
---|---|---|---|---|
| ||||
Posted in reply to Joseph Rushton Wakeling | On Tuesday, 30 July 2013 at 08:46:23 UTC, Joseph Rushton Wakeling wrote:
> On 07/28/2013 10:41 PM, Joseph Rushton Wakeling wrote:
>> I originally posted this idea in the course of a thread in D.announce but
>> thought I'd put it here so that more people can pitch in.
>
> OK, maybe it was just uninteresting or incomprehensible. :-P
>
> Short version: I think it would help speed up the review queue to have an
> auto-merge facility that would automatically merge in approved pull requests
> once they pass the test suite.
Well, I think simply no one finds it worth discussing until there is actual implementation for such facility proposed ;)
|
July 30, 2013 Re: Proposal for pull request review process | ||||
---|---|---|---|---|
| ||||
Posted in reply to Dicebot | 30-Jul-2013 12:59, Dicebot пишет: > On Tuesday, 30 July 2013 at 08:46:23 UTC, Joseph Rushton Wakeling wrote: >> On 07/28/2013 10:41 PM, Joseph Rushton Wakeling wrote: >>> I originally posted this idea in the course of a thread in D.announce >>> but >>> thought I'd put it here so that more people can pitch in. >> >> OK, maybe it was just uninteresting or incomprehensible. :-P >> >> Short version: I think it would help speed up the review queue to have an >> auto-merge facility that would automatically merge in approved pull >> requests >> once they pass the test suite. Good idea. Otherwise somehow tagging pulls to denote their current state would be priceless. > > Well, I think simply no one finds it worth discussing until there is > actual implementation for such facility proposed ;) -- Dmitry Olshansky |
July 30, 2013 Re: Proposal for pull request review process | ||||
---|---|---|---|---|
| ||||
Posted in reply to Dicebot | On 07/30/2013 10:59 AM, Dicebot wrote:
> Well, I think simply no one finds it worth discussing until there is actual implementation for such facility proposed ;)
Fair enough, code speaks. :-) It's just that no one seems to have pointed out this part of the problem before.
I always feel it's worth raising an idea even if there's not the time to work on it personally, because someone else might like it and want to run with it.
|
July 30, 2013 Re: Proposal for pull request review process | ||||
---|---|---|---|---|
| ||||
Posted in reply to Dmitry Olshansky | On 07/30/2013 11:09 AM, Dmitry Olshansky wrote:
>>> Short version: I think it would help speed up the review queue to have an
>>> auto-merge facility that would automatically merge in approved pull
>>> requests
>>> once they pass the test suite.
>
> Good idea. Otherwise somehow tagging pulls to denote their current state would be priceless.
I remember that the bzr VCS devs had set up some kind of system where people
with review/commit privileges would comment on patchsets with +1, +0 or -1 and
there was an automated system keeping track of the votes. There was some kind
of threshold that was needed for merge approval, although I forget the details.
I can look into it if people are interested.
(Russell Winder might know. I remember him being another person active on the bzr mailing lists back in the day...:-)
|
Copyright © 1999-2021 by the D Language Foundation