Thread overview
[Issue 20950] std.conv.text(int) shouldn't needlessly allocate
[Issue 20950] std.conv.text shouldn't needlessly allocate
Jun 18, 2020
Stanislav Blinov
Jun 19, 2020
Stanislav Blinov
Dec 17, 2022
Iain Buclaw
June 18, 2020
https://issues.dlang.org/show_bug.cgi?id=20950

Steven Schveighoffer <schveiguy@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |schveiguy@yahoo.com

--- Comment #1 from Steven Schveighoffer <schveiguy@yahoo.com> ---
Yes, agree. And also, the code is all in there -- the code that writes the converted int to a static array buffer can be factored out of toImpl, and used to avoid an extra allocation.

--
June 18, 2020
https://issues.dlang.org/show_bug.cgi?id=20950

Steven Schveighoffer <schveiguy@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|std.conv.text shouldn't     |std.conv.text(int)
                   |needlessly allocate         |shouldn't needlessly
                   |                            |allocate

--
June 18, 2020
https://issues.dlang.org/show_bug.cgi?id=20950

--- Comment #2 from Stanislav Blinov <stanislav.blinov@gmail.com> ---
Why just int?

--
June 18, 2020
https://issues.dlang.org/show_bug.cgi?id=20950

--- Comment #3 from Steven Schveighoffer <schveiguy@yahoo.com> ---
That is the current case. I agree it shouldn't needlessly allocate if it can help it. But then the "fix" needs to be defined as to how much allocation is needed.

Int is straightforward -- the code is already in std.conv that can convert an int to text without allocation. The general case is not as straightforward.

--
June 19, 2020
https://issues.dlang.org/show_bug.cgi?id=20950

--- Comment #4 from Stanislav Blinov <stanislav.blinov@gmail.com> ---
https://issues.dlang.org/show_bug.cgi?id=17712

--
June 19, 2020
https://issues.dlang.org/show_bug.cgi?id=20950

Steven Schveighoffer <schveiguy@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://issues.dlang.org/sh
                   |                            |ow_bug.cgi?id=17712

--
December 17, 2022
https://issues.dlang.org/show_bug.cgi?id=20950

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P4

--