https://issues.dlang.org/show_bug.cgi?id=18024

Seb <greensunny12@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Linux                       |All

--

https://issues.dlang.org/show_bug.cgi?id=18024

Jack Stouffer <jack@jackstouffer.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jack@jackstouffer.com

--- Comment #1 from Jack Stouffer <jack@jackstouffer.com> ---
Isn't this just a matter of using a custom hook? Or are you saying the default behavior should be different?

--

https://issues.dlang.org/show_bug.cgi?id=18024

--- Comment #2 from Seb <greensunny12@gmail.com> ---
> Isn't this just a matter of using a custom hook? Or are you saying the default behavior should be different?

Well, the default hook Abort just SEGFAULTs / assert(0)s will fullfils all the
attributes given.

--

https://issues.dlang.org/show_bug.cgi?id=18024

--- Comment #3 from Jack Stouffer <jack@jackstouffer.com> ---
(In reply to Seb from comment #2)
> > Isn't this just a matter of using a custom hook? Or are you saying the default behavior should be different?
> 
> Well, the default hook Abort just SEGFAULTs / assert(0)s will fullfils all
> the attributes given.

Don't forget it also prints to stderr, which is why it's @system impure gc and throws

--

https://issues.dlang.org/show_bug.cgi?id=18024

Seb <greensunny12@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|checkedint should be usable |checkedint.Warn should be
                   |in @safe nothrow pure @nogc |@safe

--

https://issues.dlang.org/show_bug.cgi?id=18024

--- Comment #4 from Jack Stouffer <jack@jackstouffer.com> ---
The problem with trying to make Warn @safe is File is still unsafe and will be for the foreseeable future.

IMO, Abort should be modified to not use Warn, and a new Hook called debug should give the same behavior as Abort has now. That way, by default checked is @nogc @safe nothrow pure

--

https://issues.dlang.org/show_bug.cgi?id=18024

--- Comment #5 from Seb <greensunny12@gmail.com> ---
> Don't forget it also prints to stderr, which is why it's @system impure gc and throws

Yeah I did forget about this when I opened the issue (didn't had time to dive
into this then).
Anyhow it `Warn` can easily be made @safe:

PR https://github.com/dlang/phobos/pull/5928

--

https://issues.dlang.org/show_bug.cgi?id=18024

--- Comment #6 from Seb <greensunny12@gmail.com> ---
> The problem with trying to make Warn @safe is File is still unsafe and will be for the foreseeable future.

Well, but we can use the same "trick" / "workaround" as used for stdout?

> IMO, Abort should be modified to not use Warn, and a new Hook called debug should
give the same behavior as Abort has now. That way, by default checked is @nogc @safe nothrow pure

That sounds very reasonable!

--

https://issues.dlang.org/show_bug.cgi?id=18024

Seb <greensunny12@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18110


Referenced Issues:

https://issues.dlang.org/show_bug.cgi?id=18110
[Issue 18110] most of phobos should be @safe-ly useable
--

https://issues.dlang.org/show_bug.cgi?id=18024

Seb <greensunny12@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|checkedint.Warn should be   |checkedint.Abort should be
                   |@safe                       |@safe

--