https://issues.dlang.org/show_bug.cgi?id=13445

Vladimir Panteleev <thecybershadow@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #1 from Vladimir Panteleev <thecybershadow@gmail.com> ---
https://github.com/D-Programming-Language/phobos/pull/2502

--

https://issues.dlang.org/show_bug.cgi?id=13445

Ketmar Dark <ketmar@ketmar.no-ip.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ketmar@ketmar.no-ip.org

--- Comment #2 from Ketmar Dark <ketmar@ketmar.no-ip.org> ---
Created attachment 1421
  --> https://issues.dlang.org/attachment.cgi?id=1421&action=edit
fix

heh. there is another bug with workDir: workDirFD CAN be zero, it's perfectly valid FD. ;-)

fix attached.

--

https://issues.dlang.org/show_bug.cgi?id=13445

--- Comment #3 from Vladimir Panteleev <thecybershadow@gmail.com> ---
Care to turn that into a pull request, or can I add that as a commit for you?

--

https://issues.dlang.org/show_bug.cgi?id=13445

--- Comment #4 from Ketmar Dark <ketmar@ketmar.no-ip.org> ---
just merge this with yours: i missed windows fix anyway.

--

https://issues.dlang.org/show_bug.cgi?id=13445

--- Comment #5 from Vladimir Panteleev <thecybershadow@gmail.com> ---
OK, I added your patch to my pull as a separate commit, and credited you as the commit author:

https://github.com/CyberShadow/phobos/commit/462163a5b0b29d112558d4b2d612bdfc9b183208

--

https://issues.dlang.org/show_bug.cgi?id=13445

--- Comment #6 from Ketmar Dark <ketmar@ketmar.no-ip.org> ---
thank you. i don't care about credits, though: it's ok to use my patches fully or partially without crediting me.

--

https://issues.dlang.org/show_bug.cgi?id=13445

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--

https://issues.dlang.org/show_bug.cgi?id=13445

--- Comment #7 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/53f5405a516755f12f762882abd38fac6b60ad95
fix Issue 13445 - std.process fails to create process with empty (non-null)
working directory

https://github.com/D-Programming-Language/phobos/commit/d479da3392e9d8b8194c5b6078bcadc4ea4e889d Merge pull request #2502 from CyberShadow/pull-20140909-140509

fix Issue 13445 - std.process fails to create process with empty (non-null)
working directory

--