Thread overview
How to deal with interdependent dlang PRs?
May 25, 2023
Quirin Schroll
May 25, 2023
Dennis
May 26, 2023
Quirin Schroll
May 25, 2023

I have 2 PRs, one on dlang/dlang.org and one on dlang/dmd. The latter fails a test because an example on the (current) dlang.org fails. The dlang.org PR changes the example, and fails likewise it’s based on the changes in the dmd PR.

One measure I could think of:

  1. Create a new dlang.org PR that (temporarily) removes the offending example; that one should not fail tests.
  2. When it has been merged, the dmd PR will not fail anymore and can be merged.
  3. The original dlang.org PR "reintroduces" the example with appropriate changes. It won’t fail because the compiler has been changed.

This seems a little convoluted. Is there a process? I can’t be the first one running into this.

May 25, 2023

On Thursday, 25 May 2023 at 15:37:00 UTC, Quirin Schroll wrote:

>

Is there a process? I can’t be the first one running into this.

Doing it in 3 PRs is the process. This is one of the reasons why druntime was merged into dmd's repository. I remember someone saying that if you name the git branches the same, the CI checks out the PR's corresponding branch in other repositories, but I have no experience doing this so I'm not sure it will work.

May 26, 2023

On Thursday, 25 May 2023 at 20:18:08 UTC, Dennis wrote:

>

On Thursday, 25 May 2023 at 15:37:00 UTC, Quirin Schroll wrote:

>

Is there a process? I can’t be the first one running into this.

Doing it in 3 PRs is the process.

Okay. It’s not that bad.

>

This is one of the reasons why druntime was merged into dmd's repository. I remember someone saying that if you name the git branches the same, the CI checks out the PR's corresponding branch in other repositories, but I have no experience doing this so I'm not sure it will work.

I’ll try that. I wonder what happens when I rename the branches on my fork, but renaming branches isn’t that uncommon, I guess.