Thread overview | ||||||||
---|---|---|---|---|---|---|---|---|
|
October 09, 2019 druntime repo | ||||
---|---|---|---|---|
| ||||
I'm not sure if this is the right place to discuss this. Can someone look at the druntime repo on GitHub please? https://github.com/dlang/druntime/pulls?utf8=%E2%9C%93&q=is%3Apr https://i.imgur.com/C3gCeWl.png PR 2821 broke something and that's failing the tests of the other PRs and blocking them from merge. |
October 10, 2019 Re: druntime repo | ||||
---|---|---|---|---|
| ||||
Posted in reply to Arun Chandrasekaran | On Wed, Oct 09, 2019 at 11:36:41PM +0000, Arun Chandrasekaran via Digitalmars-d wrote: > I'm not sure if this is the right place to discuss this. > > Can someone look at the druntime repo on GitHub please? > > https://github.com/dlang/druntime/pulls?utf8=%E2%9C%93&q=is%3Apr > > https://i.imgur.com/C3gCeWl.png > > PR 2821 broke something and that's failing the tests of the other PRs and blocking them from merge. PR 2821 is being reverted because it introduced several issues that somehow slipped past the CI testsuite and got merged in spite of causing some tests to fail. It should be sorted out soon, hopefully. T -- Lottery: tax on the stupid. -- Slashdotter |
October 10, 2019 Re: druntime repo | ||||
---|---|---|---|---|
| ||||
Posted in reply to H. S. Teoh | On Thursday, 10 October 2019 at 16:35:55 UTC, H. S. Teoh wrote:
> On Wed, Oct 09, 2019 at 11:36:41PM +0000, Arun Chandrasekaran via Digitalmars-d wrote:
>> I'm not sure if this is the right place to discuss this.
>>
>> Can someone look at the druntime repo on GitHub please?
>>
>> https://github.com/dlang/druntime/pulls?utf8=%E2%9C%93&q=is%3Apr
>>
>> https://i.imgur.com/C3gCeWl.png
>>
>> PR 2821 broke something and that's failing the tests of the other PRs and blocking them from merge.
>
> PR 2821 is being reverted because it introduced several issues that somehow slipped past the CI testsuite and got merged in spite of causing some tests to fail. It should be sorted out soon, hopefully.
>
>
> T
Right, but I don't see that discussion happening. As I can see there are three different PRs to revert it. Just duplication of effort.
|
October 10, 2019 Re: druntime repo | ||||
---|---|---|---|---|
| ||||
Posted in reply to Arun Chandrasekaran | On Thu, Oct 10, 2019 at 6:45 PM Arun Chandrasekaran via Digitalmars-d <digitalmars-d@puremagic.com> wrote: > > Right, but I don't see that discussion happening. As I can see there are three different PRs to revert it. Just duplication of effort. https://github.com/dlang/dmd/pull/10463 |
October 10, 2019 Re: druntime repo | ||||
---|---|---|---|---|
| ||||
Posted in reply to Daniel Kozak | On Thursday, 10 October 2019 at 17:51:33 UTC, Daniel Kozak wrote:
> On Thu, Oct 10, 2019 at 6:45 PM Arun Chandrasekaran via Digitalmars-d <digitalmars-d@puremagic.com> wrote:
>>
>> Right, but I don't see that discussion happening. As I can see there are three different PRs to revert it. Just duplication of effort.
>
> https://github.com/dlang/dmd/pull/10463
Thanks. Good to see that it's been worked on. How do you guys coordinate to avoid effort duplication. No pings on slack/discord/forum emails. Is there a different channel where these are discussed?
|
October 12, 2019 Re: druntime repo | ||||
---|---|---|---|---|
| ||||
Posted in reply to Arun Chandrasekaran | On Thursday, 10 October 2019 at 18:04:46 UTC, Arun Chandrasekaran wrote: > [..] How do you guys coordinate to avoid effort duplication. No pings on slack/discord/forum emails. Is there a different channel where these are discussed? Slack and comments on GitHub are the most common ways of communication for the dlang repos, but sometimes contributors are busy with other stuff and don't check the usual communication channels. Perhaps the most direct way to communicate is to post on the #dmd/#druntime/#phobos/#dub/etc. channels on Slack and if it's urgent matter, directly messaging people could also be a good option. |
Copyright © 1999-2021 by the D Language Foundation