On Tuesday 04 January 2011 08:20:07 Andrei Alexandrescu wrote:
> On 1/4/11 9:35 AM, Steve Schveighoffer wrote:
> > I prefer no full bracing, and braces on their own line.
> 
> I think that's about the dominant style in Phobos now (braces on their own line and quite lax bracing for single statements).

If that's the dominant style, does it really make sense to change it? If nothing else, that would seem to indicate that that's the style that most of the Phobos developers prefer (including you, since you've written a lot of the code).

Regardless, if we want to try and have a common style throughout Phobos, we're going to need an actual style guide rather than just tacit agreement on the list. Otherwise, it's just going to be forgotten. It's easy enough to forget to use an agreed upon style when you have a style guide to look at, let alone when you've just sort of agreed on what the style is supposed to be.

- Jonathan M Davis

I took over Walter's style. By and large we're all professionals and we can adapt to most styles. A formal document could help but the current style if self-explanatory.

Andrei

On 1/7/11 2:08 AM, Jonathan M Davis wrote:
> On Tuesday 04 January 2011 08:20:07 Andrei Alexandrescu wrote:
>> On 1/4/11 9:35 AM, Steve Schveighoffer wrote:
>>> I prefer no full bracing, and braces on their own line.
>>
>> I think that's about the dominant style in Phobos now (braces on their own line and quite lax bracing for single statements).
>
> If that's the dominant style, does it really make sense to change it? If nothing else, that would seem to indicate that that's the style that most of the Phobos developers prefer (including you, since you've written a lot of the code).
>
> Regardless, if we want to try and have a common style throughout Phobos, we're going to need an actual style guide rather than just tacit agreement on the list. Otherwise, it's just going to be forgotten. It's easy enough to forget to use an agreed upon style when you have a style guide to look at, let alone when you've just sort of agreed on what the style is supposed to be.
>
> - Jonathan M Davis
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos

On Friday, January 07, 2011 07:14:08 Andrei Alexandrescu wrote:
> I took over Walter's style. By and large we're all professionals and we can adapt to most styles. A formal document could help but the current style if self-explanatory.

I just want it to be clear. If it's okay for me not to not always use full bracing, then I'm generally only going to use full bracing when the condition or the body is multi-line. But if we really want to require full bracing all of the time, then I'll code that way, even if I don't like it. That's part of working on a multi-person project. I've been stuck with style requirements that I don't like plenty of times before (e.g. pretty much every Java team I've ever worked on insists on having opening braces on the same line as the statement it goes with, which is _far_ worse IMO than requiring full bracing).

So, yeah. I just want the style requirements to be clear. If they aren't, then I'm likely to just code the way that I normally do, which seems pretty close to what's typically in Phobos at this point anyway.

- Jonathan M Davis