Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/druntime
  Commit: fdd189b990bbb960715949913b0a128031aa9526
      https://github.com/D-Programming-Language/druntime/commit/fdd189b990bbb960715949913b0a128031aa9526
  Author: Walter Bright <walter@walterbright.com>
  Date:   2012-02-17 (Fri, 17 Feb 2012)

  Changed paths:
    M import/object.di
  M src/object_.d

  Log Message:
  -----------
  more const correct

Hi,

this commit introduced different modifiers @safe and @trusted for TypeInfo.getHash in the d and the di file. This can cause link errors.

Rainer

On 18.02.2012 00:02, GitHub wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/D-Programming-Language/druntime
>    Commit: fdd189b990bbb960715949913b0a128031aa9526
>        https://github.com/D-Programming-Language/druntime/commit/fdd189b990bbb960715949913b0a128031aa9526
>    Author: Walter Bright<walter@walterbright.com>
>    Date:   2012-02-17 (Fri, 17 Feb 2012)
>
>    Changed paths:
>      M import/object.di
>    M src/object_.d
>
>    Log Message:
>    -----------
>    more const correct
>
>
>
>
>
>
> _______________________________________________
> D-runtime mailing list
> D-runtime@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/d-runtime

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

I understand. Libraries must be recompiled to use it. There'll be more such breakage as we shift to const/pure/nothrow/@safe.

On 2/24/2012 1:32 PM, Rainer Schuetze wrote:
> Hi,
>
> this commit introduced different modifiers @safe and @trusted for TypeInfo.getHash in the d and the di file. This can cause link errors.
>
> Rainer
>
> On 18.02.2012 00:02, GitHub wrote:
>>    Branch: refs/heads/master
>>    Home:   https://github.com/D-Programming-Language/druntime
>>    Commit: fdd189b990bbb960715949913b0a128031aa9526
>>        https://github.com/D-Programming-Language/druntime/commit/fdd189b990bbb960715949913b0a128031aa9526
>>    Author: Walter Bright<walter@walterbright.com>
>>    Date:   2012-02-17 (Fri, 17 Feb 2012)
>>
>>    Changed paths:
>>      M import/object.di
>>    M src/object_.d
>>
>>    Log Message:
>>    -----------
>>    more const correct
>>
>>
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 24.02.2012 22:54, Walter Bright wrote:
> I understand. Libraries must be recompiled to use it. There'll be more such breakage as we shift to const/pure/nothrow/@safe.
>

Just to clarify: the breakage is not due to libraries that have not been recompiled. The breakage is caused by inconsistent declarations in _object.d and object.di.

> On 2/24/2012 1:32 PM, Rainer Schuetze wrote:
>> Hi,
>>
>> this commit introduced different modifiers @safe and @trusted for TypeInfo.getHash in the d and the di file. This can cause link errors.
>>
>> Rainer
>>
>> On 18.02.2012 00:02, GitHub wrote:
>>>    Branch: refs/heads/master
>>>    Home:   https://github.com/D-Programming-Language/druntime
>>>    Commit: fdd189b990bbb960715949913b0a128031aa9526
>>>        https://github.com/D-Programming-Language/druntime/commit/fdd189b990bbb960715949913b0a128031aa9526
>>>    Author: Walter Bright<walter@walterbright.com>
>>>    Date:   2012-02-17 (Fri, 17 Feb 2012)
>>>
>>>    Changed paths:
>>>      M import/object.di
>>>    M src/object_.d
>>>
>>>    Log Message:
>>>    -----------
>>>    more const correct
>>>
>>>
> _______________________________________________
> dmd-internals mailing list
> dmd-internals@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 2/28/2012 12:44 AM, Rainer Schuetze wrote:
> On 24.02.2012 22:54, Walter Bright wrote:
>> I understand. Libraries must be recompiled to use it. There'll be more such breakage as we shift to const/pure/nothrow/@safe.
>>
>
> Just to clarify: the breakage is not due to libraries that have not been recompiled. The breakage is caused by inconsistent declarations in _object.d and object.di.
>

Hmm. The auto tester shows all green.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On Tue, 28 Feb 2012 10:55:18 +0100, Walter Bright <walter@digitalmars.com> wrote:

>
>
> On 2/28/2012 12:44 AM, Rainer Schuetze wrote:
>> On 24.02.2012 22:54, Walter Bright wrote:
>>> I understand. Libraries must be recompiled to use it. There'll be more such breakage as we shift to const/pure/nothrow/@safe.
>>>
>>
>> Just to clarify: the breakage is not due to libraries that have not been recompiled. The breakage is caused by inconsistent declarations in _object.d and object.di.
>>
>
> Hmm. The auto tester shows all green.
> _______________________________________________
> dmd-internals mailing list
> dmd-internals@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals

https://github.com/D-Programming-Language/druntime/commit/fdd189b990bbb960715949913b0a128031aa9526#commitcomment-1021879
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 28.02.2012 10:55, Walter Bright wrote:
>
>
> On 2/28/2012 12:44 AM, Rainer Schuetze wrote:
>> On 24.02.2012 22:54, Walter Bright wrote:
>>> I understand. Libraries must be recompiled to use it. There'll be more such breakage as we shift to const/pure/nothrow/@safe.
>>>
>>
>> Just to clarify: the breakage is not due to libraries that have not been recompiled. The breakage is caused by inconsistent declarations in _object.d and object.di.
>>
>
> Hmm. The auto tester shows all green.
> _______________________________________________
> dmd-internals mailing list
> dmd-internals@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
>

Agreed, it isn't standard code that creates this issue, but I hit it with one of my libraries. I've reduced a test case:

class TypeInfo2 : TypeInfo {}
void main() {}

>dmd.exe test.d
DMD v2.059 DEBUG
OPTLINK (R) for Win32  Release 8.00.11
Copyright (C) Digital Mars 1989-2010  All rights reserved.
http://www.digitalmars.com/ctg/optlink.html
test.obj(test)
 Error 42: Symbol Undefined _D6object8TypeInfo7getHashMFNfxPvZk
--- errorlevel 1

Martin's link points to the source of the trouble.

_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 28 Feb 2012, at 18:18, Martin Nowak wrote:
> https://github.com/D-Programming-Language/druntime/commit/fdd189b990bbb960715949913b0a128031aa9526#commitcomment-1021879

Related question: Why do we mangle @trusted differently from @safe in the first place?

David
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals

On 2/28/2012 2:17 PM, David Nadlinger wrote:
>
> Related question: Why do we mangle @trusted differently from @safe in the first place?
>

Good question. So it can be demangled.
_______________________________________________
dmd-internals mailing list
dmd-internals@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-internals