http://ftp.digitalmars.com/dmd2beta.zip

Remaining regressions:

http://d.puremagic.com/issues/buglist.cgi?query_format=advanced&bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED 

_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

On May 21, 2013, at 10:35 PM, Walter Bright <walter@digitalmars.com> wrote:

> http://ftp.digitalmars.com/dmd2beta.zip
> 

I get the following error compiling DWT:


"static_this without 'this' cannot be shared"

This is most likely a correct change (I've already fixed the code) but there was no warnings, no depreciation message, it just suddenly stopped compiling.

--
/Jacob Carlborg

On 5/23/2013 12:00 AM, Jacob Carlborg wrote:
> On May 21, 2013, at 10:35 PM, Walter Bright <walter@digitalmars.com> wrote:
>
>> http://ftp.digitalmars.com/dmd2beta.zip
>
> I get the following error compiling DWT:
>
>
> "static_this without 'this' cannot be shared"
>
> This is most likely a correct change (I've already fixed the code) but there was no warnings, no depreciation message, it just suddenly stopped compiling.

Is the message clear in the context of the code it flagged?

> Is the message clear in the context of the code it flagged?

The complete error message (move outside of DWT) :

main.d(8): Error: function main.Foo.static_this without 'this' cannot be shared

Yes, I think it's clear enough. It could be a bit more precise, like saying: " static method main.Foo.static_this cannot be shared". Do we have a matching bugzilla report for this?

--
/Jacob Carlborg

On 5/23/2013 12:24 AM, Jacob Carlborg wrote:
>
>> Is the message clear in the context of the code it flagged?
>
> The complete error message (move outside of DWT) :
>
> main.d(8): Error: function main.Foo.static_this without 'this' cannot be shared
>
> Yes, I think it's clear enough. It could be a bit more precise, like saying: " static method main.Foo.static_this cannot be shared". Do we have a matching bugzilla report for this?

Yes, but I don't know which one. The issue is attempting to declare:

   shared int foo() { ... }

where shared would apply to the 'this' reference, but there is no 'this' reference. This was an "accepts invalid code" bug in the compiler.
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

On May 21, 2013, at 10:35 PM, Walter Bright <walter@digitalmars.com> wrote:

> http://ftp.digitalmars.com/dmd2beta.zip

There are a couple of errors in Tango. Tango compiled perfectly fine with the previous release, 2.062, without any warnings or deprecation messages.

* tango/io/device/File.d(290): Error: cannot make expression out of initializer for ReadExisting

https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/io/device/File.d#L290

* tango/core/tools/StackTrace.d(186): Error: class tango.core.tools.StackTrace.BasicTraceInfo interface function 'string toString() const' is not implemented

https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/core/tools/StackTrace.d#L186

* tango/io/selector/SelectSelector.d(156): Error: function tango.io.selector.SelectSelector.HandleSet.opAssign is not callable because it is annotated with @disable

https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/io/selector/SelectSelector.d#L156

Tango doesn't use @disable at all. "opAssign" is not overloaded.

* Error: cannot modify struct this HandleSet with immutable members

No file or line information. Ok, I would the actual problem, but the error message is very unclear. There was a "const" member in HandleSet, it should have been static.

https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/io/selector/SelectSelector.d#L783

* tango/text/Regex.d(1779): Error: variable tango.text.Regex.TNFA!(dchar).TNFA.pca final cannot be applied to variable, perhaps you meant const?
tango/text/Regex.d(2528): Error: template instance tango.text.Regex.TNFA!(dchar) error instantiating
tango/text/Regex.d(3668):        instantiated from here: TDFA!(dchar)
tango/text/Regex.d(4412):        instantiated from here: RegExpT!(char)
tango/text/Regex.d(3668): Error: template instance tango.text.Regex.TDFA!(dchar) error instantiating
tango/text/Regex.d(4412):        instantiated from here: RegExpT!(char)
tango/text/Regex.d(4399): Error: tdfa_t.Command is used as a type
tango/text/Regex.d(4412): Error: template instance tango.text.Regex.RegExpT!(char) error instantiatin

https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/text/Regex.d#L1779

There are no final variables in that file as far as I can see. The error message is pointing to an enum.

I stopped here because I don't know how to fix the error in Regex.

--
/Jacob Carlborg

On May 23, 2013, at 09:43 AM, Walter Bright <walter@digitalmars.com> wrote:

> Yes, but I don't know which one. The issue is attempting to declare:
>
> shared int foo() { ... }
>
> where shared would apply to the 'this' reference, but there is no 'this' reference. This was an "accepts invalid code" bug in the compiler.

I absolutely agree. The change is correct. But there's no deprecation messages or warnings, I don't know if it would be possible though to add.

--
/Jacob Carlborg

On Thursday, May 23, 2013 08:11:29 Jacob Carlborg wrote:
> On May 23, 2013, at 09:43 AM, Walter Bright <walter@digitalmars.com> wrote:
> > Yes, but I don't know which one. The issue is attempting to declare:
> > 
> > shared int foo() { ... }
> > 
> > where shared would apply to the 'this' reference, but there is no 'this' reference. This was an "accepts invalid code" bug in the compiler.
> 
> I absolutely agree. The change is correct. But there's no deprecation messages or warnings, I don't know if it would be possible though to add.

If it's "Accepts Invalid," I wouldn't think that a deprecation message or warning would be appropriate. It's code that shouldn't even have compiled in the first place, not a feature that's been removed.

- Jonathan M Davis
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

Ye, because D users can for sure check what is valid and what it is
not - all they need is just look up the spec... Oh, wait.
I'll better continue in fresh shiny stability thread :)

On Thu, May 23, 2013 at 11:19 AM, Jonathan M Davis <jmdavisProg@gmx.com> wrote:
> On Thursday, May 23, 2013 08:11:29 Jacob Carlborg wrote:
>> On May 23, 2013, at 09:43 AM, Walter Bright <walter@digitalmars.com> wrote:
>> > Yes, but I don't know which one. The issue is attempting to declare:
>> >
>> > shared int foo() { ... }
>> >
>> > where shared would apply to the 'this' reference, but there is no 'this' reference. This was an "accepts invalid code" bug in the compiler.
>>
>> I absolutely agree. The change is correct. But there's no deprecation messages or warnings, I don't know if it would be possible though to add.
>
> If it's "Accepts Invalid," I wouldn't think that a deprecation message or warning would be appropriate. It's code that shouldn't even have compiled in the first place, not a feature that's been removed.
>
> - Jonathan M Davis
> _______________________________________________
> dmd-beta mailing list
> dmd-beta@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-beta
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

I suspect some of these problems are caused by pull #93. To check, compile with:

     -transition=field

and add "static" to those declarations.


On 5/23/2013 1:08 AM, Jacob Carlborg wrote:
> On May 21, 2013, at 10:35 PM, Walter Bright <walter@digitalmars.com> wrote:
>
>> http://ftp.digitalmars.com/dmd2beta.zip
>
> There are a couple of errors in Tango. Tango compiled perfectly fine with the previous release, 2.062, without any warnings or deprecation messages.
>
> * tango/io/device/File.d(290): Error: cannot make expression out of initializer for ReadExisting
>
> https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/io/device/File.d#L290
>
> * tango/core/tools/StackTrace.d(186): Error: class tango.core.tools.StackTrace.BasicTraceInfo interface function 'string toString() const' is not implemented
>
> https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/core/tools/StackTrace.d#L186
>
> * tango/io/selector/SelectSelector.d(156): Error: function tango.io.selector.SelectSelector.HandleSet.opAssign is not callable because it is annotated with @disable
>
> https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/io/selector/SelectSelector.d#L156
>
> Tango doesn't use @disable at all. "opAssign" is not overloaded.

This message can happen if opAssign is generated, but the generated function failed to compile.

>
> * Error: cannot modify struct this HandleSet with immutable members
>
> No file or line information. Ok, I would the actual problem, but the error message is very unclear. There was a "const" member in HandleSet, it should have been static.
>
> https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/io/selector/SelectSelector.d#L783
>
> * tango/text/Regex.d(1779): Error: variable
> tango.text.Regex.TNFA!(dchar).TNFA.pca final cannot be applied to variable,
> perhaps you meant const?
> tango/text/Regex.d(2528): Error: template instance
> tango.text.Regex.TNFA!(dchar) error instantiating
> tango/text/Regex.d(3668):        instantiated from here: TDFA!(dchar)
> tango/text/Regex.d(4412):        instantiated from here: RegExpT!(char)
> tango/text/Regex.d(3668): Error: template instance
> tango.text.Regex.TDFA!(dchar) error instantiating
> tango/text/Regex.d(4412):        instantiated from here: RegExpT!(char)
> tango/text/Regex.d(4399): Error: tdfa_t.Command is used as a type
> tango/text/Regex.d(4412): Error: template instance
> tango.text.Regex.RegExpT!(char) error instantiatin
>
> https://github.com/SiegeLord/Tango-D2/blob/d2port/tango/text/Regex.d#L1779
>
> There are no final variables in that file as far as I can see. The error message is pointing to an enum.
>
> I stopped here because I don't know how to fix the error in Regex.
>
> --
> /Jacob Carlborg
>
>
> _______________________________________________
> dmd-beta mailing list
> dmd-beta@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-beta