It's time we prepared another release. Currently, we've got 11 regressions to be addressed:

https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=47252&query_format=advanced

Not bad, but let's get 'em done.
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

On Thu, Jun 26, 2014 at 03:29:03PM -0700, Walter Bright via dmd-beta wrote:
> It's time we prepared another release. Currently, we've got 11 regressions to be addressed:
> 
> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=47252&query_format=advanced
> 
> Not bad, but let's get 'em done.
[...]

Regarding https://issues.dlang.org/show_bug.cgi?id=12255 :

I'm not sure why PR 3054 was merged, but it has some serious issues. First, it didn't make any sense to me to require opCmp, because AA's in D are unordered, so all that matters for something to be used as an AA key should be (1) it has a hash value, (2) two keys can be compared for *equality*. Requiring opCmp for AA keys just seem totally backwards to me. It imposes the requirement for keys to be (linearly!) orderable, but some AA keys need not be.

Now, I realize that the reason probably has something to do with the fact that the AA implementation used to call Typeinfo.compare() to compare AA keys, instead of Typeinfo.equals() as it ought to. But that has since been fixed. So the compiler really should be changed to require opEquals instead of opCmp, just as Steven said in the comments to issue 12255.

Second, PR 3054 was broken in other ways, namely issue 12905 (which wasn't marked as a regression, but IMO it should be).

Since we have to deal with this for the next release, let's pretty please do it right this time:

(1) AA keys should either have neither opEquals nor toHash, or they
should have both (the onus is on the user to make sure they are
consistent with each other).

(2) We should review the compiler-generated default opEquals / toHash to make sure they make sense, and are consistent with each other. (I remember seeing code in object.d where some TypeInfo's have broken compare/equals implementations.)

(3) Issue 12905 needs to be fixed before this release (IOW the broken
parts of PR 3054 should be reverted).


T

-- 
What do you mean the Internet isn't filled with subliminal messages? What about all those buttons marked "submit"??
_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

We cannot release without either reverting the changes to AA requirements, or making it so we are sure code that was flawed, but previously worked, is flagged as an error.

See this comment: https://github.com/D-Programming-Language/dmd/pull/3599#issuecomment-45275443

Code that previously (incorrectly) relies on the fact that AA code only calls compare, and defines only opCmp and not opEquals, will SILENTLY BREAK if we release today.

This is not acceptable. It needs to break, but break loudly, and not compile.

-Steve

On Jun 26, 2014, at 7:45 PM, H. S. Teoh via dmd-beta <dmd-beta@puremagic.com> wrote:

> On Thu, Jun 26, 2014 at 03:29:03PM -0700, Walter Bright via dmd-beta wrote:
>> It's time we prepared another release. Currently, we've got 11 regressions to be addressed:
>> 
>> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=47252&query_format=advanced
>> 
>> Not bad, but let's get 'em done.
> [...]
> 
> Regarding https://issues.dlang.org/show_bug.cgi?id=12255 :
> 
> I'm not sure why PR 3054 was merged, but it has some serious issues. First, it didn't make any sense to me to require opCmp, because AA's in D are unordered, so all that matters for something to be used as an AA key should be (1) it has a hash value, (2) two keys can be compared for *equality*. Requiring opCmp for AA keys just seem totally backwards to me. It imposes the requirement for keys to be (linearly!) orderable, but some AA keys need not be.
> 
> Now, I realize that the reason probably has something to do with the fact that the AA implementation used to call Typeinfo.compare() to compare AA keys, instead of Typeinfo.equals() as it ought to. But that has since been fixed. So the compiler really should be changed to require opEquals instead of opCmp, just as Steven said in the comments to issue 12255.
> 
> Second, PR 3054 was broken in other ways, namely issue 12905 (which wasn't marked as a regression, but IMO it should be).
> 
> Since we have to deal with this for the next release, let's pretty please do it right this time:
> 
> (1) AA keys should either have neither opEquals nor toHash, or they
> should have both (the onus is on the user to make sure they are
> consistent with each other).
> 
> (2) We should review the compiler-generated default opEquals / toHash to make sure they make sense, and are consistent with each other. (I remember seeing code in object.d where some TypeInfo's have broken compare/equals implementations.)
> 
> (3) Issue 12905 needs to be fixed before this release (IOW the broken
> parts of PR 3054 should be reverted).
> 
> 
> T
> 
> -- 
> What do you mean the Internet isn't filled with subliminal messages? What about all those buttons marked "submit"??
> _______________________________________________
> dmd-beta mailing list
> dmd-beta@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-beta


_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

2014-06-27 7:29 GMT+09:00 Walter Bright via dmd-beta <dmd-beta@puremagic.com
>:

> It's time we prepared another release. Currently, we've got 11 regressions to be addressed:
>
> https://issues.dlang.org/buglist.cgi?bug_severity= regression&bug_status=NEW&bug_status=ASSIGNED&bug_status= REOPENED&list_id=47252&query_format=advanced
>
> Not bad, but let's get 'em done.
>

I'm opening pull requests to fix some regression issues.

Issue 12242 - conflict error with public imports https://github.com/D-Programming-Language/dmd/pull/3388

Issue 12859 - Read-modify-write operation for shared variable in Phobos https://github.com/D-Programming-Language/phobos/pull/2281

Issue 12981 - Can't refer to 'outer' from mixin template https://github.com/D-Programming-Language/dmd/pull/3700

Kenji Hara

On 6/27/14, 7:29 AM, Walter Bright via dmd-beta wrote:
> It's time we prepared another release. Currently, we've got 11 regressions to be addressed:
>
> https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=47252&query_format=advanced
>
>
> Not bad, but let's get 'em done.
> _______________________________________________
> dmd-beta mailing list
> dmd-beta@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-beta
Hello all,


I am encountering some major issues with the build system that will delay the beta. Martin Nowak, the person responsible for the vagrant box automation used in our build process, has been around to assist me resolving these issues in the past, however, I have not seen or heard from him in almost 2 weeks so I am trying to build the release without using vagrant.

Among other things, https://issues.dlang.org/show_bug.cgi?id=13005 currently blocks my progress on Windows.

With the exception that the OS specific archive cannot be made because of missing staged binaries, OSX and Linux builds successfully. I am wondering if it possible to stage these files in the proper location of the git repo rather than having to move them into place for every build?

I am running Trusty Thar on my linux box so this will probably cause issues for issues using older systems. I still need to set up and attempt to build on two separate FreeBSD boxes (32-bit & 64-bit).

Andrew

On 30 jun 2014, at 01:28, Andrew Edwards via dmd-beta <dmd-beta@puremagic.com> wrote:

> I am encountering some major issues with the build system that will delay the beta. Martin Nowak, the person responsible for the vagrant box automation used in our build process, has been around to assist me resolving these issues in the past, however, I have not seen or heard from him in almost 2 weeks so I am trying to build the release without using vagrant.

What issues to you get using vagrant?

-- 
/Jacob Carlborg

On 6/30/14, 8:59 PM, Jacob Carlborg wrote:
>
> On 30 jun 2014, at 01:28, Andrew Edwards via dmd-beta <dmd-beta@puremagic.com <mailto:dmd-beta@puremagic.com>> wrote:
>
>> I am encountering some major issues with the build system that will delay the beta. Martin Nowak, the person responsible for the vagrant box automation used in our build process, has been around to assist me resolving these issues in the past, however, I have not seen or heard from him in almost 2 weeks so I am trying to build the release without using vagrant.
>
> What issues to you get using vagrant?
>
> -- 
> /Jacob Carlborg
>
Both the Windows and OSX boxes fail due to invalid shell configuration after a number of connection timeouts. All attempt to access the box form the CL results in success. Windows output is here: https://gist.github.com/AndrewEdwards/fa00ec011bc3bda8ae1d. I do not have the OSX output at the moment, but it's the same problem, just more connection timeouts.

Andrew

Since this is a regression fix,

https://github.com/D-Programming-Language/dmd/pull/3683

please put a priority on reviewing/merging it. Thanks!

_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta

Speaking of which, I don't know if I'll be able to make the changelog for this release. I don't have a PC yet here, and I'm super busy at my new job (which I am SO grateful for, and for having responsibility here).

So a heads up regarding that!


On Friday, June 27, 2014, Walter Bright via dmd-beta <dmd-beta@puremagic.com> wrote:
> It's time we prepared another release. Currently, we've got 11
regressions to be addressed:
>
>
https://issues.dlang.org/buglist.cgi?bug_severity=regression&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=47252&query_format=advanced
>
> Not bad, but let's get 'em done.
> _______________________________________________
> dmd-beta mailing list
> dmd-beta@puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-beta

Your job comes first!

PCs, though, are easy to come by. I just bought a purty nice laptop from the pawn shop for $150.

On 7/2/2014 1:33 PM, Andrej Mitrovic wrote:
> Speaking of which, I don't know if I'll be able to make the changelog for this release. I don't have a PC yet here, and I'm super busy at my new job (which I am SO grateful for, and for having responsibility here).
>
> So a heads up regarding that!

_______________________________________________
dmd-beta mailing list
dmd-beta@puremagic.com
http://lists.puremagic.com/mailman/listinfo/dmd-beta