Hey folks, a while ago I raised the point about the bad rendering of ddox-generated pages, for example:

http://dlang.org/library/std/algorithm/findSplit.html

Google returns such links so it's important the pages look professional. Could somebody fluent with ddox get on this sooner than ASAP please? This is important and urgent, even more so than a blocker on the release because it's already out there.

cc Sönke


Andrei

On Wednesday, 11 March 2015 at 05:15:08 UTC, Andrei Alexandrescu wrote:
> Hey folks, a while ago I raised the point about the bad rendering of ddox-generated pages, for example:
>
> http://dlang.org/library/std/algorithm/findSplit.html
>
> Google returns such links so it's important the pages look professional. Could somebody fluent with ddox get on this sooner than ASAP please? This is important and urgent, even more so than a blocker on the release because it's already out there.

This has already been fixed in git. But there is another (small) regression in git, because of which I haven't updated the website yet, and I've already pinged Martin about it.

On 3/10/15 10:21 PM, Vladimir Panteleev wrote:
> On Wednesday, 11 March 2015 at 05:15:08 UTC, Andrei Alexandrescu wrote:
>> Hey folks, a while ago I raised the point about the bad rendering of
>> ddox-generated pages, for example:
>>
>> http://dlang.org/library/std/algorithm/findSplit.html
>>
>> Google returns such links so it's important the pages look
>> professional. Could somebody fluent with ddox get on this sooner than
>> ASAP please? This is important and urgent, even more so than a blocker
>> on the release because it's already out there.
>
> This has already been fixed in git. But there is another (small)
> regression in git, because of which I haven't updated the website yet,
> and I've already pinged Martin about it.

Whew! Thanks, I trust you two will take this home. -- Andrei

On Wednesday, 11 March 2015 at 05:21:27 UTC, Vladimir Panteleev wrote:
> On Wednesday, 11 March 2015 at 05:15:08 UTC, Andrei Alexandrescu wrote:
>> Hey folks, a while ago I raised the point about the bad rendering of ddox-generated pages, for example:
>>
>> http://dlang.org/library/std/algorithm/findSplit.html
>>
>> Google returns such links so it's important the pages look professional. Could somebody fluent with ddox get on this sooner than ASAP please? This is important and urgent, even more so than a blocker on the release because it's already out there.
>
> This has already been fixed in git. But there is another (small) regression in git, because of which I haven't updated the website yet, and I've already pinged Martin about it.

Details:

1. Original problem:

https://issues.dlang.org/show_bug.cgi?id=14150
https://github.com/D-Programming-Language/dlang.org/pull/901

2. A segmentation fault / infinite loop in dpl-docs:

(this stalled deployment of 1. for a few weeks)

https://issues.dlang.org/show_bug.cgi?id=14258
https://github.com/D-Programming-Language/dlang.org/pull/925

3. Regression with automatic expansion of the navigation menu:

https://github.com/D-Programming-Language/dlang.org/pull/907#commitcomment-10120008

I was going to file a regression if I didn't hear from Martin in 24h.

On 3/10/2015 10:15 PM, Andrei Alexandrescu wrote:
> Hey folks, a while ago I raised the point about the bad rendering of
> ddox-generated pages, for example:
>
> http://dlang.org/library/std/algorithm/findSplit.html
>
> Google returns such links so it's important the pages look professional. Could
> somebody fluent with ddox get on this sooner than ASAP please? This is important
> and urgent, even more so than a blocker on the release because it's already out
> there.

While we're at it:

  http://dlang.org/

Note that there are no navigation links to the "how to use dmd" pages, like:

  http://dlang.org/dmd-windows.html

These used to be there, but have vanished at some point in the last couple months.

This is embarrassingly awful.

On 2015-03-11 06:27, Walter Bright wrote:

> While we're at it:
>
>    http://dlang.org/
>
> Note that there are no navigation links to the "how to use dmd" pages,
> like:
>
>    http://dlang.org/dmd-windows.html
>
> These used to be there, but have vanished at some point in the last
> couple months.
>
> This is embarrassingly awful.

@Andrei, would some browser testing help here? It's possible to check if some parts of the site is present and visible, i.e. a link or some text. With links it's also possible to check if they lead to the correct page.

-- 
/Jacob Carlborg

On Wednesday, 11 March 2015 at 07:22:41 UTC, Jacob Carlborg wrote:
> On 2015-03-11 06:27, Walter Bright wrote:
>
>> While we're at it:
>>
>>   http://dlang.org/
>>
>> Note that there are no navigation links to the "how to use dmd" pages,
>> like:
>>
>>   http://dlang.org/dmd-windows.html
>>
>> These used to be there, but have vanished at some point in the last
>> couple months.
>>
>> This is embarrassingly awful.
>
> @Andrei, would some browser testing help here? It's possible to check if some parts of the site is present and visible, i.e. a link or some text. With links it's also possible to check if they lead to the correct page.

chmgen has some linting functionality (improved in the latest version), it does warn about this:

Warning: Page not in navigation: dmd-freebsd.html
Warning: Page not in navigation: dmd-linux.html
Warning: Page not in navigation: dmd-osx.html
Warning: Page not in navigation: dmd-windows.html

Of course, nobody actually pays attention to these warnings.

On 2015-03-11 08:24, Vladimir Panteleev wrote:

> chmgen has some linting functionality (improved in the latest version),
> it does warn about this:
>
> Warning: Page not in navigation: dmd-freebsd.html
> Warning: Page not in navigation: dmd-linux.html
> Warning: Page not in navigation: dmd-osx.html
> Warning: Page not in navigation: dmd-windows.html
>
> Of course, nobody actually pays attention to these warnings.

These things need to be built by the auto tester, and warnings turned into errors.

-- 
/Jacob Carlborg

On Wednesday, 11 March 2015 at 05:15:08 UTC, Andrei Alexandrescu wrote:
> Google returns such links so it's important the pages look professional. Could somebody fluent with ddox get on this sooner than ASAP please? This is important and urgent, even more so than a blocker on the release because it's already out there.

We either have to update dpl-docs in lockstep with dlang.org or use separate stylesheets in dpl-docs that might lack behind to avoid this in future.

On Wed, Mar 11, 2015 at 04:49:53PM +0000, Martin Nowak via Digitalmars-d wrote:
> On Wednesday, 11 March 2015 at 05:15:08 UTC, Andrei Alexandrescu wrote:
> >Google returns such links so it's important the pages look professional.  Could somebody fluent with ddox get on this sooner than ASAP please? This is important and urgent, even more so than a blocker on the release because it's already out there.
> 
> We either have to update dpl-docs in lockstep with dlang.org or use separate stylesheets in dpl-docs that might lack behind to avoid this in future.

IMO, we really should have a staging website that is used for reviewing changes, esp. large-scale changes like ddox, before we push it to the official website.  This isn't the first time an embarrassing change made it to the official website before it was caught. Each time, it causes a mad scramble to get it fixed, and we end up adopting last-minute hack solutions because of the time pressure rather than engineering a proper solution from the start.

(And by staging website I don't mean somebody's personal copy of dlang.org with proposed changes layered on top, I mean an actual, fully-functional deployment of dlang.org that incorporates all current PRs and polished as if it were the actual website, except that it's at a non-official address. The official dlang.org website would be rsync'd from this website at periodic intervals when we are confident that any large-scale embarrassing issues have been ironed out. The staging website would have a suitable robots.txt to prevent Google from indexing it as official material, so that the unwary don't accidentally stumble into it.)


T

-- 
Nothing in the world is more distasteful to a man than to take the path that leads to himself. -- Herman Hesse