July 26, 2010 [phobos] Need to start wrapping up this release | ||||
|---|---|---|---|---|
| ||||
 Posted in reply to Sean Kelly | Refactoring breaks the test suite, the documentation, the sample code provided in the distribution, and user code. http://www.digitalmars.com/d/2.0/dll.html Dlls are hard enough for people to get right without upending their existing, working code. Any refactoring attempt must include support for existing code if at all possible, marked with "deprecated" as necessary, and documentation explaining how to upgrade the code. Can you please revert these changes until all of the above can be taken care of? Sean Kelly wrote: > Most of it was refactoring. The problem is really that I don't have a working Windows environment to test with any more. I'll see about rectifying that though. It really is inexcusable that I keep checking in changes that I can't verify. > > On Jul 26, 2010, at 2:32 PM, Walter Bright wrote: > > >> Sigh, there are more problems with 344. Now the dll test suite fails to compile: >> >> ..\dmd -g -d -ofmydll2.dll -version=use_patch mydll2.d dll2.d mydll2.def >> std.contracts has been scheduled for deprecation. Please use std.exception instead. >> dll2.d(49): Error: undefined identifier thread_setNeedLock >> dll2.d(53): Error: function core.thread_helper.thread_helper_aux.enumProcessThreads (uint procid, bo >> ol function(uint id, void* context) dg, void* context) is not callable using argument types (_error_ >> function(uint id, void* context),void*) >> dll2.d(53): Error: cannot implicitly convert expression (__funcliteral1) of type _error_ function(ui >> nt id, void* context) to bool function(uint id, void* context) >> dll2.d(92): Error: function core.thread_helper.thread_helper_aux.enumProcessThreads (uint procid, bo >> ol function(uint id, void* context) dg, void* context) is not callable using argument types (_error_ >> function(uint id, void* context),void*) >> dll2.d(92): Error: cannot implicitly convert expression (__funcliteral3) of type _error_ function(ui >> nt id, void* context) to bool function(uint id, void* context) >> dll2.d(138): Error: no property 'findThread' for type 'core.thread.Thread' >> >> It makes me very nervous that wholesale changes were made to the dll interface, and none of it was even checked to see if it compiled, and now the test suite for it is completely broken. >> >> Don Clugston wrote: >> >>> I just checked in a fix for that. >>> >>> On 26 July 2010 22:05, Walter Bright <walter at digitalmars.com> wrote: >>> >>> >>>> The following druntime checkin: >>>> >>>> http://www.dsource.org/projects/druntime/changeset/344 >>>> >>>> breaks the build: >>>> >>>> src\core\dll_helper.d(372): Error: undefined identifier thread_detach >>>> src\core\thread.d(1856): Error: undefined identifier obj >>>> >>>> Sean, can you please fix? >>>> _______________________________________________ >>>> phobos mailing list >>>> phobos at puremagic.com >>>> http://lists.puremagic.com/mailman/listinfo/phobos >>>> >>>> >>>> >>> _______________________________________________ >>> phobos mailing list >>> phobos at puremagic.com >>> http://lists.puremagic.com/mailman/listinfo/phobos >>> >>> >>> >>> >> _______________________________________________ >> phobos mailing list >> phobos at puremagic.com >> http://lists.puremagic.com/mailman/listinfo/phobos >> > > _______________________________________________ > phobos mailing list > phobos at puremagic.com > http://lists.puremagic.com/mailman/listinfo/phobos > > > | |||
Permalink
ReplyJuly 26, 2010 [phobos] Need to start wrapping up this release | ||||
|---|---|---|---|---|
| ||||
 Posted in reply to Walter Bright | And here I thought all that stuff was invisible. It was supposed to be at any rate. I never reviewed the patch when it was applied. Ah well, I'll alias things appropriately so the old way still works.
On Jul 26, 2010, at 5:17 PM, Walter Bright wrote:
> Refactoring breaks the test suite, the documentation, the sample code provided in the distribution, and user code.
>
> http://www.digitalmars.com/d/2.0/dll.html
>
> Dlls are hard enough for people to get right without upending their existing, working code. Any refactoring attempt must include support for existing code if at all possible, marked with "deprecated" as necessary, and documentation explaining how to upgrade the code.
>
> Can you please revert these changes until all of the above can be taken care of?
>
> Sean Kelly wrote:
>> Most of it was refactoring. The problem is really that I don't have a working Windows environment to test with any more. I'll see about rectifying that though. It really is inexcusable that I keep checking in changes that I can't verify.
>>
>> On Jul 26, 2010, at 2:32 PM, Walter Bright wrote:
>>
>>
>>> Sigh, there are more problems with 344. Now the dll test suite fails to compile:
>>>
>>> ..\dmd -g -d -ofmydll2.dll -version=use_patch mydll2.d dll2.d mydll2.def
>>> std.contracts has been scheduled for deprecation. Please use std.exception instead.
>>> dll2.d(49): Error: undefined identifier thread_setNeedLock
>>> dll2.d(53): Error: function core.thread_helper.thread_helper_aux.enumProcessThreads (uint procid, bo
>>> ol function(uint id, void* context) dg, void* context) is not callable using argument types (_error_
>>> function(uint id, void* context),void*)
>>> dll2.d(53): Error: cannot implicitly convert expression (__funcliteral1) of type _error_ function(ui
>>> nt id, void* context) to bool function(uint id, void* context)
>>> dll2.d(92): Error: function core.thread_helper.thread_helper_aux.enumProcessThreads (uint procid, bo
>>> ol function(uint id, void* context) dg, void* context) is not callable using argument types (_error_
>>> function(uint id, void* context),void*)
>>> dll2.d(92): Error: cannot implicitly convert expression (__funcliteral3) of type _error_ function(ui
>>> nt id, void* context) to bool function(uint id, void* context)
>>> dll2.d(138): Error: no property 'findThread' for type 'core.thread.Thread'
>>>
>>> It makes me very nervous that wholesale changes were made to the dll interface, and none of it was even checked to see if it compiled, and now the test suite for it is completely broken.
>>>
>>> Don Clugston wrote:
>>>
>>>> I just checked in a fix for that.
>>>>
>>>> On 26 July 2010 22:05, Walter Bright <walter at digitalmars.com> wrote:
>>>>
>>>>> The following druntime checkin:
>>>>>
>>>>> http://www.dsource.org/projects/druntime/changeset/344
>>>>>
>>>>> breaks the build:
>>>>>
>>>>> src\core\dll_helper.d(372): Error: undefined identifier thread_detach
>>>>> src\core\thread.d(1856): Error: undefined identifier obj
>>>>>
>>>>> Sean, can you please fix?
>>>>> _______________________________________________
>>>>> phobos mailing list
>>>>> phobos at puremagic.com
>>>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>>>>
>>>>>
>>>> _______________________________________________
>>>> phobos mailing list
>>>> phobos at puremagic.com
>>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>>>
>>>>
>>>>
>>> _______________________________________________
>>> phobos mailing list
>>> phobos at puremagic.com
>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>>
>>
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos
>>
>>
>>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
| |||
July 26, 2010 [phobos] Need to start wrapping up this release | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Walter Bright | Can you show me where I broke documented behavior? I can't find any conflicts and don't want to miss anything.
On Jul 26, 2010, at 5:17 PM, Walter Bright wrote:
> Refactoring breaks the test suite, the documentation, the sample code provided in the distribution, and user code.
>
> http://www.digitalmars.com/d/2.0/dll.html
>
> Dlls are hard enough for people to get right without upending their existing, working code. Any refactoring attempt must include support for existing code if at all possible, marked with "deprecated" as necessary, and documentation explaining how to upgrade the code.
>
> Can you please revert these changes until all of the above can be taken care of?
>
> Sean Kelly wrote:
>> Most of it was refactoring. The problem is really that I don't have a working Windows environment to test with any more. I'll see about rectifying that though. It really is inexcusable that I keep checking in changes that I can't verify.
>>
>> On Jul 26, 2010, at 2:32 PM, Walter Bright wrote:
>>
>>
>>> Sigh, there are more problems with 344. Now the dll test suite fails to compile:
>>>
>>> ..\dmd -g -d -ofmydll2.dll -version=use_patch mydll2.d dll2.d mydll2.def
>>> std.contracts has been scheduled for deprecation. Please use std.exception instead.
>>> dll2.d(49): Error: undefined identifier thread_setNeedLock
>>> dll2.d(53): Error: function core.thread_helper.thread_helper_aux.enumProcessThreads (uint procid, bo
>>> ol function(uint id, void* context) dg, void* context) is not callable using argument types (_error_
>>> function(uint id, void* context),void*)
>>> dll2.d(53): Error: cannot implicitly convert expression (__funcliteral1) of type _error_ function(ui
>>> nt id, void* context) to bool function(uint id, void* context)
>>> dll2.d(92): Error: function core.thread_helper.thread_helper_aux.enumProcessThreads (uint procid, bo
>>> ol function(uint id, void* context) dg, void* context) is not callable using argument types (_error_
>>> function(uint id, void* context),void*)
>>> dll2.d(92): Error: cannot implicitly convert expression (__funcliteral3) of type _error_ function(ui
>>> nt id, void* context) to bool function(uint id, void* context)
>>> dll2.d(138): Error: no property 'findThread' for type 'core.thread.Thread'
>>>
>>> It makes me very nervous that wholesale changes were made to the dll interface, and none of it was even checked to see if it compiled, and now the test suite for it is completely broken.
>>>
>>> Don Clugston wrote:
>>>
>>>> I just checked in a fix for that.
>>>>
>>>> On 26 July 2010 22:05, Walter Bright <walter at digitalmars.com> wrote:
>>>>
>>>>> The following druntime checkin:
>>>>>
>>>>> http://www.dsource.org/projects/druntime/changeset/344
>>>>>
>>>>> breaks the build:
>>>>>
>>>>> src\core\dll_helper.d(372): Error: undefined identifier thread_detach
>>>>> src\core\thread.d(1856): Error: undefined identifier obj
>>>>>
>>>>> Sean, can you please fix?
>>>>> _______________________________________________
>>>>> phobos mailing list
>>>>> phobos at puremagic.com
>>>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>>>>
>>>>>
>>>> _______________________________________________
>>>> phobos mailing list
>>>> phobos at puremagic.com
>>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>>>
>>>>
>>>>
>>> _______________________________________________
>>> phobos mailing list
>>> phobos at puremagic.com
>>> http://lists.puremagic.com/mailman/listinfo/phobos
>>>
>>
>> _______________________________________________
>> phobos mailing list
>> phobos at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/phobos
>>
>>
>>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
| |||
Copyright © 1999-2021 by the D Language Foundation