|Posted by Vladimir Panteleev|
in reply to mw
On Wednesday, 23 June 2021 at 20:12:46 UTC, mw wrote:
I think the pull request needs work, though the reviewer didn't do a good job of explaining why.
It's not clear what causes the error message exactly. How could
llvm_bswap conflict with
nativeToBigEndian? They have different names. There should be an explanation for how the conflict arose, why it happens only with LDC, and how your proposed change fixes it.
It's not explained what the conflict problem has anything to do with OpenSSL. Your pull request description makes no mention about OpenSSL, yet most of the changes in the diff are concerning it one way or the other.
It's not explained what the OpenSSL changes are even needed for. "Fixing LDC" is not a sufficient explanation, they need to explain what exactly is broken, why it is broken, what is being changed, and how the change fixes the problem.
The OpenSSL changes really should be in a completely separate pull request.
If for whatever reason the OpenSSL changes cannot be in a separate pull request, then it should be explained why.
There should also be a justification for why the problem is being fixed by making a change (or changes) in Apache Thrift, and not in LDC on the D OpenSSL bindings etc.
All answers to these questions should be included in commit messages or the pull request description.
I suggest closing that PR, and opening a new PR (or PRs) which address the above.