https://issues.dlang.org/show_bug.cgi?id=13810

yebblies <yebblies@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yebblies@gmail.com

--- Comment #1 from yebblies <yebblies@gmail.com> ---
> "minor ICE" whatever that means

It means that it should never happen, and it's a bug in the compiler, but the error is correct and gives the correct message/location info.  If coming from e2ir, it means the error wasn't detected during semantic analysis and instead got detected during codegen, which causes problems for the non-dmd backends and the interpreter as they will have to re-implement the missing check.

--

https://issues.dlang.org/show_bug.cgi?id=13810

--- Comment #2 from Steven Schveighoffer <schveiguy@yahoo.com> ---

OK, but do you agree with the assessment?

I think at the very least the error message should say ICE. Right now, it looks exactly the same as the error should look, with the addition of e2ir.

--

https://issues.dlang.org/show_bug.cgi?id=13810

--- Comment #3 from yebblies <yebblies@gmail.com> ---
(In reply to Steven Schveighoffer from comment #2)
> OK, but do you agree with the assessment?
> 
> I think at the very least the error message should say ICE. Right now, it looks exactly the same as the error should look, with the addition of e2ir.

Sure, if you can be bothered.  The important thing is that an assert is added, not just the error replaced with assert, because the error contains a lot more information, and they'll probably keep popping up for a while.

--

https://issues.dlang.org/show_bug.cgi?id=13810

--- Comment #4 from Steven Schveighoffer <schveiguy@yahoo.com> ---
Most definitely. What happens now is:

1. Error: e2ir: cannot convert ...
2. Person says, "Oh, OK" fixes code.
3. person *maybe* files a bug report about a "stray e2ir" message.

The error printout would have to be done before the assert, right now, it returns an error.

--

https://issues.dlang.org/show_bug.cgi?id=13810

--- Comment #5 from Steven Schveighoffer <schveiguy@yahoo.com> ---
Another case that probably would have slipped through if I hadn't known this :)

forum.dlang.org/post/foyqzngnnobtsjkurenm@forum.dlang.org

--

https://issues.dlang.org/show_bug.cgi?id=13810

Kenji Hara <k.hara.pg@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7514

--

https://issues.dlang.org/show_bug.cgi?id=13810
Issue 13810 depends on issue 7514, which changed state.

Issue 7514 Summary: [e2ir] Error in e2ir at dynamic array to static array cast https://issues.dlang.org/show_bug.cgi?id=7514

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--

https://issues.dlang.org/show_bug.cgi?id=13810

RazvanN <razvan.nitu1305@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |razvan.nitu1305@gmail.com

--- Comment #6 from RazvanN <razvan.nitu1305@gmail.com> ---
I cannot reproduce this. I tried the example in: forum.dlang.org/post/foyqzngnnobtsjkurenm@forum.dlang.org but I get a nice frontend error: Error: cannot cast expression `s` of type `S` to `void*`.

It seems that the error message was modified to not contain e2ir.

--

https://issues.dlang.org/show_bug.cgi?id=13810

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P3

--

https://issues.dlang.org/show_bug.cgi?id=13810

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
           Severity|minor                       |critical

--