[Issue 14790] coverage merge should detect changed source code

Jul 21, 2017

Jan 23, 2021

Jan 27, 2021

https://issues.dlang.org/show_bug.cgi?id=14790 --- Comment #1 from Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> --- Why not just compare the modification time of the source file with that of the existing coverage file? That would be simpler, and allow avoiding changing the format of the coverage file. --

https://issues.dlang.org/show_bug.cgi?id=14790 Dlang Bot <dlang-bot@dlang.rocks> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |pull --- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> --- @ljmf00 created dlang/druntime pull request #3341 "Fix Issue 14790: rt: cover: coverage merge should detect changed source code" fixing this issue: - Fix Issue 14790: rt: cover: coverage merge should detect changed source code Merging different versions of the same source file could lead to mismatched covered lines if the source code actually changes. Changing the .lst file format will open a huge breaking change and rely on timestamps is impractical. As an alternative to this, we can deeply compare the source code with generated .lst which also has a copy of the original source code. Signed-off-by: Luís Ferreira <contact@lsferreira.net> https://github.com/dlang/druntime/pull/3341 --

January 27, 2021

[Issue 14790] coverage merge should detect changed source code

Posted by Dlang Bot

Permalink

Dlang Bot

Permalink

https://issues.dlang.org/show_bug.cgi?id=14790

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/druntime pull request #3341 "Fix Issue 14790: rt: cover: coverage merge should detect changed source code" was merged into master:

- 6c7dc69cbe777eb5a8df20afc99220a1dcf0ae09 by Luís Ferreira:
  Fix Issue 14790: rt: cover: coverage merge should detect changed source code

  Merging different versions of the same source file could lead to mismatched
  covered lines if the source code actually changes. Changing the .lst file
  format will open a huge breaking change and rely on timestamps is
impractical.

  As an alternative to this, we can deeply compare the source code with
generated
  .lst which also has a copy of the original source code.

  Signed-off-by: Luís Ferreira <contact@lsferreira.net>

https://github.com/dlang/druntime/pull/3341

--

Forums