Thread overview
[Issue 15596] strip with delimiter?
Feb 28, 2016
b2.temp@gmx.com
Feb 28, 2016
Manu
Feb 28, 2016
Manu
Feb 28, 2016
b2.temp@gmx.com
Feb 28, 2016
ag0aep6g@gmail.com
Feb 28, 2016
ag0aep6g@gmail.com
Mar 21, 2020
Basile-z
February 28, 2016
https://issues.dlang.org/show_bug.cgi?id=15596

b2.temp@gmx.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b2.temp@gmx.com

--- Comment #1 from b2.temp@gmx.com ---
Since std.algorithm.mutation.strip/Left/Right do the job (http://dlang.org/phobos/std_algorithm_mutation.html#.strip) I think your report is invalid.

--
February 28, 2016
https://issues.dlang.org/show_bug.cgi?id=15596

--- Comment #2 from Manu <turkeyman@gmail.com> ---
(In reply to b2.temp from comment #1)
> Since std.algorithm.mutation.strip/Left/Right do the job (http://dlang.org/phobos/std_algorithm_mutation.html#.strip) I think your report is invalid.

"If it exists, it should be documented/linked"

--
February 28, 2016
https://issues.dlang.org/show_bug.cgi?id=15596

--- Comment #3 from Manu <turkeyman@gmail.com> ---
It is so hard to do string manipulation in phobos. Nobody I've encountered yet can find most of the functions, they're scattered among 4, 5, 6? modules. Unless you already know what the function names are, and where they are, how can people find what they want? They do an exhaustive search through a bunch of modules hoping to stumble upon it.

My feeling is that it wouldn't hurt for std.string to alias the hell out of other modules and make all the conventional string operations available in one place.

--
February 28, 2016
https://issues.dlang.org/show_bug.cgi?id=15596

--- Comment #4 from b2.temp@gmx.com ---
(In reply to Manu from comment #3)
> It is so hard to do string manipulation in phobos. Nobody I've encountered yet can find most of the functions, they're scattered among 4, 5, 6? modules. Unless you already know what the function names are, and where they are, how can people find what they want? They do an exhaustive search through a bunch of modules hoping to stumble upon it.
> 
> My feeling is that it wouldn't hurt for std.string to alias the hell out of other modules and make all the conventional string operations available in one place.

I agree, after reading your BR, I've myself done the error to write a popWhile() function using a predicate for my user lib after what I've remembered about algorithm.mutation, but it was too late...

Maybe a note in the std.string doc: "see also: for more generic strip funcyion..."

--
February 28, 2016
https://issues.dlang.org/show_bug.cgi?id=15596

ag0aep6g@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ag0aep6g@gmail.com

--- Comment #5 from ag0aep6g@gmail.com ---
(In reply to b2.temp from comment #4)
> Maybe a note in the std.string doc: "see also: for more generic strip funcyion..."

Already there: "There is a rich set of functions for string handling defined in other modules. Functions related to Unicode and ASCII are found in std.uni and std.ascii, respectively. Other functions that have a wider generality than just strings can be found in std.algorithm and std.range."

--
February 28, 2016
https://issues.dlang.org/show_bug.cgi?id=15596

--- Comment #6 from ag0aep6g@gmail.com ---
(In reply to ag0aep6g from comment #5)
> (In reply to b2.temp from comment #4)
> > Maybe a note in the std.string doc: "see also: for more generic strip funcyion..."
> 
> Already there: "There is a rich set of functions for string handling defined in other modules. Functions related to Unicode and ASCII are found in std.uni and std.ascii, respectively. Other functions that have a wider generality than just strings can be found in std.algorithm and std.range."

Whoops, you were talking about strip's docs specifically. Sorry for the noise.

--
February 29, 2016
https://issues.dlang.org/show_bug.cgi?id=15596

--- Comment #7 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/1d7920d38311c94a00389bafaf6299952848317e fixed issue 15596

https://github.com/D-Programming-Language/phobos/commit/098ce234cff2be2345d7f2f5f7022f74c2566a88 Merge pull request #4029 from BBasile/issue-15596

fixed issue 15596 - mention algorithm.mutation.stripXXX in std.string.stripXXX comments

--
February 29, 2016
https://issues.dlang.org/show_bug.cgi?id=15596

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--
March 21, 2020
https://issues.dlang.org/show_bug.cgi?id=15596

Basile-z <b2.temp@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|b2.temp@gmx.com             |

--