https://issues.dlang.org/show_bug.cgi?id=17482

Vladimir Panteleev <thecybershadow@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thecybershadow@gmail.com

--- Comment #1 from Vladimir Panteleev <thecybershadow@gmail.com> ---
Introduced in https://github.com/dlang/phobos/pull/5032

--

https://issues.dlang.org/show_bug.cgi?id=17482

David Marquant <davidma@live.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |davidma@live.de

--- Comment #2 from David Marquant <davidma@live.de> ---
Should it also be possible to assign values?

a = 11; // Isn't compiling as well

--

https://issues.dlang.org/show_bug.cgi?id=17482

Jonathan M Davis <issues.dlang@jmdavisProg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |issues.dlang@jmdavisProg.co
                   |                            |m

--- Comment #3 from Jonathan M Davis <issues.dlang@jmdavisProg.com> ---
(In reply to David Marquant from comment #2)
> Should it also be possible to assign values?
> 
> a = 11; // Isn't compiling as well

That did not compile with 2.073.2. So, regardless of what the desired behavior would be, the fact that that does not currently compile is not a regression.

Also, a better example of the regression would probably be something like

    Nullable!Variant a = Variant(12);
    assert(a != 11);

since the original example would actually fail an assertion otherwise - though the compilation error is the same.

--

https://issues.dlang.org/show_bug.cgi?id=17482

--- Comment #4 from Jonathan M Davis <issues.dlang@jmdavisProg.com> ---
https://github.com/dlang/phobos/pull/5541

--

https://issues.dlang.org/show_bug.cgi?id=17482

--- Comment #5 from github-bugzilla@puremagic.com ---
Commits pushed to stable at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/a7ea880eb24a36e09e50de7b8b32d941110aa630 Fix issue 17482: Fix Nullable!Variant equality checks.

https://github.com/dlang/phobos/commit/d07b10148dcfbf494a8f433ebf5646a4cb8d1b10 Merge pull request #5541 from jmdavis/issue_17482

Fix issue 17482: Fix Nullable!Variant equality checks. merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>

--

https://issues.dlang.org/show_bug.cgi?id=17482

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--

https://issues.dlang.org/show_bug.cgi?id=17482

--- Comment #6 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/a7ea880eb24a36e09e50de7b8b32d941110aa630 Fix issue 17482: Fix Nullable!Variant equality checks.

https://github.com/dlang/phobos/commit/d07b10148dcfbf494a8f433ebf5646a4cb8d1b10 Merge pull request #5541 from jmdavis/issue_17482

--

https://issues.dlang.org/show_bug.cgi?id=17482

--- Comment #7 from github-bugzilla@puremagic.com ---
Commits pushed to dmd-cxx at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/a7ea880eb24a36e09e50de7b8b32d941110aa630 Fix issue 17482: Fix Nullable!Variant equality checks.

https://github.com/dlang/phobos/commit/d07b10148dcfbf494a8f433ebf5646a4cb8d1b10 Merge pull request #5541 from jmdavis/issue_17482

--