Jump to page: 1 2
Thread overview
[Issue 18879] !is doesn't highlight correctly
May 19, 2018
Manu
May 19, 2018
Rainer Schuetze
May 19, 2018
Manu
May 20, 2018
Rainer Schuetze
May 20, 2018
Manu
May 20, 2018
Rainer Schuetze
May 20, 2018
Manu
May 21, 2018
Rainer Schuetze
May 21, 2018
Manu
May 21, 2018
Rainer Schuetze
May 22, 2018
Manu
May 22, 2018
Rainer Schuetze
Jun 10, 2018
Rainer Schuetze
May 19, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

Manu <turkeyman@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@puremagic.com        |r.sagitario@gmx.de

--
May 19, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

--- Comment #1 from Rainer Schuetze <r.sagitario@gmx.de> ---
`in` and `is` can be both operators or keywords depending on context, so different colors are expected. A preceding `!` is a separate token, i.e. there can be arbitrary spaces and comments in between.

This makes it pretty difficult for the lexer to highlight these correctly, but there is actually support for that by asking the parser. It seems this is broken, though.

--
May 19, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

--- Comment #2 from Manu <turkeyman@gmail.com> ---
I think they should both be highlighted when used both as operators and as keywords... so I don't think that distinction of case matters?

--
May 20, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

--- Comment #3 from Rainer Schuetze <r.sagitario@gmx.de> ---
The distinction matters if keywords and operators are supposed to show different colors.

--
May 20, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

--- Comment #4 from Manu <turkeyman@gmail.com> ---
Oh? I didn't know they did... they're all blue by default on my setup :)

--
May 20, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

--- Comment #5 from Rainer Schuetze <r.sagitario@gmx.de> ---
Actually never implemented in the "new" parser that is now used for about 5 years. I've added it now and preview should be available in a couple of minutes here: https://ci.appveyor.com/project/rainers/visuald

--
May 20, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

--- Comment #6 from Manu <turkeyman@gmail.com> ---
Added distinct colour, or fixes for !is/!in? :)

--
May 21, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

--- Comment #7 from Rainer Schuetze <r.sagitario@gmx.de> ---
> Added distinct colour, or fixes for !is/!in? :)

"in" and "is" use color "Visual D Operator" if used as operators, and color "Visual D Keyword" elsewhere.

--
May 21, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

--- Comment #8 from Manu <turkeyman@gmail.com> ---
Are they the same colour by default? :P

--
May 21, 2018
https://issues.dlang.org/show_bug.cgi?id=18879

--- Comment #9 from Rainer Schuetze <r.sagitario@gmx.de> ---
Keywords are blue by default, operators have the default color depending on the theme, so usually black or white.

--
« First   ‹ Prev
1 2