Thread overview
[Issue 19626] RedBlackTree of an enum fails in unittest mode
Jan 28, 2019
Victor Porton
Oct 16, 2019
berni44
Oct 16, 2019
Dlang Bot
Oct 18, 2019
Dlang Bot
January 28, 2019
https://issues.dlang.org/show_bug.cgi?id=19626

--- Comment #1 from Victor Porton <porton@narod.ru> ---
I forgot to say that it is DMD from Snap store on Ubuntu. 2.080.1

--
October 16, 2019
https://issues.dlang.org/show_bug.cgi?id=19626

berni44 <bugzilla@d-ecke.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla@d-ecke.de

--- Comment #2 from berni44 <bugzilla@d-ecke.de> ---
The bug can be found in

```
        static if (is(typeof(less) == string))
        {
            private enum doUnittest = isIntegral!T && (less == "a < b" || less
$
        }
        else
            enum doUnittest = false;

```

This is currently lines 750-755 in rbtree.d.

The check "isIntegral!T" is too weak. It's assumed, that this implies T contains the numbers from 1 to 5. The check should test, whether T contains these numbers.

--
October 16, 2019
https://issues.dlang.org/show_bug.cgi?id=19626

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
@berni44 created dlang/phobos pull request #7232 "Fix issue 19626 - RedBlackTree of an enum fails in unittest mode" fixing this issue:

- Fix issue 19626 - RedBlackTree of an enum fails in unittest mode

https://github.com/dlang/phobos/pull/7232

--
October 18, 2019
https://issues.dlang.org/show_bug.cgi?id=19626

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/phobos pull request #7232 "Fix issue 19626 - RedBlackTree of an enum fails in unittest mode" was merged into master:

- 79ef683f5ca423b1e62dfbe9267b563e988bf6c3 by Bernhard Seckinger:
  Fix issue 19626 - RedBlackTree of an enum fails in unittest mode

https://github.com/dlang/phobos/pull/7232

--