Jump to page: 1 2
Thread overview
[Issue 19731] auto struct methods whose address is taken don't test invariants
Mar 12, 2019
FeepingCreature
Mar 12, 2019
Basile-z
Mar 12, 2019
Basile-z
Mar 12, 2019
Dlang Bot
Mar 12, 2019
FeepingCreature
Mar 19, 2019
Dlang Bot
Mar 20, 2019
Dlang Bot
Aug 22, 2019
Iain Buclaw
Mar 21, 2020
Basile-z
Jun 29, 2021
Dlang Bot
Jun 29, 2021
Dlang Bot
Dec 17, 2022
Iain Buclaw
March 12, 2019
https://issues.dlang.org/show_bug.cgi?id=19731

--- Comment #1 from FeepingCreature <default_357-line@yahoo.de> ---
The combination of return type inference and taking the address forces DMD to run semantic3 where invariants are not yet available, and there's no way to say "we want to rerun semantic3 later, this is just a throwaway run".

--
March 12, 2019
https://issues.dlang.org/show_bug.cgi?id=19731

Basile-z <b2.temp@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b2.temp@gmx.com

--- Comment #2 from Basile-z <b2.temp@gmx.com> ---
I get an ICE with 2.085 or git ~master, run.dlang.io shows that in addition the ICE is a 2.077.z regression : https://run.dlang.io/is/sT3LTT

--
March 12, 2019
https://issues.dlang.org/show_bug.cgi?id=19731

--- Comment #3 from Basile-z <b2.temp@gmx.com> ---
My bad, it's the program that crashes, not dmd.

--
March 12, 2019
https://issues.dlang.org/show_bug.cgi?id=19731

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
@FeepingCreature created dlang/dmd pull request #9448 "Fix Issue 19731: throw away semantic3 run after return type inference to avoid missing invariants" fixing this issue:

- Fix Issue 19731: throw away semantic3 run after return type inference to avoid missing invariants

https://github.com/dlang/dmd/pull/9448

--
March 12, 2019
https://issues.dlang.org/show_bug.cgi?id=19731

--- Comment #5 from FeepingCreature <default_357-line@yahoo.de> ---
Okay, naively copying the method, running semantic3 and copying the type back does not work. Darn.

--
March 19, 2019
https://issues.dlang.org/show_bug.cgi?id=19731

--- Comment #6 from Dlang Bot <dlang-bot@dlang.rocks> ---
@RazvanN7 created dlang/dmd pull request #9467 "Fix Issue 19731 - auto struct methods whose address is taken don't test invariants" fixing this issue:

- Fix Issue 19731 - auto struct methods whose address is taken don't test invariants

https://github.com/dlang/dmd/pull/9467

--
March 20, 2019
https://issues.dlang.org/show_bug.cgi?id=19731

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #9467 "Fix Issue 19731 - auto struct methods whose address is taken don't test invariants" was merged into master:

- 3f52528e2dd40f116202dac1a8e4d34326c5bc3b by RazvanN7:
  Fix Issue 19731 - auto struct methods whose address is taken don't test
invariants

https://github.com/dlang/dmd/pull/9467

--
August 22, 2019
https://issues.dlang.org/show_bug.cgi?id=19731

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |ibuclaw@gdcproject.org
         Resolution|FIXED                       |---

--- Comment #8 from Iain Buclaw <ibuclaw@gdcproject.org> ---
Not fixed, as the bug still occurs if you compile the original test with -inline.

--
March 21, 2020
https://issues.dlang.org/show_bug.cgi?id=19731

Basile-z <b2.temp@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|b2.temp@gmx.com             |

--
June 29, 2021
https://issues.dlang.org/show_bug.cgi?id=19731

--- Comment #9 from Dlang Bot <dlang-bot@dlang.rocks> ---
@ibuclaw created dlang/dmd pull request #12783 "Revert "Fix Issue 19731 - auto struct methods whose address is taken don't test invariants"" mentioning this issue:

- Revert "Fix Issue 19731 - auto struct methods whose address is taken don't test invariants"

  This reverts commit 3f52528e2dd40f116202dac1a8e4d34326c5bc3b.

- test: Add regression tests to prevent breakages from fixing issue 19731

https://github.com/dlang/dmd/pull/12783

--
« First   ‹ Prev
1 2