Thread overview
[Issue 19740] Incorrect result of BigInt * BigInt
Mar 15, 2019
shove
Mar 15, 2019
Vladimir Panteleev
Mar 15, 2019
Simen Kjaeraas
Apr 18, 2019
Dlang Bot
Apr 20, 2019
shove
Apr 20, 2019
shove
Apr 20, 2019
apham
Apr 22, 2019
shove
March 15, 2019
https://issues.dlang.org/show_bug.cgi?id=19740

--- Comment #1 from shove <shove@163.com> ---
*** Issue 19739 has been marked as a duplicate of this issue. ***

--
March 15, 2019
https://issues.dlang.org/show_bug.cgi?id=19740

Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|x86                         |All
                 OS|Mac OS X                    |All
           Severity|enhancement                 |regression

--- Comment #2 from Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> ---
Regression, introduced in https://github.com/dlang/phobos/pull/5715

--
March 15, 2019
https://issues.dlang.org/show_bug.cgi?id=19740

--- Comment #3 from Simen Kjaeraas <simen.kjaras@gmail.com> ---
Simpler numbers demonstrating the same issue:

a =
241127122100380210001001124020210001001100000200003101000062221012075223052000021042250111300200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
b =
70020000000050041832100040114001011000002200722143200000014102001132330110410406020210020045721000160014200000101224530010000111021520000000012000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

Gives this result: 20000000001000003004000000120212100201000101001104000000010101000110200200000011011012010000010401100130020000041001002003000201010011124100010007220001471870730867315477594439355311694480948106052082286667289293612000561058058780959087178453367701487987704395450321365382687298205069039303066149854725490780100394780481552981630341618301661667399665774466232711496902529170260586056260480285668935821902794996073140454770961377671072882308072028734904868893098854793460359961494977497968219623527972133861047574462464

As we can see, the result should end in a number of 0s, but most definitely doesn't. There probably are even smaller numbers that exhibit the same issue.

--
April 18, 2019
https://issues.dlang.org/show_bug.cgi?id=19740

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
@shove70 created dlang/phobos pull request #6965 "Fix #19740: Incorrect result of BigInt * BigInt" fixing this issue:

- Fixes #19740: Incorrect result of BigInt * BigInt

  Fix bug #19740: Incorrect result of BigInt * BigInt.

https://github.com/dlang/phobos/pull/6965

--
April 20, 2019
https://issues.dlang.org/show_bug.cgi?id=19740

--- Comment #5 from shove <shove@163.com> ---
Reposition request resubmitted:

https://github.com/dlang/phobos/pull/6967

--
April 20, 2019
https://issues.dlang.org/show_bug.cgi?id=19740

--- Comment #6 from shove <shove@163.com> ---
(In reply to shove from comment #5)
> Reposition request resubmitted:
> 
> https://github.com/dlang/phobos/pull/6967

Reposition request resubmitted: https://github.com/dlang/phobos/pull/6969

--
April 20, 2019
https://issues.dlang.org/show_bug.cgi?id=19740

apham <apz28@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |apz28@hotmail.com

--- Comment #7 from apham <apz28@hotmail.com> ---
For original sample on 2019-03-15 10:58:22 UTC, .NET BigInteger gives below result. So Python seem wrong?

16883721089480688747229011802283756823349870758229387365814728471518346136944894862961035756393632618073413910091006778604956808730652275328822700182498926542563654351871390166691461743896850906716336187966456064270200717632811001335602400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

--
April 22, 2019
https://issues.dlang.org/show_bug.cgi?id=19740

shove <shove@163.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from shove <shove@163.com> ---
Fixed:

https://github.com/dlang/phobos/pull/6972

--