Thread overview
[Issue 19931] Missing error message when defining postblit, rvalue constructor and copy constructor
Jun 04, 2019
RazvanN
Jun 04, 2019
Simen Kjaeraas
Jun 18, 2019
Dlang Bot
Jun 25, 2019
Dlang Bot
June 04, 2019
https://issues.dlang.org/show_bug.cgi?id=19931

RazvanN <razvan.nitu1305@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |razvan.nitu1305@gmail.com
         Resolution|---                         |INVALID

--- Comment #1 from RazvanN <razvan.nitu1305@gmail.com> ---
This issue is invalid. Defining the postblit makes the compiler ignore the copy constructor, so the error goes away.

--
June 04, 2019
https://issues.dlang.org/show_bug.cgi?id=19931

Simen Kjaeraas <simen.kjaras@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |---

--- Comment #2 from Simen Kjaeraas <simen.kjaras@gmail.com> ---
Well, duh. What I'm saying it's just as wrong to define all three as it is to define two of them, and an error message should be present in both cases.

We could perfectly well define that if there's an rvalue constructor and a copy constructor, one of them takes precedence and the other is ignored. Instead, we have an error message. The fact that we allow all three to be defined with no error message is confusing, and leads the programmer to believe there are no errors even though his carefully-crafted copy constructor is ignored.

--
June 18, 2019
https://issues.dlang.org/show_bug.cgi?id=19931

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
@RazvanN7 created dlang/dmd pull request #10057 "Fix Issue 19931 - Missing error message when defining postblit, rvalue constructor and copy constructor" fixing this issue:

- Fix Issue 19931 - Missing error message when defining postblit, rvalue constructor and copy constructor

https://github.com/dlang/dmd/pull/10057

--
June 25, 2019
https://issues.dlang.org/show_bug.cgi?id=19931

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #10057 "Fix Issue 19931 - Missing error message when defining postblit, rvalue constructor and copy constructor" was merged into master:

- 3509d2f017e62e41443ca09f98e071799bd3fe50 by RazvanN7:
  Fix Issue 19931 - Missing error message when defining postblit, rvalue
constructor and copy constructor

https://github.com/dlang/dmd/pull/10057

--
November 28
https://issues.dlang.org/show_bug.cgi?id=19931

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://issues.dlang.org/sh
                   |                            |ow_bug.cgi?id=23036

--
November 28
https://issues.dlang.org/show_bug.cgi?id=19931

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla@digitalmars.com
           See Also|                            |https://issues.dlang.org/sh
                   |                            |ow_bug.cgi?id=19871

--