https://issues.dlang.org/show_bug.cgi?id=20602

johanengelen@weka.io changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code,
                   |                            |industry

--

https://issues.dlang.org/show_bug.cgi?id=20602

Basile-z <b2.temp@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b2.temp@gmx.com

--- Comment #1 from Basile-z <b2.temp@gmx.com> ---
The assertion looks irrelevant as the function it's located in is for the parameters.

It seems that remiving the assertion and returning early if tf.next is null and that fd.inferReturnType is false works. Those two conditions mean that like in your test case the return type is not valid and an error is already emitted for that.

--

https://issues.dlang.org/show_bug.cgi?id=20602

--- Comment #2 from Basile-z <b2.temp@gmx.com> ---
Created attachment 1782
  --> https://issues.dlang.org/attachment.cgi?id=1782&action=edit
fix, targeting stable

I have technical problems registering at GH si I cant propose the PR but the patch is verified to pass the test suite. Consider doing the remaining part of the job using

  $ git checkout -b issue-20602
  $ git am 0001-fix-issue-20602-REG2.086-ICE-on-wrong-code.patch

and then dont forget to target stable when using GH.

--

https://issues.dlang.org/show_bug.cgi?id=20602

Basile-z <b2.temp@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--

https://issues.dlang.org/show_bug.cgi?id=20602

--- Comment #3 from johanengelen@weka.io ---
Why "worksforme"? The crash is easily reproducible on e.g. godbolt.org.
Do you instead mean that this has been fixed accidentally upstream? From which
version?

--