Thread overview
[Issue 21363] [REG2.094] Implementation of core.bitop.ror(x,0) is using UB
May 01, 2021
Dlang Bot
May 02, 2021
Dlang Bot
May 12, 2021
Dlang Bot
November 04, 2020
https://issues.dlang.org/show_bug.cgi?id=21363

johanengelen@weka.io changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |industry

--
May 01, 2021
https://issues.dlang.org/show_bug.cgi?id=21363

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #1 from Dlang Bot <dlang-bot@dlang.rocks> ---
@Chigusa0w0 created dlang/druntime pull request #3457 "Fix Issue 21363 - [REG2.094] Implementation of core.bitop.ror(x,0) is…" fixing this issue:

- Fix Issue 21363 - [REG2.094] Implementation of core.bitop.ror(x,0) is using
UB

  This is a quick fix to Issue 21363. When `count` is set to `0`, `T.sizeof * 8
- count` will always be `T.sizeof * 8` therefore fails compiler check here:

https://github.com/dlang/dmd/blob/81f9f57257da8733cf741355524bb8a3ec9c45ce/src/dmd/dinterpret.d#L3018-L3024

https://github.com/dlang/druntime/pull/3457

--
May 02, 2021
https://issues.dlang.org/show_bug.cgi?id=21363

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/druntime pull request #3457 "Fix Issue 21363 - [REG2.094] Implementation of core.bitop.ror(x,0) is…" was merged into stable:

- e6619623a8205a33251ebc5f64e34aedc1b2189c by Chigusa0w0:
  Fix Issue 21363 - [REG2.094] Implementation of core.bitop.ror(x,0) is using
UB

  This is a quick fix to Issue 21363. When `count` is set to `0`, `T.sizeof * 8
- count` will always be `T.sizeof * 8` therefore fails compiler check here:

https://github.com/dlang/dmd/blob/81f9f57257da8733cf741355524bb8a3ec9c45ce/src/dmd/dinterpret.d#L3018-L3024

https://github.com/dlang/druntime/pull/3457

--
May 12, 2021
https://issues.dlang.org/show_bug.cgi?id=21363

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/druntime pull request #3468 "merge stable" was merged into master:

- fdda230e2a41ba4723a424f31cf29b99e705b4ec by Chigusa0w0:
  Fix Issue 21363 - [REG2.094] Implementation of core.bitop.ror(x,0) is using
UB

  This is a quick fix to Issue 21363. When `count` is set to `0`, `T.sizeof * 8
- count` will always be `T.sizeof * 8` therefore fails compiler check here:

https://github.com/dlang/dmd/blob/81f9f57257da8733cf741355524bb8a3ec9c45ce/src/dmd/dinterpret.d#L3018-L3024

https://github.com/dlang/druntime/pull/3468

--