Thread overview
[Issue 22472] Invalid error message for `void` return from non-`void` functions
Nov 03, 2021
Dlang Bot
Nov 03, 2021
Dlang Bot
Nov 08, 2021
Dlang Bot
November 03, 2021
https://issues.dlang.org/show_bug.cgi?id=22472

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #1 from Dlang Bot <dlang-bot@dlang.rocks> ---
@MoonlightSentinel created dlang/dmd pull request #13258 "Fix 22472 - Correct error message for invalid `void` return" fixing this issue:

- Fix 22472 - Correct error message for invalid `void` return

  The old error message (`return expression expected`) ignored the
  possibility that `void` and `noreturn` expressions are moved into `e0`.
  This caused misleading error messages when errors are detected after
  the move, claiming that the expression found in the source code is
  missing.

  Small improvement to #13135 because this is more likely to happen for
  `noreturn` functions.

https://github.com/dlang/dmd/pull/13258

--
November 03, 2021
https://issues.dlang.org/show_bug.cgi?id=22472

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #13258 "Fix 22472 - Correct error message for invalid `void` return" was merged into stable:

- 2b5dce74113a2be5555d2f843a9cf4e5f5224c3b by MoonlightSentinel:
  Fix 22472 - Correct error message for invalid `void` return

  The old error message (`return expression expected`) ignored the
  possibility that `void` and `noreturn` expressions are moved into `e0`.
  This caused misleading error messages when errors are detected after
  the move, claiming that the expression found in the source code is
  missing.

  Small improvement to #13135 because this is more likely to happen for
  `noreturn` functions.

https://github.com/dlang/dmd/pull/13258

--
November 08, 2021
https://issues.dlang.org/show_bug.cgi?id=22472

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #13279 "Merge `stable` into `master`" was merged into master:

- b1429054c103b4be759d6c9ca671b5268bdaa0de by MoonlightSentinel:
  Fix 22472 - Correct error message for invalid `void` return

  The old error message (`return expression expected`) ignored the
  possibility that `void` and `noreturn` expressions are moved into `e0`.
  This caused misleading error messages when errors are detected after
  the move, claiming that the expression found in the source code is
  missing.

  Small improvement to #13135 because this is more likely to happen for
  `noreturn` functions.

https://github.com/dlang/dmd/pull/13279

--