Thread overview
[Issue 22549] importC: float literal should support leading zero
Nov 27, 2021
Basile-z
Nov 27, 2021
bachmeil@yahoo.com
Nov 29, 2021
Dlang Bot
Nov 30, 2021
Basile-z
Nov 30, 2021
Basile-z
Dec 01, 2021
Dlang Bot
Dec 14, 2021
Dlang Bot
Mar 18, 2022
8jst@queensu.ca
November 27, 2021
https://issues.dlang.org/show_bug.cgi?id=22549

Basile-z <b2.temp@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ImportC

--
November 27, 2021
https://issues.dlang.org/show_bug.cgi?id=22549

bachmeil@yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bachmeil@yahoo.com

--- Comment #1 from bachmeil@yahoo.com ---
This is not just an ImportC bug. DMD does the same with D code. According to run.dlang.io, this code

void main() {
    double x = 08.4;
}

results in

Up to      2.064  : Failure with output: onlineapp.d(3): Error: semicolon
expected, not '8.4'
2.065.0 to 2.081.2: Success and no output
           2.082.1: Failure with output: onlineapp.d(3): Error: radix 8 digit
expected, not `8`
Since      2.083.1: Failure with output: onlineapp.d(3): Error: octal digit
expected, not `8`

Something changed in 2.082.1 and 2.083.1 to cause a double with leading zero to be detected as octal.

--
November 29, 2021
https://issues.dlang.org/show_bug.cgi?id=22549

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> ---
@dkorpel created dlang/dmd pull request #13371 "Fix issue 22549 - float literal should support leading zero" fixing this issue:

- Fix issue 22549 - float literal should support leading zero

https://github.com/dlang/dmd/pull/13371

--
November 30, 2021
https://issues.dlang.org/show_bug.cgi?id=22549

Basile-z <b2.temp@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b2.temp@gmx.com

--- Comment #3 from Basile-z <b2.temp@gmx.com> ---
the fix affects the specs https://dlang.org/spec/lex.html#LeadingDecimal, hence everything that would be based on them.

I suggest to only allow leading zeroes in importC mode.

--
November 30, 2021
https://issues.dlang.org/show_bug.cgi?id=22549

--- Comment #4 from Basile-z <b2.temp@gmx.com> ---
also no reason to target stable(In reply to Basile-z from comment #3)
> the fix affects the specs https://dlang.org/spec/lex.html#LeadingDecimal, hence everything that would be based on them.
> 
> I suggest to only allow leading zeroes in importC mode.

sorry about that comment, as explained here https://issues.dlang.org/show_bug.cgi?id=3251, that is not required.

--
December 01, 2021
https://issues.dlang.org/show_bug.cgi?id=22549

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #13371 "Fix issue 22549 - float literal should support leading zero" was merged into stable:

- 8a7b98b6228b3ac4d064d95f4a530130fb5824e6 by dkorpel:
  Fix issue 22549 - float literal should support leading zero

https://github.com/dlang/dmd/pull/13371

--
December 14, 2021
https://issues.dlang.org/show_bug.cgi?id=22549

--- Comment #6 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #13421 "merge stable" was merged into master:

- 6931b4e621057e95198670d78e663e530850c789 by dkorpel:
  Fix issue 22549 - float literal should support leading zero

https://github.com/dlang/dmd/pull/13421

--
March 18, 2022
https://issues.dlang.org/show_bug.cgi?id=22549

8jst@queensu.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |8jst@queensu.ca

--- Comment #7 from 8jst@queensu.ca ---
*** Issue 22882 has been marked as a duplicate of this issue. ***

--