Jump to page: 1 2
Thread overview
[Issue 22646] [REG2.099] CT bounds checking ignores short circuit evaluation
Jan 03, 2022
Vladimir Panteleev
Jan 04, 2022
Basile-z
Jan 18, 2022
Dlang Bot
Jan 18, 2022
Dlang Bot
Jan 18, 2022
Basile-z
Jan 18, 2022
Basile-z
Dec 20, 2022
Dlang Bot
Dec 21, 2022
Dlang Bot
Jan 01, 2023
Dlang Bot
January 03, 2022
https://issues.dlang.org/show_bug.cgi?id=22646

--- Comment #1 from Vladimir Panteleev <dlang-bugzilla@thecybershadow.net> ---
Worth mentioning that this code also did not work in 2.078.0 through 2.080.0.

Broken in:

https://github.com/dlang/dmd/pull/7225

Fixed in:

https://github.com/dlang/dmd/pull/8261

(and again broken in https://github.com/dlang/dmd/pull/13169)

--
January 04, 2022
https://issues.dlang.org/show_bug.cgi?id=22646

Basile-z <b2.temp@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b2.temp@gmx.com
           See Also|                            |https://issues.dlang.org/sh
                   |                            |ow_bug.cgi?id=18115

--- Comment #2 from Basile-z <b2.temp@gmx.com> ---
you might be interested by the explanations in the comments of https://issues.dlang.org/show_bug.cgi?id=18115. This was identical issue but with &&.

--
January 18, 2022
https://issues.dlang.org/show_bug.cgi?id=22646

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
@RazvanN7 created dlang/dmd pull request #13542 "Fix Issue 22646 - [REG2.099] CT bounds checking ignores short circuit evaluation" fixing this issue:

- Fix Issue 22646 - [REG2.099] CT bounds checking ignores short circuit evaluation

https://github.com/dlang/dmd/pull/13542

--
January 18, 2022
https://issues.dlang.org/show_bug.cgi?id=22646

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #13542 "Fix Issue 22646 - [REG2.099] CT bounds checking ignores short circuit evaluation" was merged into master:

- 8f193572300fd23c2e46459ee333cfc8cfd37652 by RazvanN7:
  Fix Issue 22646 - [REG2.099] CT bounds checking ignores short circuit
evaluation

https://github.com/dlang/dmd/pull/13542

--
January 18, 2022
https://issues.dlang.org/show_bug.cgi?id=22646

moonlightsentinel@disroot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |moonlightsentinel@disroot.o
                   |                            |rg
         Resolution|FIXED                       |---

--- Comment #5 from moonlightsentinel@disroot.org ---
The patch does not work for static arrays that are also affected by this regression:

static template Bug(T, const T name)
{
    enum bool ok = name.length < 3 || name[0..3] != "pad";
}

pragma(msg, Bug!(char[1], "x").ok);

--
January 18, 2022
https://issues.dlang.org/show_bug.cgi?id=22646

--- Comment #6 from Basile-z <b2.temp@gmx.com> ---
that PR looks like a bad workaround.

--
January 18, 2022
https://issues.dlang.org/show_bug.cgi?id=22646

--- Comment #7 from Basile-z <b2.temp@gmx.com> ---
the real bug is in optimize(), where D does const fold

--
December 20, 2022
https://issues.dlang.org/show_bug.cgi?id=22646

--- Comment #8 from Dlang Bot <dlang-bot@dlang.rocks> ---
@ibuclaw created dlang/dmd pull request #14722 "fix Issue 22646 - [REG2.099] CT bounds checking ignores short circuit evaluation" fixing this issue:

- fix Issue 22646 - [REG2.099] CT bounds checking ignores short circuit evaluation

https://github.com/dlang/dmd/pull/14722

--
December 21, 2022
https://issues.dlang.org/show_bug.cgi?id=22646

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #14722 "fix Issue 22646 - [REG2.099] CT bounds checking ignores short circuit evaluation" was merged into stable:

- 59d7cb9667a992c187e121615a224ba9b30d5f7b by Iain Buclaw:
  fix Issue 22646 - [REG2.099] CT bounds checking ignores short circuit
evaluation

https://github.com/dlang/dmd/pull/14722

--
January 01, 2023
https://issues.dlang.org/show_bug.cgi?id=22646

--- Comment #10 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #14765 "merge stable" was merged into master:

- 57874f498053152ec18e4ebe5be95337ebf83b3b by Iain Buclaw:
  fix Issue 22646 - [REG2.099] CT bounds checking ignores short circuit
evaluation

https://github.com/dlang/dmd/pull/14765

--
« First   ‹ Prev
1 2