| Thread overview | |||||
|---|---|---|---|---|---|
|
March 12, 2022 [Issue 22879] super call ignores overload in mixin | ||||
|---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=22879 Adam D. Ruppe <destructionator@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |destructionator@gmail.com --- Comment #1 from Adam D. Ruppe <destructionator@gmail.com> --- The presence of that alias complicates things. A template mixin work by name and thus doesn't bring in something that's already there. So with the mixin, `f` is already there, meaning the mixin template's one is overridden by that. That `B.f` function is never part of the virtual tree at all, so `super` here isn't wrong. I expect the alias is there in the real thing because of overloading arguments in the real thing right? What you actually want to do is to alias BOTH sets together, not just one: ``` class B: A { alias f = A.f; alias f = x.f; mixin X!() x; } ``` This combines the overloads of A with the overloads of X, thus allowing the override to take effect. This should probably be closed as not a bug, since it is working as designed... -- | ||||
March 12, 2022 [Issue 22879] super call ignores overload in mixin | ||||
|---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=22879 --- Comment #2 from Tim <tim.dlang@t-online.de> --- (In reply to Adam D. Ruppe from comment #1) > I expect the alias is there in the real thing because of overloading arguments in the real thing right? Yes, the class ParseTimeTransitiveVisitor overrides some overloads using a template mixins and uses an alias for other overloads: https://github.com/dlang/dmd/blob/cbba5f41a32cfed7f22a213d537f8e2dee0b92f7/src/dmd/transitivevisitor.d#L17-L21 > > What you actually want to do is to alias BOTH sets together, not just one: > > ``` > class B: A > { > alias f = A.f; > alias f = x.f; > mixin X!() x; > } > ``` > > This combines the overloads of A with the overloads of X, thus allowing the override to take effect. Thanks, this works. > > This should probably be closed as not a bug, since it is working as designed... I have now seen, that the same problem was already fixed with the same workaround for SemanticTimeTransitiveVisitor: https://github.com/dlang/dmd/pull/7635 I will close this as a duplicate of issue 18132, which was referenced in the pull request. -- | ||||
March 12, 2022 [Issue 22879] super call ignores overload in mixin | ||||
|---|---|---|---|---|
| ||||
https://issues.dlang.org/show_bug.cgi?id=22879 Tim <tim.dlang@t-online.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Tim <tim.dlang@t-online.de> --- *** This issue has been marked as a duplicate of issue 18132 *** -- | ||||
Copyright © 1999-2021 by the D Language Foundation
Permalink
Reply