http://d.puremagic.com/issues/show_bug.cgi?id=7515



--- Comment #10 from Jonathan M Davis <jmdavisProg@gmx.com> 2012-03-11 15:33:12 PDT ---
The fact that the version that's going away deals with a 256 element array and therefore just so happens to work with Extended ASCII may be enough to justify just making the new one do that as well, but I honestly, don't see Extended ASCII as much of an argument when none of the other functions support it and are likely to blow up if you use it. The general idea with Phobos functions is that you will convert any non-unicode strings that you have to unicode before processing them, and then when you're done, if you want a different encoding, you convert it before writing it out to file or whatever you're doing with it. It's really not the intention that Phobos in general will support non-unicode encodings. Dealing with unicode is already complicated enough.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=7515



--- Comment #11 from Jonathan M Davis <jmdavisProg@gmx.com> 2012-05-28 15:41:22 PDT ---
Okay. After some rethinking the issue, I've closed the old pull request and created a new one:

https://github.com/D-Programming-Language/phobos/pull/609

It retains the ability to handle 256 code units rather than the 128 that ASCII actually uses. What finally convinced me was the fact that if it takes the full 256 code units, then it could operate on full-on UTF-8 strings, replacing the ASCII characters and leaving the unicode ones alone.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=7515



--- Comment #12 from bearophile_hugs@eml.cc 2012-05-28 17:13:48 PDT ---
(In reply to comment #11)

> It retains the ability to handle 256 code units rather than the 128 that ASCII actually uses.

Thank you :-)

Please take also a look at Issue 8141

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=7515



--- Comment #13 from github-bugzilla@puremagic.com 2012-06-10 20:32:42 PDT ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/08acc16b830b35572e6ea004d936a7b2522801b8 Fix issue 7515

I created an adjusted version of translate which is ASCII-only and renamed maketrans to makeTrans with some minor changes. Instead of deprecating the old translate and maketrans, maketrans is now a deprecated alias of makeTrans, and the new ASCII-only translate should be compatible with the old one.

https://github.com/D-Programming-Language/phobos/commit/94c06fb2469c0d98be842438b749e61571b42fe3 Merge pull request #609 from jmdavis/7515

Fix issue 7515

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=7515


Jonathan M Davis <jmdavisProg@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------