January 23, 2015
On 1/6/15 8:51 AM, Robert burner Schadek wrote:
> recent updates:
> * Martins CT log function disabling (thanks Martin)
> * new thread local indirection Logger between free standing log
> functions and program global Logger
> * more documentation
> * some @trusted have been remove (thanks Dicebot)
> * local imports
>
> please review

I propose we pull this in today and make it available for 2.067 as std.experimental.logger.

We've been through a number of iterations with this and the best way to move forward is to accumulate a bit of real-world experience with it. Since we're deploying to std.experimental there is understanding breaking changes are still possible.

Dicebot, as the review manager you get to decide. What do you say?


Andrei
January 24, 2015
On Friday, 23 January 2015 at 20:24:54 UTC, Andrei Alexandrescu wrote:
> On 1/6/15 8:51 AM, Robert burner Schadek wrote:
>> recent updates:
>> * Martins CT log function disabling (thanks Martin)
>> * new thread local indirection Logger between free standing log
>> functions and program global Logger
>> * more documentation
>> * some @trusted have been remove (thanks Dicebot)
>> * local imports
>>
>> please review
>
> I propose we pull this in today and make it available for 2.067 as std.experimental.logger.
>
> We've been through a number of iterations with this and the best way to move forward is to accumulate a bit of real-world experience with it. Since we're deploying to std.experimental there is understanding breaking changes are still possible.
>
> Dicebot, as the review manager you get to decide. What do you say?
>
>
> Andrei

+1
January 24, 2015
On Friday, 23 January 2015 at 20:24:54 UTC, Andrei Alexandrescu wrote:
>
> I propose we pull this in today and make it available for 2.067 as std.experimental.logger.
>
> We've been through a number of iterations with this and the best way to move forward is to accumulate a bit of real-world experience with it. Since we're deploying to std.experimental there is understanding breaking changes are still possible.
>
> Dicebot, as the review manager you get to decide. What do you say?
>
>
> Andrei

Agreed. Logger is such a subjective module. No matter what you do, there is a guarantee that people will have something more they desire. D badly needs at least some basic logging though, and if people need more complex features, they then do their own. But so long as the default is fine for most people, which this looks like it should be, then having it is a valuable addition; it's an important module. At this point, the most useful next step would be experience as you mention. There might be some improvements desired before full Phobos integration, such as cleaning up the documentation for some symbols (particularly the 12 'alias trace/info/etc(f)') by using version(D_Doc) to hide part of it, but that's certainly not necessary for std.experimental inclusion.
January 24, 2015
On Friday, 23 January 2015 at 20:24:54 UTC, Andrei Alexandrescu wrote:
> I propose we pull this in today and make it available for 2.067 as std.experimental.logger.
>
> We've been through a number of iterations with this and the best way to move forward is to accumulate a bit of real-world experience with it. Since we're deploying to std.experimental there is understanding breaking changes are still possible.
>
> Dicebot, as the review manager you get to decide. What do you say?
>
>
> Andrei

I was in favor of merging it long time ago. It is _your_ defintion of being good enough for std.experimental I am trying to comply now ;) Merging it right now and continuing with fixes as follow-up pull requests is a good idea but you must understand that chance of breaking chance is very high.

That said I have just now tested last version (with thread-local log support) and apart from one bug found it works as expected. Assuming you give your LGTM I will merge the PR as soon as this bug is fixed and PR is rebased/squashed.
January 24, 2015
On 1/24/15 7:06 AM, Dicebot wrote:
> On Friday, 23 January 2015 at 20:24:54 UTC, Andrei Alexandrescu wrote:
>> I propose we pull this in today and make it available for 2.067 as
>> std.experimental.logger.
>>
>> We've been through a number of iterations with this and the best way
>> to move forward is to accumulate a bit of real-world experience with
>> it. Since we're deploying to std.experimental there is understanding
>> breaking changes are still possible.
>>
>> Dicebot, as the review manager you get to decide. What do you say?
>>
>>
>> Andrei
>
> I was in favor of merging it long time ago. It is _your_ defintion of
> being good enough for std.experimental I am trying to comply now ;)
> Merging it right now and continuing with fixes as follow-up pull
> requests is a good idea but you must understand that chance of breaking
> chance is very high.
>
> That said I have just now tested last version (with thread-local log
> support) and apart from one bug found it works as expected. Assuming you
> give your LGTM I will merge the PR as soon as this bug is fixed and PR
> is rebased/squashed.

Fantastic. Thanks! Robert, please mind the bug and then Dicebot please do the merge honors.

Thanks Robert for this work, Dicebot for overseeing the review process, and everybody in the community who provided feedback and ideas.


Andrei

January 24, 2015
I will fix the bug this weekend and rebase to upstream/master. The alias doc has seen some updates this week (please check the rebuild gh-pages, links are in the PR description)


January 25, 2015
On 2015-01-24 18:45, Robert burner Schadek wrote:
> I will fix the bug this weekend and rebase to upstream/master. The alias
> doc has seen some updates this week (please check the rebuild gh-pages,
> links are in the PR description)

Is the generated documentation for package module available somewhere? This [1] is empty.

[1] http://burner.github.io/phobos/phobos-prerelease/std_experimental_logger_package.html

-- 
/Jacob Carlborg
January 25, 2015
On Sunday, 25 January 2015 at 09:43:36 UTC, Jacob Carlborg wrote:
> On 2015-01-24 18:45, Robert burner Schadek wrote:
>> I will fix the bug this weekend and rebase to upstream/master. The alias
>> doc has seen some updates this week (please check the rebuild gh-pages,
>> links are in the PR description)
>
> Is the generated documentation for package module available somewhere? This [1] is empty.
>
> [1] http://burner.github.io/phobos/phobos-prerelease/std_experimental_logger_package.html

fixed
January 25, 2015
On 25.01.15 15:06, Robert burner Schadek wrote:
> On Sunday, 25 January 2015 at 09:43:36 UTC, Jacob Carlborg wrote:
>>
>> Is the generated documentation for package module available somewhere? This [1] is empty.
>>
>> [1] http://burner.github.io/phobos/phobos-prerelease/std_experimental_logger_package.html
>>
> 
> fixed

Interface looks to me convenient.

Is there a way to log to buffer or a like?
January 25, 2015
On Sunday, 25 January 2015 at 14:50:46 UTC, zeljkog wrote:
> Is there a way to log to buffer or a like?

By implementing own Logger. Idea is that std.experimental.logger provides only basic building blocks and defines API - any more advanced logger implementations can be provided via dub packages.