Request d.vim testing

Hello Vim users, Sadly I don't have a good set of unittests for highlighting. I've made some changes and think that it will be good to have them part of vim 7.4 I'm requesting that you check that the new file has not butchered highlighting for you. https://github.com/JesseKPhillips/d.vim * ASM blocks highlight comments * in/out contracts no longer highlighted as storage class * If a module name is the same as a keyword it will not be highlighted on module declaration or import. * scope highlights as a statement, as a storage class in parameter list * pragma will highlight known commands (lib,msg)

On Saturday, May 18, 2013 20:12:16 Jesse Phillips wrote: > Hello Vim users, > > Sadly I don't have a good set of unittests for highlighting. I've made some changes and think that it will be good to have them part of vim 7.4 > > I'm requesting that you check that the new file has not butchered highlighting for you. > > https://github.com/JesseKPhillips/d.vim > > * ASM blocks highlight comments > * in/out contracts no longer highlighted as storage class > * If a module name is the same as a keyword it will not be > highlighted on module declaration or import. > * scope highlights as a statement, as a storage class in > parameter list > * pragma will highlight known commands (lib,msg) Using this new d.vim file, I get whole piles of errors just opening an empty .di file - starting off with Error detected while processing /home/jmdavis/.vim/syntax/d.vim line 4: E477: No ! allowed: <!DOCTYPE html> line 5: E488: Trailing characters: <html> and so on and so forth. I'm using vim 7.3 on Arch Linux. Maybe I need 7.4 for it to work? Or maybe something else in my setup is messed up. I only grabbed the syntax/d.vim file from your repo, since I don't know what the others are and don't currently have anything like them, so that may or may not be a factor. But based on the errors, it looks like my local version of vim just plain can't handle the new d.vim syntax file. - Jonathan M Davis

May 20, 2013

Re: Request d.vim testing

Posted by Idan Arye
in reply to Jonathan M Davis

Permalink

Idan Arye

Posted in reply to Jonathan M Davis

Permalink

On Monday, 20 May 2013 at 02:24:44 UTC, Jonathan M Davis wrote:
> On Saturday, May 18, 2013 20:12:16 Jesse Phillips wrote:
>> Hello Vim users,
>> 
>> Sadly I don't have a good set of unittests for highlighting. I've
>> made some changes and think that it will be good to have them
>> part of vim 7.4
>> 
>> I'm requesting that you check that the new file has not butchered
>> highlighting for you.
>> 
>> https://github.com/JesseKPhillips/d.vim
>> 
>> * ASM blocks highlight comments
>> * in/out contracts no longer highlighted as storage class
>> * If a module name is the same as a keyword it will not be
>> highlighted on module declaration or import.
>> * scope highlights as a statement, as a storage class in
>> parameter list
>> * pragma will highlight known commands (lib,msg)
>
> Using this new d.vim file, I get whole piles of errors just opening an empty
> .di file - starting off with
>
> Error detected while processing /home/jmdavis/.vim/syntax/d.vim
> line 4:
> E477: No ! allowed: <!DOCTYPE html>
> line 5:
> E488: Trailing characters: <html>
>
> and so on and so forth. I'm using vim 7.3 on Arch Linux. Maybe I need 7.4 for
> it to work? Or maybe something else in my setup is messed up. I only grabbed
> the syntax/d.vim file from your repo, since I don't know what the others are
> and don't currently have anything like them, so that may or may not be a
> factor. But based on the errors, it looks like my local version of vim just
> plain can't handle the new d.vim syntax file.
>
> - Jonathan M Davis

Are you sure you downloaded it correctly? From the error message you got, it seems like you have downloaded the source of the GitHub page that displays the `syntax/d.vim` file.

On Saturday, 18 May 2013 at 18:12:17 UTC, Jesse Phillips wrote: > Hello Vim users, > > Sadly I don't have a good set of unittests for highlighting. I've made some changes and think that it will be good to have them part of vim 7.4 Here's the test file for D highlighting for the colorer library: https://svn.code.sf.net/p/colorer/svn/trunk/schemes/hrc/test/other/d-sample.d Hope this helps.

On Monday, May 20, 2013 10:04:22 Idan Arye wrote: > Are you sure you downloaded it correctly? From the error message you got, it seems like you have downloaded the source of the GitHub page that displays the `syntax/d.vim` file. LOL. Yeah, that looks like it's what I did. I think that I got it correctly now though, and it seems to work (or at least, it works well enough that I can open .d files using it now without any errors - I haven't messed around with it enough yet to determine if it's having any further issues). - Jonathan M Davis

On 20 May 2013 10:08, Vladimir Panteleev <vladimir@thecybershadow.net>wrote: > On Saturday, 18 May 2013 at 18:12:17 UTC, Jesse Phillips wrote: > >> Hello Vim users, >> >> Sadly I don't have a good set of unittests for highlighting. I've made some changes and think that it will be good to have them part of vim 7.4 >> > > Here's the test file for D highlighting for the colorer library: > > https://svn.code.sf.net/p/**colorer/svn/trunk/schemes/hrc/** test/other/d-sample.d<https://svn.code.sf.net/p/colorer/svn/trunk/schemes/hrc/test/other/d-sample.d> > > Hope this helps. > Thanks Vladimir, I'll test this against cgdb as well. =) -- Iain Buclaw *(p < e ? p++ : p) = (c & 0x0f) + '0';

On Saturday, 18 May 2013 at 18:12:17 UTC, Jesse Phillips wrote: > Hello Vim users, > > Sadly I don't have a good set of unittests for highlighting. I've made some changes and think that it will be good to have them part of vim 7.4 > > I'm requesting that you check that the new file has not butchered highlighting for you. Here are the results on my Vim 7.3 on Linux: http://postimg.org/image/cgtkbhr0t/ hybrid.vim was OK so I didn't put it in the screenshot(also I couldn't fit them all to screen height...) > * ASM blocks highlight comments /* */ comments are good, but /+ +/ comments are not ended. This is also true outside ASM blocks. > * in/out contracts no longer highlighted as storage class Works > * If a module name is the same as a keyword it will not be highlighted on module declaration or import. Made worse - in the original syntax `assert` was not highlighted when used as module name. `string` and `void` are still highlighted as module names. > * scope highlights as a statement, as a storage class in parameter list Works > * pragma will highlight known commands (lib,msg) Doesn't work

On 20 May 2013 10:51, Iain Buclaw <ibuclaw@ubuntu.com> wrote: > On 20 May 2013 10:08, Vladimir Panteleev <vladimir@thecybershadow.net> wrote: >> >> On Saturday, 18 May 2013 at 18:12:17 UTC, Jesse Phillips wrote: >>> >>> Hello Vim users, >>> >>> Sadly I don't have a good set of unittests for highlighting. I've made some changes and think that it will be good to have them part of vim 7.4 >> >> >> Here's the test file for D highlighting for the colorer library: >> >> >> https://svn.code.sf.net/p/colorer/svn/trunk/schemes/hrc/test/other/d-sample.d >> >> Hope this helps. > > > > Thanks Vladimir, I'll test this against cgdb as well. =) > First question that I have: Does 'Object' *need* to be syntax highlighted? Regards -- Iain Buclaw *(p < e ? p++ : p) = (c & 0x0f) + '0';

Forums