| Thread overview | |||||
|---|---|---|---|---|---|
|
January 21, 2008 Frontend review process suggestion | ||||
|---|---|---|---|---|
| ||||
Whenever something changes in the source code at work we get an email detailing the file changes. This encourages a form of code review because it encourages others to check my changes. I could always go to perforce to do this but that is not right in my face all the time. Since the DMD frontend is open source I was thinking that it would be cool if the DMD changelog included a diff of the changed frontend files since the last one. Users could click on a link and see what changes where made. How this would look I don't know. I don't even know how you'd set this up. I know there's some tools out there that can spit out HTML diffs. Also if you like this idea, what would be a practical way for Walter to set this up. -Joel | ||||
January 21, 2008 Re: Frontend review process suggestion | ||||
|---|---|---|---|---|
| ||||
Posted in reply to janderson | "janderson" <askme@me.com> wrote in message news:fn1d9h$28r7$1@digitalmars.com... > Whenever something changes in the source code at work we get an email detailing the file changes. This encourages a form of code review because it encourages others to check my changes. I could always go to perforce to do this but that is not right in my face all the time. > > Since the DMD frontend is open source I was thinking that it would be cool if the DMD changelog included a diff of the changed frontend files since the last one. Users could click on a link and see what changes where made. How this would look I don't know. I don't even know how you'd set this up. I know there's some tools out there that can spit out HTML diffs. > > Also if you like this idea, what would be a practical way for Walter to set this up. > > -Joel Well, phobos is already hosted on dsource, which provides built-in integration with the subversion repo, and will auto-generate pretty HTML diffs. The FE source would just have to be added. | |||
January 21, 2008 Re: Frontend review process suggestion | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Jarrett Billingsley | 在 Mon, 21 Jan 2008 14:59:24 +0800,Jarrett Billingsley <kb3ctd2@yahoo.com> 写道: > "janderson" <askme@me.com> wrote in message > news:fn1d9h$28r7$1@digitalmars.com... >> Whenever something changes in the source code at work we get an email >> detailing the file changes. This encourages a form of code review because >> it encourages others to check my changes. I could always go to perforce >> to do this but that is not right in my face all the time. >> >> Since the DMD frontend is open source I was thinking that it would be cool >> if the DMD changelog included a diff of the changed frontend files since >> the last one. Users could click on a link and see what changes where >> made. How this would look I don't know. I don't even know how you'd set >> this up. I know there's some tools out there that can spit out HTML >> diffs. >> >> Also if you like this idea, what would be a practical way for Walter to >> set this up. >> >> -Joel > > Well, phobos is already hosted on dsource, which provides built-in > integration with the subversion repo, and will auto-generate pretty HTML > diffs. The FE source would just have to be added. > > Part of FE sources already get their home @ dsource.org/projects/dparser/ -- 使用 Opera 革命性的电子邮件客户程序: http://www.opera.com/mail/ | |||
Copyright © 1999-2021 by the D Language Foundation
Permalink
Reply