Menu
Search

Forums

Forum Index

Thread overview
std.math.poly and const
Nov 29, 2008
dsimcha
Nov 29, 2008
Walter Bright
Nov 29, 2008
Denis Koroskin
November 29, 2008
Gravatar of dsimchaPosted by dsimchaReply
dsimcha
Gravatar of dsimcha


Reply
Should the function signature of std.math.poly be (real x, const real[] A), not (real x, real[] A)?  The D code at the end of the function clearly doesn't modify A, but I have no idea what the ASM code is doing.  Is this a bug?
November 29, 2008
Gravatar of Walter BrightPosted by Walter Bright
in reply to dsimcha		Reply
Walter Bright
Gravatar of Walter Bright
Posted in reply to dsimcha


Reply
dsimcha wrote:
> Should the function signature of std.math.poly be (real x, const real[] A),
> not (real x, real[] A)?  The D code at the end of the function clearly doesn't
> modify A, but I have no idea what the ASM code is doing.  Is this a bug?

Yes, it should be const.
November 29, 2008
Gravatar of Denis KoroskinPosted by Denis Koroskin
in reply to Walter Bright		Reply
Denis Koroskin
Gravatar of Denis Koroskin
Posted in reply to Walter Bright


Reply
On Sat, 29 Nov 2008 08:22:34 +0300, Walter Bright <newshound1@digitalmars.com> wrote:

> dsimcha wrote:
>> Should the function signature of std.math.poly be (real x, const real[] A),
>> not (real x, real[] A)?  The D code at the end of the function clearly doesn't
>> modify A, but I have no idea what the ASM code is doing.  Is this a bug?
>
> Yes, it should be const.

crc32 module also needs to be updated. Not only it doesn't use const (but should, it allows compile-time crc32 evaluation), but it also uses char[] instead of string! :)