Page size in druntime is sometime a constant (4Kb), sometime calculated, often assumed to be a compile time constant.

druntime should define a proper, authoritative, place to calculate that page size, and then use the page calculated here.

I did some tests today, and it require quite a lot of changes. But it is mandatory to run D on any system where the page size isn't 4Kb.

So first question, where this should be calculated ? In core.memory ?

On Mar 18, 2012, at 7:12 AM, deadalnix <deadalnix@gmail.com> wrote:

> Page size in druntime is sometime a constant (4Kb), sometime calculated, often assumed to be a compile time constant.
> 
> druntime should define a proper, authoritative, place to calculate that page size, and then use the page calculated here.
> 
> I did some tests today, and it require quite a lot of changes. But it is mandatory to run D on any system where the page size isn't 4Kb.
> 
> So first question, where this should be calculated ? In core.memory ?

rt.memory possibly. That or core.memory.

Le 18/03/2012 16:09, Sean Kelly a écrit :
> On Mar 18, 2012, at 7:12 AM, deadalnix<deadalnix@gmail.com>  wrote:
>
>> Page size in druntime is sometime a constant (4Kb), sometime calculated, often assumed to be a compile time constant.
>>
>> druntime should define a proper, authoritative, place to calculate that page size, and then use the page calculated here.
>>
>> I did some tests today, and it require quite a lot of changes. But it is mandatory to run D on any system where the page size isn't 4Kb.
>>
>> So first question, where this should be calculated ? In core.memory ?
>
> rt.memory possibly. That or core.memory.

I do have a patch for that, but I have no clue where GetSystemInfo is defined (grep didn't helped me much here) so it will not work on windows.

Additionnaly, I don't have a windows machine.

On 19-03-2012 11:03, deadalnix wrote:
> Le 18/03/2012 16:09, Sean Kelly a écrit :
>> On Mar 18, 2012, at 7:12 AM, deadalnix<deadalnix@gmail.com> wrote:
>>
>>> Page size in druntime is sometime a constant (4Kb), sometime
>>> calculated, often assumed to be a compile time constant.
>>>
>>> druntime should define a proper, authoritative, place to calculate
>>> that page size, and then use the page calculated here.
>>>
>>> I did some tests today, and it require quite a lot of changes. But it
>>> is mandatory to run D on any system where the page size isn't 4Kb.
>>>
>>> So first question, where this should be calculated ? In core.memory ?
>>
>> rt.memory possibly. That or core.memory.
>
> I do have a patch for that, but I have no clue where GetSystemInfo is
> defined (grep didn't helped me much here) so it will not work on windows.
>
> Additionnaly, I don't have a windows machine.

Err, is it defined at all...?

-- 
- Alex

On 19-03-2012 11:12, Alex Rønne Petersen wrote:
> On 19-03-2012 11:03, deadalnix wrote:
>> Le 18/03/2012 16:09, Sean Kelly a écrit :
>>> On Mar 18, 2012, at 7:12 AM, deadalnix<deadalnix@gmail.com> wrote:
>>>
>>>> Page size in druntime is sometime a constant (4Kb), sometime
>>>> calculated, often assumed to be a compile time constant.
>>>>
>>>> druntime should define a proper, authoritative, place to calculate
>>>> that page size, and then use the page calculated here.
>>>>
>>>> I did some tests today, and it require quite a lot of changes. But it
>>>> is mandatory to run D on any system where the page size isn't 4Kb.
>>>>
>>>> So first question, where this should be calculated ? In core.memory ?
>>>
>>> rt.memory possibly. That or core.memory.
>>
>> I do have a patch for that, but I have no clue where GetSystemInfo is
>> defined (grep didn't helped me much here) so it will not work on windows.
>>
>> Additionnaly, I don't have a windows machine.
>
> Err, is it defined at all...?
>

DMD doesn't seem to have any magic for it, so I can't imagine that it's being used at all...

-- 
- Alex