Does the pull tester pick up new pull requests automatically, or is there something I need to do to have my pull request tested?

https://github.com/D-Programming-Language/dmd/pull/1064


--Ed

On 28-07-2012 18:42, Ed McCardell wrote:
> Does the pull tester pick up new pull requests automatically, or is
> there something I need to do to have my pull request tested?
>
> https://github.com/D-Programming-Language/dmd/pull/1064
>
>
> --Ed

Brad probably needs to whitelist you.

-- 
Alex Rønne Petersen
alex@lycus.org
http://lycus.org

Am 28.07.2012 18:42, schrieb Ed McCardell:
> Does the pull tester pick up new pull requests automatically, or is
> there something I need to do to have my pull request tested?
>
> https://github.com/D-Programming-Language/dmd/pull/1064
>
>
> --Ed

That is automatically tested: http://d.puremagic.com/test-results/pull-history.ghtml?projectid=1&pullid=1064

There are great greasemonkey scripts which show the status of the pull request: http://d.puremagic.com/test-results/greasemonkey.ghtml

I am using these scripts with tampermonkey (https://chrome.google.com/webstore/detail/dhdgffkkebhmkfjojejmpbldmpobfkfo) in chromium.

On 07/28/2012 05:49 PM, David wrote:
> That is automatically tested:
> http://d.puremagic.com/test-results/pull-history.ghtml?projectid=1&pullid=1064
>
>
> There are great greasemonkey scripts which show the status of the pull
> request: http://d.puremagic.com/test-results/greasemonkey.ghtml
>
> I am using these scripts with tampermonkey
> (https://chrome.google.com/webstore/detail/dhdgffkkebhmkfjojejmpbldmpobfkfo)
> in chromium.


Thanks. Is the test summary script (that is supposed to show on github/D-Programming-Language) working for you in chromium? It isn't for me.

> Thanks. Is the test summary script (that is supposed to show on
> github/D-Programming-Language) working for you in chromium? It isn't for
> me.

No, but it did work, I guess it fails because they changed the github design.

On 7/28/2012 4:17 PM, David wrote:
>> Thanks. Is the test summary script (that is supposed to show on github/D-Programming-Language) working for you in chromium? It isn't for me.
> 
> No, but it did work, I guess it fails because they changed the github design.

This page includes the master tester results:
  https://github.com/organizations/D-Programming-Language

I don't recall that I ever got it integrated on the non-organization page, though the script's @includes line does still list that url, which is misleading.  That one is already pretty busy.

The pull tests are included on pages like:
  https://github.com/D-Programming-Language/<project>/pull/<pullnumber>

Later,
Brad

On Sunday, 29 July 2012 at 00:59:51 UTC, Brad Roberts wrote:
> This page includes the master tester results:
>   https://github.com/organizations/D-Programming-Language
>
> I don't recall that I ever got it integrated on the non-organization page, though the script's @includes line does still
> list that url, which is misleading.  That one is already pretty busy.

The problem is that https://github.com/organizations/D-Programming-Language is only accessible to organization members. Non-members just get redirected to their personal dashboard. The tester results used to get listed under the »watched repositories« box, which was quite handy.

David

On 7/28/2012 6:36 PM, David Nadlinger wrote:
> On Sunday, 29 July 2012 at 00:59:51 UTC, Brad Roberts wrote:
>> This page includes the master tester results:
>>   https://github.com/organizations/D-Programming-Language
>>
>> I don't recall that I ever got it integrated on the non-organization page, though the script's @includes line does still list that url, which is misleading.  That one is already pretty busy.
> 
> The problem is that https://github.com/organizations/D-Programming-Language is only accessible to organization members. Non-members just get redirected to their personal dashboard. The tester results used to get listed under the »watched repositories« box, which was quite handy.
> 
> David

Hrm.. I didn't realize that, being a member of the org.

There's another page that lists the tester results:  https://github.com/  Is that what you mean by your personal dashboard?  That one seems to still work for me.  Is it not working for you, or do you mean yet another url?

On 7/28/2012 8:23 PM, Brad Roberts wrote:
> On 7/28/2012 6:36 PM, David Nadlinger wrote:
>> On Sunday, 29 July 2012 at 00:59:51 UTC, Brad Roberts wrote:
>>> This page includes the master tester results:
>>>   https://github.com/organizations/D-Programming-Language
>>>
>>> I don't recall that I ever got it integrated on the non-organization page, though the script's @includes line does still list that url, which is misleading.  That one is already pretty busy.
>>
>> The problem is that https://github.com/organizations/D-Programming-Language is only accessible to organization members. Non-members just get redirected to their personal dashboard. The tester results used to get listed under the »watched repositories« box, which was quite handy.
>>
>> David
> 
> Hrm.. I didn't realize that, being a member of the org.
> 
> There's another page that lists the tester results:  https://github.com/  Is that what you mean by your personal dashboard?  That one seems to still work for me.  Is it not working for you, or do you mean yet another url?

Oh, and for what it's worth, if anyone wants to write their own script, the two urls used by the ones I wrote:

master summary:
  http://d.puremagic.com/test-results/summary.json.ghtml

pull results:
  http://d.puremagic.com/test-results/pull.json.ghtml?ref=dmd/1000

  The value of the ref param just needs to be anything that has dmd or druntime or phobos in the url, is / separated
tokens, and has a number in it.  The script I wrote just uses the current pages's href, which is perfect.  The example
above is hand crafted, but works fine.

If you do write something, please let me know.  If it's generally useful, I'll be happy to add it to the list of scripts so others can take advantage of them.  If there's more data that you want in json form, it should be easy to make available, I just did the minimum I needed at the time.  Also, be kind and consider the call rates and make sure to use appropriate delays between calls (no faster than once a minute, please, the data just doesn't change all that fast).

Later,
Brad

On 7/28/12 9:36 PM, David Nadlinger wrote:
> On Sunday, 29 July 2012 at 00:59:51 UTC, Brad Roberts wrote:
>> This page includes the master tester results:
>> https://github.com/organizations/D-Programming-Language
>>
>> I don't recall that I ever got it integrated on the non-organization
>> page, though the script's @includes line does still
>> list that url, which is misleading. That one is already pretty busy.
>
> The problem is that
> https://github.com/organizations/D-Programming-Language is only
> accessible to organization members. Non-members just get redirected to
> their personal dashboard. The tester results used to get listed under
> the »watched repositories« box, which was quite handy.

Can we expand access meaningfully?

Andrei