| Thread overview | ||||||||
|---|---|---|---|---|---|---|---|---|
|
April 19, 2016 [DUB] Does anyone have some time to look at PR #785? | ||||
|---|---|---|---|---|
| ||||
This is a rather important pull request and the last big milestone for the 1.0.0 release. I'd like to get the next version out shortly, but this PR is sitting idle for over a month now and partially blocks development. It consists of mostly just documentation additions, deprecations/name changes and moved code, so the review can focus on the high level changes and should be well manageable despite the size of the diff (commit-by-commit review is a good idea, though). Any support is much appreciated! | ||||
April 19, 2016 Re: [DUB] Does anyone have some time to look at PR #785? | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Sönke Ludwig | On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote: > This is a rather important pull request and the last big milestone for the 1.0.0 release. I'd like to get the next version out shortly, but this PR is sitting idle for over a month now and partially blocks development. > > It consists of mostly just documentation additions, deprecations/name changes and moved code, so the review can focus on the high level changes and should be well manageable despite the size of the diff (commit-by-commit review is a good idea, though). > > Any support is much appreciated! Link: https://github.com/dlang/dub/pull/785 | |||
April 19, 2016 Re: [DUB] Does anyone have some time to look at PR #785? | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Marc Schütz | Am 19.04.2016 um 11:44 schrieb Marc Schütz:
> On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote:
>> This is a rather important pull request and the last big milestone for
>> the 1.0.0 release. I'd like to get the next version out shortly, but
>> this PR is sitting idle for over a month now and partially blocks
>> development.
>>
>> It consists of mostly just documentation additions, deprecations/name
>> changes and moved code, so the review can focus on the high level
>> changes and should be well manageable despite the size of the diff
>> (commit-by-commit review is a good idea, though).
>>
>> Any support is much appreciated!
>
> Link:
> https://github.com/dlang/dub/pull/785
Thanks, totally forgot to do that...
| |||
April 19, 2016 Re: [DUB] Does anyone have some time to look at PR #785? | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Sönke Ludwig | On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote:
> It consists of mostly just documentation additions, deprecations/name changes and moved code, so the review can focus on the high level changes and should be well manageable despite the size of the diff (commit-by-commit review is a good idea, though).
Having a huge mix of doc changes and functionality changes, even if you review commit by commit, is pretty hard to review. I think it would be easier for people to help with this if this was multiple PRs.
| |||
April 19, 2016 Re: [DUB] Does anyone have some time to look at PR #785? | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Jack Stouffer | Am 19.04.2016 um 18:50 schrieb Jack Stouffer:
> On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote:
>> It consists of mostly just documentation additions, deprecations/name
>> changes and moved code, so the review can focus on the high level
>> changes and should be well manageable despite the size of the diff
>> (commit-by-commit review is a good idea, though).
>
> Having a huge mix of doc changes and functionality changes, even if you
> review commit by commit, is pretty hard to review. I think it would be
> easier for people to help with this if this was multiple PRs.
There are (almost) no functionality changes. Code is just moved to other modules in some cases.
| |||
April 19, 2016 Re: [DUB] Does anyone have some time to look at PR #785? | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Sönke Ludwig | On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote:
> This is a rather important pull request and the last big milestone for the 1.0.0 release. I'd like to get the next version out shortly, but this PR is sitting idle for over a month now and partially blocks development.
>
> It consists of mostly just documentation additions, deprecations/name changes and moved code, so the review can focus on the high level changes and should be well manageable despite the size of the diff (commit-by-commit review is a good idea, though).
>
> Any support is much appreciated!
LGTM
| |||
Copyright © 1999-2021 by the D Language Foundation
Permalink
Reply