Isn't it too large?

http://dlang.org/phobos/std_experimental_allocator_building_blocks_affix_allocator.html#.AffixAllocator.goodAllocSize

Looks like almost a full line in between. Should be 25% of a line or so. What do you all think?


Andrei

On 23.04.2016 21:43, Andrei Alexandrescu wrote:
> http://dlang.org/phobos/std_experimental_allocator_building_blocks_affix_allocator.html#.AffixAllocator.goodAllocSize
>
>
> Looks like almost a full line in between.

It is a full line (<br><br>).

On 04/23/2016 03:50 PM, ag0aep6g wrote:
> On 23.04.2016 21:43, Andrei Alexandrescu wrote:
>> http://dlang.org/phobos/std_experimental_allocator_building_blocks_affix_allocator.html#.AffixAllocator.goodAllocSize
>>
>>
>>
>> Looks like almost a full line in between.
>
> It is a full line (<br><br>).

Should we use a single <br>? -- Andrei

On 23.04.2016 21:53, Andrei Alexandrescu wrote:
> Should we use a single <br>? -- Andrei

That would look better in the case you linked, but it would be a step back with longer signatures. E.g.
http://dlang.org/phobos/std_algorithm_searching.html#.endsWith

On Saturday, 23 April 2016 at 20:06:39 UTC, ag0aep6g wrote:
> On 23.04.2016 21:53, Andrei Alexandrescu wrote:
>> Should we use a single <br>? -- Andrei
>
> That would look better in the case you linked, but it would be a step back with longer signatures. E.g.
> http://dlang.org/phobos/std_algorithm_searching.html#.endsWith

I still can't get over the ridiculous grey constraints. WTF.

But what we could do is add a margin-bottom to them if needed, while keeping the others hugged up.

BTW this is what it looks like on my docs: http://dpldocs.info/experimental-docs/std.algorithm.searching.endsWith.4.html

On 04/23/2016 04:06 PM, ag0aep6g wrote:
> On 23.04.2016 21:53, Andrei Alexandrescu wrote:
>> Should we use a single <br>? -- Andrei
>
> That would look better in the case you linked, but it would be a step
> back with longer signatures. E.g.
> http://dlang.org/phobos/std_algorithm_searching.html#.endsWith

Good point. How about a controlled 1.25 lines spacing? -- Andrei

On 04/23/2016 04:50 PM, Adam D. Ruppe wrote:
> On Saturday, 23 April 2016 at 20:06:39 UTC, ag0aep6g wrote:
>> On 23.04.2016 21:53, Andrei Alexandrescu wrote:
>>> Should we use a single <br>? -- Andrei
>>
>> That would look better in the case you linked, but it would be a step
>> back with longer signatures. E.g.
>> http://dlang.org/phobos/std_algorithm_searching.html#.endsWith
>
> I still can't get over the ridiculous grey constraints. WTF.
>
> But what we could do is add a margin-bottom to them if needed, while
> keeping the others hugged up.
>
> BTW this is what it looks like on my docs:
> http://dpldocs.info/experimental-docs/std.algorithm.searching.endsWith.4.html

Not bad! -- Andrei

On Saturday, 23 April 2016 at 20:50:31 UTC, Adam D. Ruppe wrote:
> On Saturday, 23 April 2016 at 20:06:39 UTC, ag0aep6g wrote:
>> On 23.04.2016 21:53, Andrei Alexandrescu wrote:
>>> Should we use a single <br>? -- Andrei
>>
>> That would look better in the case you linked, but it would be a step back with longer signatures. E.g.
>> http://dlang.org/phobos/std_algorithm_searching.html#.endsWith
>
> I still can't get over the ridiculous grey constraints. WTF.
>
> But what we could do is add a margin-bottom to them if needed, while keeping the others hugged up.
>
> BTW this is what it looks like on my docs: http://dpldocs.info/experimental-docs/std.algorithm.searching.endsWith.4.html

Only thing I dislike about it is that the "Overload: <short signature>" thing of the currently selected overload vanishes completely, instead of just changing color to suggest it is the active one you selected.

Also, your search currently does not list modules as search results (try searching base64, it will only show things like the Base64/Base64Impl things etc).

Anyhow I really should be using your docs by now, seems the timeframe where you hit a "this has not been implemented yet, sorry"-warning on half the links you click on is finally over and being able to actually read constraints and having a better overview (via the toggling of the full signature) with function overloads alone are huge selling points, not to mention it does not try to cram the documentation for whole modules on a single page but splits it nicely into single pages for functions etc.

On Saturday, 23 April 2016 at 20:50:31 UTC, Adam D. Ruppe wrote:
> I still can't get over the ridiculous grey constraints. WTF.

It's much better reading signatures than before.

> But what we could do is add a margin-bottom to them if needed, while keeping the others hugged up.

Good idea, probably only template symbols with constraints need the vertical whitespace.

> BTW this is what it looks like on my docs: http://dpldocs.info/experimental-docs/std.algorithm.searching.endsWith.4.html

I found it a bit confusing at first. There should be expand/collapse buttons for overload details so you can compare them simultaneously. The current behaviour can still be kept too. I think template args should not be elided completely in the summary, at least (...) should be shown in the signature.

I think there are too many line breaks, maybe this instead:

Function endsWith -> bool @anyAttributes
(alias pred, R)
(R doesThisEnd)
if (isInputRange!R &&
    ifTestable!(typeof(doesThisEnd.front), unaryFun!pred))

On Saturday, 23 April 2016 at 19:53:38 UTC, Andrei Alexandrescu wrote:
> On 04/23/2016 03:50 PM, ag0aep6g wrote:
>> On 23.04.2016 21:43, Andrei Alexandrescu wrote:
>>> http://dlang.org/phobos/std_experimental_allocator_building_blocks_affix_allocator.html#.AffixAllocator.goodAllocSize
>>>
>>> Looks like almost a full line in between.
>>
>> It is a full line (<br><br>).
>
> Should we use a single <br>? -- Andrei

The use of hardcoded <br> tags in ddoc output is a bit odd -- surely it would be better to encode the list of symbols as entries in an unnumbered list, and use CSS to style its layout as wished?