This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":

https://github.com/dlang/DIPs/blob/7c2c39243d0d747191f05fb08f87e1ebcb575d84/DIPs/DIP1015.md

All review-related feedback on and discussion of the DIP should occur in this thread. The review period will end at 11:59 PM ET on July 4, or when I make a post declaring it complete.

At the end of Round 1, if further review is deemed necessary, the DIP will be scheduled for another round. Otherwise, it will be queued for the Final Review and Formal Assessment by the language maintainers.

Please familiarize yourself with the documentation for the Community Review before participating.

https://github.com/dlang/DIPs/blob/master/PROCEDURE.md#community-review

Thanks in advance to all who participate.

On Wednesday, 20 June 2018 at 08:16:21 UTC, Mike Parker wrote:
> This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":
>
> [...]

Yes please

On Wednesday, 20 June 2018 at 08:16:21 UTC, Mike Parker wrote:
> This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":
>
> [...]

This is similar to the overload bug that c++ has with the marco NULL before it was fixed in c++11.

On Wed, Jun 20, 2018 at 01:30:56PM +0000, Chris M. via Digitalmars-d wrote:
> On Wednesday, 20 June 2018 at 08:16:21 UTC, Mike Parker wrote:
> > This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":
> > 
> > [...]
> 
> Yes please

Seconded.


T

-- 
English is useful because it is a mess. Since English is a mess, it maps well onto the problem space, which is also a mess, which we call reality. Similarly, Perl was designed to be a mess, though in the nicest of all possible ways. -- Larry Wall

On Wednesday, 20 June 2018 at 16:10:26 UTC, H. S. Teoh wrote:
> On Wed, Jun 20, 2018 at 01:30:56PM +0000, Chris M. via Digitalmars-d wrote:
>> On Wednesday, 20 June 2018 at 08:16:21 UTC, Mike Parker wrote:
>> > This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":
>> > 
>> > [...]
>> 
>> Yes please
>
> Seconded.
>
>
> T

Count me in. Even though I never write code like bool foo = '\0'; I can see why this DIP is helpful and what kind of errors it can prevent.

On Wednesday, 20 June 2018 at 08:16:21 UTC, Mike Parker wrote:
> This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":
>
> https://github.com/dlang/DIPs/blob/7c2c39243d0d747191f05fb08f87e1ebcb575d84/DIPs/DIP1015.md
>
> All review-related feedback on and discussion of the DIP should occur in this thread. The review period will end at 11:59 PM ET on July 4, or when I make a post declaring it complete.
>
> At the end of Round 1, if further review is deemed necessary, the DIP will be scheduled for another round. Otherwise, it will be queued for the Final Review and Formal Assessment by the language maintainers.
>
> Please familiarize yourself with the documentation for the Community Review before participating.
>
> https://github.com/dlang/DIPs/blob/master/PROCEDURE.md#community-review
>
> Thanks in advance to all who participate.

Example D

```
Enum int a = 2;
Enum int b = 1;
```
should be `enum`.

Otherwise, YES!!!!

On Wednesday, 20 June 2018 at 08:16:21 UTC, Mike Parker wrote:
> This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":
>
> https://github.com/dlang/DIPs/blob/7c2c39243d0d747191f05fb08f87e1ebcb575d84/DIPs/DIP1015.md
>
> All review-related feedback on and discussion of the DIP should occur in this thread. The review period will end at 11:59 PM ET on July 4, or when I make a post declaring it complete.
>
> At the end of Round 1, if further review is deemed necessary, the DIP will be scheduled for another round. Otherwise, it will be queued for the Final Review and Formal Assessment by the language maintainers.
>
> Please familiarize yourself with the documentation for the Community Review before participating.
>
> https://github.com/dlang/DIPs/blob/master/PROCEDURE.md#community-review
>

Just a little remark in the Rationale section. C does have a bool alias of _Bool type and false and true keywords since C99. So it is wrong to say C doesn't have them. Doesn't change anything on the rest of the paper but is it better to not propagate falsehoods.

On Wednesday, 20 June 2018 at 08:16:21 UTC, Mike Parker wrote:
> This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":
>
> https://github.com/dlang/DIPs/blob/7c2c39243d0d747191f05fb08f87e1ebcb575d84/DIPs/DIP1015.md

The arguments are clear and convincing, so: Yes!

On 6/20/18 4:16 AM, Mike Parker wrote:
> This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":
> 
> https://github.com/dlang/DIPs/blob/7c2c39243d0d747191f05fb08f87e1ebcb575d84/DIPs/DIP1015.md 
> 
> 
> All review-related feedback on and discussion of the DIP should occur in this thread. The review period will end at 11:59 PM ET on July 4, or when I make a post declaring it complete.
> 
> At the end of Round 1, if further review is deemed necessary, the DIP will be scheduled for another round. Otherwise, it will be queued for the Final Review and Formal Assessment by the language maintainers.
> 
> Please familiarize yourself with the documentation for the Community Review before participating.
> 
> https://github.com/dlang/DIPs/blob/master/PROCEDURE.md#community-review
> 
> Thanks in advance to all who participate.
> 
> 

I agree with everything, but one thing that is not specified here is when integers are used as conditionals.

In other words, this still has to compile:

if(1) ...

enum a = 1;

if(a) ...

I can see this somehow getting caught up in the "implicit conversion to bool", so there should be a section to address this.

-Steve

On Wednesday, 20 June 2018 at 08:16:21 UTC, Mike Parker wrote:
> This is the feedback thread for the first round of Community Review for DIP 1015, "Deprecation and removal of implicit conversion from integer and character literals to bool":
>
> https://github.com/dlang/DIPs/blob/7c2c39243d0d747191f05fb08f87e1ebcb575d84/DIPs/DIP1015.md
>
> All review-related feedback on and discussion of the DIP should occur in this thread. The review period will end at 11:59 PM ET on July 4, or when I make a post declaring it complete.
>
> At the end of Round 1, if further review is deemed necessary, the DIP will be scheduled for another round. Otherwise, it will be queued for the Final Review and Formal Assessment by the language maintainers.
>
> Please familiarize yourself with the documentation for the Community Review before participating.
>
> https://github.com/dlang/DIPs/blob/master/PROCEDURE.md#community-review
>
> Thanks in advance to all who participate.

The case of `assert(0, "this should not happen");` is not covered. Is this it allowed ?