Another init() bug, can we deprecate yet?

Jan 07, 2015

Peter Alexander

Jan 07, 2015

Brian Schott

Jan 07, 2015

H. S. Teoh

Jan 08, 2015

Peter Alexander

Jan 08, 2015

H. S. Teoh

https://issues.dlang.org/show_bug.cgi?id=13806 For the lazy: BitArray has an init() method, which hides the property BitArray.init This, or something similar, appears every few months. Walter has said in the past that the ability to override init is a feature. As far as I can tell, no one is using it as a feature; it only seems to cause trouble. Can we just deprecate it? At the very least deprecate functions named init().

On Wednesday, 7 January 2015 at 22:03:01 UTC, Peter Alexander wrote: > Can we just deprecate it? At the very least deprecate functions named init(). There's a check for that: https://github.com/Hackerpilot/Dscanner/blob/master/src/analysis/builtin_property_names.d

On Wed, Jan 07, 2015 at 10:03:00PM +0000, Peter Alexander via Digitalmars-d wrote: > https://issues.dlang.org/show_bug.cgi?id=13806 > > For the lazy: BitArray has an init() method, which hides the property > BitArray.init > > This, or something similar, appears every few months. Walter has said in the past that the ability to override init is a feature. As far as I can tell, no one is using it as a feature; it only seems to cause trouble. > > Can we just deprecate it? At the very least deprecate functions named > init(). https://github.com/D-Programming-Language/phobos/pull/2854 Destroy! T -- You have to expect the unexpected. -- RL

On Wednesday, 7 January 2015 at 23:31:30 UTC, H. S. Teoh via Digitalmars-d wrote: > On Wed, Jan 07, 2015 at 10:03:00PM +0000, Peter Alexander via Digitalmars-d wrote: >> https://issues.dlang.org/show_bug.cgi?id=13806 >> >> For the lazy: BitArray has an init() method, which hides the property >> BitArray.init >> >> This, or something similar, appears every few months. Walter has said >> in the past that the ability to override init is a feature. As far as >> I can tell, no one is using it as a feature; it only seems to cause >> trouble. >> >> Can we just deprecate it? At the very least deprecate functions named >> init(). > > https://github.com/D-Programming-Language/phobos/pull/2854 > > Destroy! Thanks. Just to be clear, I'm advocating deprecating all user-defined init functions, not just BitArray (so we don't get into this situation again).