Thread overview
October 17

BEERCONF!

Beerconf this month will be held on October 26-27. I likely will be not able to join on the 27 as I will be driving down to Yale to join Mike Shah and Ali Cehreli for Mike's game engine class.

Obligatory link to beerconf T's:
https://www.zazzle.com/store/dlang_swag/products?cg=196874696466206954

What is Beerconf?

Check out the wiki article

Phobos PR closefest

We're going to try something this beerconf. Adam Wilson suggested we do a community speedrun through the first page of Phobos PRs. Meaning, respond, merge, close, whatever it takes to get them off the list or at least to respond to the authors. The idea is, you will have a lot of experienced D developers together, we can discuss, we can help each other out, and we can slog through some of the backlog. It's like a cleanup party!

New contributors who wish to help or fix their pet peeves are welcome!

We currently have 99 open PRs. How many can we get it down to?

Cheers! 🍺

-Steve

October 18

To expand on Steven's summary of the idea. There are a few specific goals that I have in mind:

  1. Merge as many of the PR's as possible. Priority will be given to bug fixes.
  2. Leave reviews/next-steps on the remaining ones that we want to merge but can't.
  3. Clean up as many old/stalled/abandoned PR's as possible.

How will it work?

On Saturday, we'll go down the list of Open PR's sequentially until we get to the PR's that are over two years old (marked as "Stalled"). For each PR we will conduct a review and determine which of the following actions to take:

  1. Approve and Merge. Obviously this is only available for PR's that are in a mergeable state.
  2. Request changes. If we can't merge it we'll let you know why.
  3. Close. This means that we think the PR is either unnecessary or unrecoverable in it's current state.

On Sunday we will continue with the remainder of the list. If you've updated a PR with Requested Changes we will merge it at this time.

Finally on Monday morning I will go through the list of PR's and close all PR's marked as stalled. I'll hold of on this until then in case anybody resurrects their stalled PR during BeerConf.

A few notes.

While none of us can be online for the entire weekend (the tyranny of sleep!) we should have somebody available to review and merge for most of the weekend. Furthermore, since this is being done in conjunction with BeerConf, the fastest way to get your PR reviewed and merged will be to join the BeerConf stream and talk with us directly. Not only should this significantly improve the speed at which we can review your PR, it will also be more fun.

Nick Wilson has kindly gone through the PR's on noted which ones need a rebase. If your PR is one of those PR's please rebase it and make sure everything is up-to-date. Once that is done we can merge your PR.

If you have a PR that is currently marked as "Stalled" (all PR's over two years are marked at stalled), and you would like to get it reviewed, please rebase it and let somebody in the BeerConf stream know which PR you resurrected.

Some PR's have unaddressed feedback that needs to be addressed before we can merge them. If you can address that feedback before BeerConf, that'd be awesome, otherwise if you want to seek additional feedback, please join us on the BeerConf stream and will help you further. While the goal is to get as many PR's as possible merged, we still have to follow the standards and guidelines.

Don't have any open PR's but want to help out? There are 980 open Phobos bugs to choose from! You can find the complete list on the Bugzilla here. Some of these are super simple. Document fixes, attribute fixes, and the like. While we will be focusing on existing PR's, one way to get your favorite bug fixed is to submit a PR before BeerConf. And if you don't feel like making a PR, doing an audit of the existing bugs to see if any have been missed for Resolution would also be helpful, I've already found one.

Why are we doing this?

The more of these that we get into Phobos prior to migrating modules to v3 the less work we'll have to do in v3 and the faster we can deliver v3 to you. In most cases, v3 won't be significantly altering the implementations so getting the improvements in now will pay dividends later. Another reason is that getting bug fixes into Phobos now reduces the number of bug-fixes that we have to duplicate between v2 and v3. Aside from significantly improving the quality of Phobos v2 and v3, other benefits include cleaning the cruft out of the PR queue and being able to clap back at the doubters and haters, we are not dead!

It is my hope that by putting this call to action out there, we can get at least a few people to resurrect their old PR's and get them merged. If you have a PR that you've abandoned you are invited and encouraged to rebase your PR and get it back into shape for merging.

October 24

On Thursday, 17 October 2024 at 03:30:49 UTC, Steven Schveighoffer wrote:

>

BEERCONF!

Beerconf this month will be held on October 26-27.

A reminder that this is happening in 2 days.

>

Phobos PR closefest

Don't forget to bring your IDEs and get a crack at making history in phobos!

The count is down to 95 open PRs!

-Steve

6 days ago
ITS ALIVEEEEE!!!!!!!!!!

https://meet.jit.si/Dlang2024OctoberBeerConf

Sadly Adam had to go to bed around an hour ago, so get your PR's in now, so that when he wakes he is overloaded with work, muahahha!

5 days ago

Saturday Evening Update on the Phobos PR Speed-Run

We elected to work from oldest->newest.

Stats:

  • 42 PR's Closed (mostly old PR's that were previously marked as "Stalled")
  • 15 PR's marked as "Salvage". These PR's are considered worth saving and are easily salvageable with rebases and simple conflict resolutions.
  • 2 PR's marked as "Auto-Merge".
  • Total Time Spent: 2.5hrs.

In keeping with the concept of a speed-run, we reviewed over half the queue in 2.5 hours. While I do expect to slow down considerably from here, these are already some pretty impressive results and we should be able to make it through the whole queue this weekend.

Nick Wilson has kindly volunteered to go through the Salvage PR's and handle the rebasing/conflict resolution work once we're done with the speed-run, but there are a few he isn't kitted out to handle. So next time you see him please drop him a note of thanks, with Nick these results would not have been possible.

We are currently on a short break due to a lack of people being awake.

If you have a PR marked as Salvage and want to help us out, we would be very happy to push the merge button for you after it's been rebased. And there is still time to get your PR's opened for review!

5 days ago

Sunday Morning Phobos PR Speed-Run Update

Stats:

  • 52 PR's closed.
  • 8 PR's merged. Including 2 bug-fix PR's.
  • 35 PR's remain.
  • Total Time Spent: 6 hours

There is still a significant amount of work to be done with rebasing the remaining PR's. And there are a few that need legitimate work to bring up to merge-status.

We also took a quick peek at the dlang.org PR queue and closed a few over there. Now down to 74 open.

5 days ago
Nice work!
4 days ago
On Sunday, 27 October 2024 at 18:32:26 UTC, Walter Bright wrote:
> Nice work!

Indeed, this is exciting to see!