stlport/stl/_string.h

Line 129:

    : _M_start(0), _M_finish(0), _M_end_of_storage(__a, static_cast<_Tp*>(0)) {}

Line 132:

    : _M_start(0), _M_finish(0), _M_end_of_storage(__a, static_cast<_Tp*>(0))

Line 213:

    return _STLP_CONVERT_ALLOCATOR(static_cast<const allocator_type&>(this->_M_end_of_storage), _CharT);

The third one I'm not 100% on. Other eyes'd be helpful.



"Walter" <newshound@digitalmars.com> wrote in message news:cvvt4t$fot$2@digitaldaemon.com...
>
> "Matthew" <admin@stlsoft.dot.dot.dot.dot.org> wrote in message news:cvtkn4$12j7$1@digitaldaemon.com...
>> > I'd rather not. Switches to turn warnings on, pragmas to turn them
>> > off - I
>> > don't think there's much to be gained here that's worth the
>> > complexity.
>>
>> Ok. The alternative is to fix the C-style casts in the DMC++ headers. Are you amenable to adopting fixes, should I be motivated, from time to time, to detect and effect them?
>
> Sure.
>
> 

stlport/stl/_list.c

Line 69:

  _List_node<_Tp>* __cur = static_cast<_List_node<_Tp>*>(this->_M_node._M_data->_M_next);


Line 72:

    __cur = static_cast<_List_node<_Tp>*>(__cur->_M_next);


"Walter" <newshound@digitalmars.com> wrote in message news:cvvt4t$fot$2@digitaldaemon.com...
>
> "Matthew" <admin@stlsoft.dot.dot.dot.dot.org> wrote in message news:cvtkn4$12j7$1@digitaldaemon.com...
>> > I'd rather not. Switches to turn warnings on, pragmas to turn them
>> > off - I
>> > don't think there's much to be gained here that's worth the
>> > complexity.
>>
>> Ok. The alternative is to fix the C-style casts in the DMC++ headers. Are you amenable to adopting fixes, should I be motivated, from time to time, to detect and effect them?
>
> Sure.
>
> 

stlport/stl/_list.h


Line 130:

  reference operator*() const { return static_cast<_Node*>(_M_node)->_M_data; }


Line 182:

  _List_base(const allocator_type& __a) : _M_node(_STLP_CONVERT_ALLOCATOR(__a, _Node), static_cast<_Node*>(0)) {


Lines 266-7:

  iterator begin()             { return iterator(static_cast<_Node*>(this->_M_node._M_data->_M_next)); }
  const_iterator begin() const { return const_iterator(static_cast<_Node*>(this->_M_node._M_data->_M_next)); }

Line 356:

    _Node* __n = static_cast<_Node*>(__position._M_node);


Line 361:

    return iterator(static_cast<_Node*>(__next_node));



"Walter" <newshound@digitalmars.com> wrote in message news:cvvt4t$fot$2@digitaldaemon.com...
>
> "Matthew" <admin@stlsoft.dot.dot.dot.dot.org> wrote in message news:cvtkn4$12j7$1@digitaldaemon.com...
>> > I'd rather not. Switches to turn warnings on, pragmas to turn them
>> > off - I
>> > don't think there's much to be gained here that's worth the
>> > complexity.
>>
>> Ok. The alternative is to fix the C-style casts in the DMC++ headers. Are you amenable to adopting fixes, should I be motivated, from time to time, to detect and effect them?
>
> Sure.
>
> 

> stddef.h
>
>
> NOTE: This one's not just to be thrown in, as it's sufficiently complex to need some more eyes on it.
>
>
> Was (Line 66):
>
> #define offsetof(t,i) ((size_t)((char *)&((t *)0)->i - (char *)0))
>
> Now (Lines 66-70):
>
> #ifdef __cplusplus
> # define offsetof(t,i) (static_cast<size_t>(reinterpret_cast<char*>(&(static_cast<t*>(0))->i) -
> static_cast<char*>(0)))
> #else /* ? __cplusplus */
> # define offsetof(t,i) ((size_t)((char *)&((t *)0)->i - (char *)0))
> #endif /* __cplusplus */

Interestingly, we need to use const in there. :-)

#ifdef __cplusplus
# define offsetof(t,i) (static_cast<size_t>(reinterpret_cast<char const*>(&(static_cast<t const*>(0))->i) -
static_cast<char const*>(0)))
#else /* ? __cplusplus */
# define offsetof(t,i) ((size_t)((char *)&((t *)0)->i - (char *)0))
#endif /* __cplusplus */

stlport/stl/char_traits.h

Line 198:

    return static_cast<int_type>(-1);

Line 229:

    return static_cast<char>(static_cast<unsigned char>(__c));

Line 232:

    return static_cast<unsigned char>(__c);


"Walter" <newshound@digitalmars.com> wrote in message news:cvvt4t$fot$2@digitaldaemon.com...
>
> "Matthew" <admin@stlsoft.dot.dot.dot.dot.org> wrote in message news:cvtkn4$12j7$1@digitaldaemon.com...
>> > I'd rather not. Switches to turn warnings on, pragmas to turn them
>> > off - I
>> > don't think there's much to be gained here that's worth the
>> > complexity.
>>
>> Ok. The alternative is to fix the C-style casts in the DMC++ headers. Are you amenable to adopting fixes, should I be motivated, from time to time, to detect and effect them?
>
> Sure.
>
>

stlport/stl/_ios.h

Line 137:

{ return static_cast<const ctype<_CharT>*>(this->_M_ctype_facet())->narrow(__c, __default); }

Line 143:

  return static_cast<const ctype<_CharT>*>(this->_M_ctype_facet())->widen(__c); }


"Walter" <newshound@digitalmars.com> wrote in message news:cvvt4t$fot$2@digitaldaemon.com...
>
> "Matthew" <admin@stlsoft.dot.dot.dot.dot.org> wrote in message news:cvtkn4$12j7$1@digitaldaemon.com...
>> > I'd rather not. Switches to turn warnings on, pragmas to turn them
>> > off - I
>> > don't think there's much to be gained here that's worth the
>> > complexity.
>>
>> Ok. The alternative is to fix the C-style casts in the DMC++ headers. Are you amenable to adopting fixes, should I be motivated, from time to time, to detect and effect them?
>
> Sure.
>
> 

stlport/stl/_ctype.h

Line 80:

    { return ((*(_M_ctype_table+static_cast<unsigned char>(__c))) & __m) != 0; }

Line 142:

   bool operator()(char __c) {return (__m & static_cast<unsigned char>(__c)) != 0;}

stlport/stl/_limits.h
Line 141:

  static _Int (_STLP_CALL min) () _STLP_NOTHROW { return static_cast<_Int>(__imin); }

Line 142:

  static _Int (_STLP_CALL max) () _STLP_NOTHROW { return static_cast<_Int>(__imax); }

Line 150:

  (static_cast<int>((sizeof(_Int) * (CHAR_BIT))) - ((__imin == 0) ? 0 : 1))

stlport/stl/_ostream.c

Line 105:

      __from->gbump(static_cast<int>(__nwritten));

stlport/stl/_istream.c

Line 602:

      __buf->_M_gbump(static_cast<int>(__chunk));

Line 816:

                         _Is_wspace_null<_Traits>(static_cast<const ctype<_CharT>*>(this->_M_ctype_facet())),

Line 817:

                         _Scan_wspace_null<_Traits>(static_cast<const ctype<_CharT>*>(this->_M_ctype_facet())),

Line 820:

                           _Is_wspace_null<_Traits>(static_cast<const ctype<_CharT>*>(this->_M_ctype_facet())),

Line 887:

      __buf->_M_gbump(static_cast<int>(__p - __buf->_M_gptr()));

Line 996:

        __buf->_M_gbump(static_cast<int>(__chunk));

Line 1010:

        __buf->_M_gbump(static_cast<int>(__chunk));

Line 1150:

                       _Is_not_wspace<_Traits>(static_cast<const ctype<_CharT>*>(this->_M_ctype_facet())),

Line 1151:

                       _Scan_for_not_wspace<_Traits>(static_cast<const ctype<_CharT>*>(this->_M_ctype_facet())),

Line 1155:

                         _Is_not_wspace<_Traits>(static_cast<const ctype<_CharT>*>(this->_M_ctype_facet())),

Line 1266:

      __src->_M_gbump(static_cast<int>(__n));